From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.88]) by mx.groups.io with SMTP id smtpd.web11.23897.1621865725242017435 for ; Mon, 24 May 2021 07:15:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=D4xqRduO; spf=pass (domain: arm.com, ip: 40.107.7.88, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CFnnbqzNPQHdzh1kaFH5UfM+Shhw6POoBPkIgfyls8E=; b=D4xqRduO2PImn07KDUTzYwuBi2r5cQaLnTc8Hjq2KI3xh+biqESwkX8ApgFAr8tlgk9g6MXJKcw1wbaocM08WFu/JfDbaHXrLRkkeIQCwgTOiRUeMJazEfv/y8AC3/dfMD+jKlCGMDG7QfmAtlxe/btuEbLqut4xwzo4nhwhkds= Received: from DB6PR0802CA0041.eurprd08.prod.outlook.com (2603:10a6:4:a3::27) by VI1PR0802MB2174.eurprd08.prod.outlook.com (2603:10a6:800:9c::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.27; Mon, 24 May 2021 14:15:21 +0000 Received: from DB5EUR03FT016.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:a3:cafe::4c) by DB6PR0802CA0041.outlook.office365.com (2603:10a6:4:a3::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.23 via Frontend Transport; Mon, 24 May 2021 14:15:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; edk2.groups.io; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;edk2.groups.io; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DB5EUR03FT016.mail.protection.outlook.com (10.152.20.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25 via Frontend Transport; Mon, 24 May 2021 14:15:21 +0000 Received: ("Tessian outbound 3c5232d12880:v92"); Mon, 24 May 2021 14:15:21 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 14cc26f952bc7d80 X-CR-MTA-TID: 64aa7808 Received: from a7bad814f1fd.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 46114394-E236-4632-92EA-A1A97A88823C.1; Mon, 24 May 2021 14:15:06 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a7bad814f1fd.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 24 May 2021 14:15:06 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i7g1JRexC5E8NIpWS7njvKqW+O1tX3m4C/jbXk5uYGu0D5jlbKeUF3kkJYbRGyCIQ/TTlqFw3o75LuZ++gljurIH2s+yBdYU8VwTr8tTk6C5Jh0sqdIzY8T82iVAO+wIlc3lFOUxjUQeULIWMaUryoWetrYqeciHC8U/lsVF7M3owvgkhEPlmH0Bi7IsEbQa5QbzXIw5wjB/wgIulGrLaR8m4Rm+oo3lINhmrC1ZLNcMbvFgzrGpIcvdUdt5fX9iJzgiDYOhj8YAAeDkwAcxDU+RkuNMwtkVmQhXUBHbIXJrLv4kZiV9p4lAMMkpLk2VCgN0L/VXyFk6fR2xrwaL9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CFnnbqzNPQHdzh1kaFH5UfM+Shhw6POoBPkIgfyls8E=; b=ki1FiD5yZHml34XmfX5hZ7/QX6wNzDs0cpSqnCJ6a/JEc6CorGd9YLNzEAtmTWlRlbPvABG40e3RIOZ3T69UhqsgsBLs1davbUV72yogHp4e9nM+YFMLQ2K+uY/7QaoUYv/3TldlrAI+AuVEXZB4i40057PoscchcFqCBFXF/WK2bsnQPJrJvAsuodNDlxBgXo7jT3WVi8zku47Cync0Ez6ksZmAcIONb+KteYIVaXYssgwh3CIOT+0u9d6weNsasTpOxbYEcfoePZVuHayuPWShRajJI1MZsmP7xd7BrtfsSqv2Zlcga6QD0ekLZ2UbCmfaxg+iDhgHkaBxywA/cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CFnnbqzNPQHdzh1kaFH5UfM+Shhw6POoBPkIgfyls8E=; b=D4xqRduO2PImn07KDUTzYwuBi2r5cQaLnTc8Hjq2KI3xh+biqESwkX8ApgFAr8tlgk9g6MXJKcw1wbaocM08WFu/JfDbaHXrLRkkeIQCwgTOiRUeMJazEfv/y8AC3/dfMD+jKlCGMDG7QfmAtlxe/btuEbLqut4xwzo4nhwhkds= Authentication-Results-Original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM6PR08MB3543.eurprd08.prod.outlook.com (2603:10a6:20b:48::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.27; Mon, 24 May 2021 14:15:05 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::80cb:878d:c8f1:2688]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::80cb:878d:c8f1:2688%7]) with mapi id 15.20.4150.027; Mon, 24 May 2021 14:15:05 +0000 Subject: Re: [edk2-platforms][PATCH V1 6/6] Platform/Sgi: Extend SMBIOS support for RD-N2-Cfg1 To: Pranav Madhu , devel@edk2.groups.io Cc: Ard Biesheuvel , nd@arm.com References: <20210519082247.3003-1-pranav.madhu@arm.com> <20210519082247.3003-7-pranav.madhu@arm.com> From: "Sami Mujawar" Message-ID: <9ce4c4ee-fa1f-573b-e211-993cd614718b@arm.com> Date: Mon, 24 May 2021 15:15:03 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 In-Reply-To: <20210519082247.3003-7-pranav.madhu@arm.com> X-Originating-IP: [217.140.106.52] X-ClientProxiedBy: LO4P123CA0083.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:190::16) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.1.196.43] (217.140.106.52) by LO4P123CA0083.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:190::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.23 via Frontend Transport; Mon, 24 May 2021 14:15:04 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cfcefc36-09d1-4c22-cca8-08d91ebe5dc9 X-MS-TrafficTypeDiagnostic: AM6PR08MB3543:|VI1PR0802MB2174: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:1122;OLM:1122; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: LF3qTC1icfHoRuU9VGeADEdQ7xLN/ocJzRaMsMp+ZCBEfxmW2qZBTnE1YCvD19WVLlle0g+GiyidbJ4OMW43eR0fy5ScHknTAwZL69/Odc7cQkoVVFikNAYE1L/yPnoqjltuBss9rEsCBBmFQ94tt/bcWZuORg5cIqi8dYApHDacHu7SVJc6hHYxgXRTB06QmeVmiPbqKwTEdcgcQ2sB/w4cyPiFd1mITel3UNrC84yXSY21qbDzU6JE8hKhXLZutqgm1ZlxSaY14FfxoDFp0FeMR7Ssx7I6CA/8KHY73fvkPV0oZMhvJTPk2G8gS0ymDry/t2XovWyRQCufZF6LYVHu3gfetNzFSSnE+D2EccszRl99eA5grfDCNOU5G4fwcJutpWmii60m/LSg2OnxAhtgZtI20zsmKuR6gDtBFZh7Scxens/165MpxPcaGFt/1vI9/4k0N7OoEtMpfatiLlkq2xiHucUzY8GxBtou16SdrUn5xsB/cXpPOTJcu3/etELPskobW5j5HxbQKbwr8uZwynHoZYIZSxx9BcpIBTaKL2dYWCtaqceTSjEw0Y91MPEisRwTokTFC9eOP7gHi32XosITsVPRffSvTJu2mU2+k+WPoO2EtYIFSU6vlcPgL3EiUpl3kIPXYJHr+G6ZG6Szb+dkHMrJ7s0OA/GGNr4+8QXkHuND90YXmOc0fKXmGDVBNU4aqukuAKI/BMZDwHuPSoXocrGzNulCbHGE7Yk= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(39860400002)(366004)(136003)(396003)(346002)(66946007)(66476007)(66556008)(6486002)(8936002)(956004)(26005)(2616005)(31696002)(19627235002)(44832011)(31686004)(53546011)(38350700002)(33964004)(316002)(16576012)(52116002)(5660300002)(38100700002)(36756003)(83380400001)(478600001)(4326008)(86362001)(186003)(16526019)(8676002)(2906002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?UmNlekk1MU1pNVNUS2JQQTMybkt4Z2twYXhFd2JxbzBqT3FXaDZ4dEFrUHlx?= =?utf-8?B?NDREQ290Tk1aK0svSmdoT0lyTDhiY2ppbEYwWVYvdU1nSjlIbCtjSnkzcGkr?= =?utf-8?B?UWozZG80bjlQRHhXZlVIM3dlS2tuSzFMWFE1OU5oVkFnQkI3VnBsWG5mTFRZ?= =?utf-8?B?NTUvWlFLZkdsMUlMcXBySm8wM3hwNGhwaTVZVTdXM1lXQkNlcVJVMlN3WW9W?= =?utf-8?B?eVZTL1pSVnNpdmRZSWozZHZkRVJ1eHNqQm12bCtDdGFQU0kyZnJnbFVITXZ5?= =?utf-8?B?TXFkMEZ0YVpnSE5PVXNzS2JpMGlyaW9XNGxiZVNPU1BYejBuT2FZblIxQnMw?= =?utf-8?B?RmxrbndtMEx6NnlLOGV5OVp5cDg2TFhpb1FyZWJWR2lHQU5zYml6OUUrMFNT?= =?utf-8?B?Nm5hYVhrQ3lyeHFRa1E1U0ltT1pTejEwNStXaWNKT2dXZU84VERMVnAydHc5?= =?utf-8?B?ZE8rcGpaVW56b3JjVWppai9HSm9XelV2NXlTUms4eExBZllRTWNwNEU5OFZG?= =?utf-8?B?aUxPMGU4M1NIaU90RlpXRjNPODFNZWIrdEFsd2xQQTlQenBVNS82YU1XZDRC?= =?utf-8?B?eVlPRmJZZXJwa1cwb21ySkF5T0tYR1ZVY0VRemNxc1h4R1RmNXIyOWdZQXNr?= =?utf-8?B?cFIySHdPanJyVFlWVi9NSjVRS0wxYThYL2psZDlUL3FneUdKcnk3cExMODZl?= =?utf-8?B?dkg2Z0hUSjdBUlRxQ2haaGp4OFhPeFBtdVJQdGN5dHVhOGd2eTNrVGZnS1Fy?= =?utf-8?B?aXZTaXZwNHpBZjAyWVg3TlNuVEhCTE5kT0tJVEhiQ1RxalZlU2pmUU9HUkpx?= =?utf-8?B?ZjdPS2ZCUThqUDROSG9ZRjVGa1BncHBBN0NuL3kxMnpCUGxjR2dRMzJIZzZt?= =?utf-8?B?Y2JqTXZwTGh5TnFrOEw4TndzdjN3VlM0MU9La3NielZ0Y1UwRGN5M2RJMWJu?= =?utf-8?B?Z01zUHI0YUxJRVZ3NWprNWVocFFyTGxtM28ya2ZmVmY1WWVCYWxjRmVpWGZN?= =?utf-8?B?T2c3Z2pmT3ZjQytOSUhCMXBSUGRoUTN6TGxBOUMvTHAwN1FsRUVla2RheVFW?= =?utf-8?B?K2pacTRKaGxjQTByWUhtL3ROUEIvR1NuNm1iZ0pKeEdYdVhGQm9HbDVwS3k0?= =?utf-8?B?eVFIckdpeVJ1MHp2a0h6YUhnQVBoMWREbldXUWZGMW8zZ01LWUpvczgrRkxa?= =?utf-8?B?a2Q3UkZCM1BLRUdwOGZ6RmExd1dmeDBzYzFFMXNhOUs4bnIzMXVUMDZXcUNZ?= =?utf-8?B?SG5XcHA0aVdQRU83RXlhc05KeTBQQTNURG1IbEtldDhaK3JDZTBKR1QzeDZJ?= =?utf-8?B?WXp2WTh4VHFjZGFZUythcVlncW1xUitZVzY3THZFaDdkTitoQUU0dXdJZk15?= =?utf-8?B?V3h0dTUrNG9jY0ZzajFqeTlFNS9SWHkwSm14cnF4VFlEejhLTU4yK0VISVV0?= =?utf-8?B?bU51QnpMZ1YwdTcremxJQzlETTN1L0cwcUhDRzJNWm5WUUlLcTVuc0xXak5W?= =?utf-8?B?bDc3R0w4Y2hYUWUvSWxGZFNVai9NZDZDaE5KMXdMdXpQaVA5SEFNbkV6bHRo?= =?utf-8?B?dXArLzlzTlMwNVJ2S2srSmJrc2swTm0wK2RiQXkvcWJjTnljNkY3MHpBSVJa?= =?utf-8?B?Mnd2MGR6RXhjR3E5WkhEZHEwWGN1ZzRnNVgwWWxvY3ZHN0NRZTIrb2JzanNI?= =?utf-8?B?TzBjbnZtY3FKT1VaNFgzRGdrQlZGcjYvdVVqRFJMMEt3N05LTlcrSmZHM2hH?= =?utf-8?Q?91drzo1nLuCvXPRjr0llpVIXUscrMt07ebm26rV?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3543 Original-Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DB5EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 7d98d167-a1b4-4ee4-e6af-08d91ebe53e0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TbvSTGWcjcGyUGpw/+0hLjHpeb1Q4aR6IFRHx5qrq/arVnKhGs1feRS7TMOmAqTW00X6/nPq0jHQK/FbGMfqZgtg+kKyAQs1/JS4/WKCvsyhPmlYXsDCj9WAtrfUeNCzVohm2G8rKXP7V4yFDGKHKWaO8Xb8DJOTGbbfNAp8SAa95swDqLefZLSuIFiRgmAIS57q2UA26tmRdDT0Q2YKIGv53TQZSSzfpJQEwzbYOiJQEhuexU1dmt6cid5PSpCeu52vf3QxzQCuMdRL/GXLprQoHFFUrMuT5TNVA8i7S5MzPK0RnDMY5yLOPrnia+7gFVg6nFmSpmYibCRR9UWCH1XwMPvcGJhkZDaVx1DRupDVo2sKx4PikIIGW0ahEKPbHfDbdktWTJ33ToIlzsWTbMRI1+mlFFilzBhtM5wb0h1CvMlAiXApJYoqjwJCQUjpR4n44Ro8T5ImGaJoRAAbBYULhO+P/RgX15rgMD+vFawAXSvebqaT0Gbr7A85ESrTG0xNfr659nnWhKse4SDgrnK296NjD2UkpRiVIZqkZo20tOxolcriOzU54YKdUCmL23J0ppvTx2h1O6zUc53Nu0qIbLvlk9ogKoivXp3ErALejzlryPS8Usn8mCjIRinmyjLowXXt65F3RgyqLtwpAxPLeWl8U3ckuSQz0gvGVSFR4aCKsyp8borIssc9U89C X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(4636009)(396003)(136003)(376002)(346002)(39860400002)(46966006)(36840700001)(44832011)(26005)(47076005)(4326008)(81166007)(5660300002)(2906002)(316002)(82740400003)(70586007)(956004)(53546011)(36860700001)(2616005)(16576012)(31696002)(31686004)(8676002)(33964004)(336012)(356005)(83380400001)(70206006)(86362001)(16526019)(478600001)(19627235002)(186003)(6486002)(82310400003)(8936002)(36756003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2021 14:15:21.5671 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cfcefc36-09d1-4c22-cca8-08d91ebe5dc9 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DB5EUR03FT016.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0802MB2174 Content-Type: multipart/alternative; boundary="------------91BDA5260A42F937469DFA1E" Content-Language: en-GB --------------91BDA5260A42F937469DFA1E Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi Pranav, This patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 19/05/2021 09:22 AM, Pranav Madhu wrote: > Extend the SMBIOS support for RD-N2-Cfg1 platform. RD-N2-Cfg1 platform > is a derivative of the RD-N2 platform and so most of the table values > for RD-N2 platform is reused. > > Signed-off-by: Pranav Madhu > --- > Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c | 7 +++++-- > Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformation.c | 7 +++++-- > Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c | 18 ++++++++++++++++++ > 3 files changed, 28 insertions(+), 4 deletions(-) > > diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c > index 367587c07673..e8326cc6ef14 100644 > --- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c > +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c > @@ -31,7 +31,8 @@ > "RdE1Edge\0" \ > "RdV1\0" \ > "RdV1Mc\0" \ > - "RdN2\0" > + "RdN2\0" \ > + "RdN2Cfg1\0" > > typedef enum { > ManufacturerName = 1, > @@ -64,7 +65,9 @@ STATIC GUID mSmbiosUid[] = { > /* Rd-V1Mc */ > {0x1f3a0806, 0x18b5, 0x4eca, {0xad, 0xcd, 0xba, 0x9b, 0x07, 0xb1, 0x0a, 0xcf}}, > /* Rd-N2 */ > - {0xf2cded73, 0x37f9, 0x4ec9, {0xd9, 0xf9, 0x89, 0x9b, 0x74, 0x91, 0x20, 0x49}} > + {0xf2cded73, 0x37f9, 0x4ec9, {0xd9, 0xf9, 0x89, 0x9b, 0x74, 0x91, 0x20, 0x49}}, > + /* Rd-N2-Cfg1 */ > + {0xa4941d3d, 0xfac3, 0x4ace, {0x9a, 0x7e, 0xce, 0x26, 0x76, 0x64, 0x5e, 0xda}}, > }; > > /* System information */ > diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformation.c b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformation.c > index 9ecaea3603de..b554ee6dea58 100644 > --- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformation.c > +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformation.c > @@ -27,7 +27,7 @@ > #define SOCKET_TYPE_BASE 3 > #define SOCKET_TYPE_NUM 1 > #define PROCESSOR_VERSION_BASE (SOCKET_TYPE_BASE + SOCKET_TYPE_NUM) > -#define PROCESSOR_VERSION_NUM 8 > +#define PROCESSOR_VERSION_NUM 9 > #define SERIAL_NUMBER_BASE (PROCESSOR_VERSION_BASE + PROCESSOR_VERSION_NUM) > #define TYPE4_STRINGS \ > "0x000\0" /* Part Number */ \ > @@ -41,6 +41,7 @@ > "Neoverse-V1\0" \ > "Neoverse-V1\0" \ > "Neoverse-N2\0" \ > + "Neoverse-N2\0" \ > "000-0\0" /* Serial number */ \ > "783-3\0" \ > "786-1\0" \ > @@ -48,7 +49,8 @@ > "786-2\0" \ > "78A-1\0" \ > "78A-2\0" \ > - "7B7-1\0" > + "7B7-1\0" \ > + "7B6-1\0" > > typedef enum { > PartNumber = 1, > @@ -173,6 +175,7 @@ InstallType4ProcessorInformation ( > mArmRdSmbiosType4.Base.ThreadCount = CoreCount; > break; > case RdN2: > + case RdN2Cfg1: > mArmRdSmbiosType4.Base.CoreCount = CoreCount; > mArmRdSmbiosType4.Base.EnabledCoreCount = CoreCount; > mArmRdSmbiosType4.Base.ThreadCount = CoreCount; > diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c > index 6be62900bd71..aec7c1b585fc 100644 > --- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c > +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c > @@ -315,6 +315,24 @@ InstallType7CacheInformation ( > mArmRdSmbiosType7[4].Base.InstalledSize2 = 32768; // 32MB SLC > mArmRdSmbiosType7[4].Base.Associativity = CacheAssociativity16Way; > break; > + case RdN2Cfg1: > + /* L1 instruction cache */ > + mArmRdSmbiosType7[0].Base.MaximumCacheSize2 = 64; // 64KB > + mArmRdSmbiosType7[0].Base.InstalledSize2 = 64; // 64KB > + mArmRdSmbiosType7[0].Base.Associativity = CacheAssociativity4Way; > + /* L1 data cache */ > + mArmRdSmbiosType7[1].Base.MaximumCacheSize2 = 64; // 64KB > + mArmRdSmbiosType7[1].Base.InstalledSize2 = 64; // 64KB > + mArmRdSmbiosType7[1].Base.Associativity = CacheAssociativity4Way; > + /* L2 cache */ > + mArmRdSmbiosType7[2].Base.MaximumCacheSize2 = 1024; // 1MB > + mArmRdSmbiosType7[2].Base.InstalledSize2 = 1024; // 1MB > + mArmRdSmbiosType7[2].Base.Associativity = CacheAssociativity8Way; > + /* System level cache */ > + mArmRdSmbiosType7[4].Base.MaximumCacheSize2 = 8192; // 8MB SLC > + mArmRdSmbiosType7[4].Base.InstalledSize2 = 8192; // 8MB SLC > + mArmRdSmbiosType7[4].Base.Associativity = CacheAssociativity16Way; > + break; > } > > /* Install valid cache information tables */ --------------91BDA5260A42F937469DFA1E Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

Hi Pranav,

This patch looks good to me.

Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>

Regards,

Sami Mujawar


On 19/05/2021 09:22 AM, Pranav Madhu wrote:
Extend the SMBIOS support for RD-N2-Cfg1 platform. RD-N2-Cfg1 platform
is a derivative of the RD-N2 platform and so most of the table values
for RD-N2 platform is reused.

Signed-off-by: Pranav Madhu <pranav.madhu@arm.com>
---
 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c    |  7 +++++--
 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformation.c |  7 +++++--
 Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c     | 18 ++++++++++++++++++
 3 files changed, 28 insertions(+), 4 deletions(-)

diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c
index 367587c07673..e8326cc6ef14 100644
--- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c
+++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c
@@ -31,7 +31,8 @@
   "RdE1Edge\0"                                          \
   "RdV1\0"                                              \
   "RdV1Mc\0"                                            \
-  "RdN2\0"
+  "RdN2\0"                                              \
+  "RdN2Cfg1\0"
 
 typedef enum {
   ManufacturerName = 1,
@@ -64,7 +65,9 @@ STATIC GUID mSmbiosUid[] = {
   /* Rd-V1Mc       */
   {0x1f3a0806, 0x18b5, 0x4eca, {0xad, 0xcd, 0xba, 0x9b, 0x07, 0xb1, 0x0a, 0xcf}},
   /* Rd-N2         */
-  {0xf2cded73, 0x37f9, 0x4ec9, {0xd9, 0xf9, 0x89, 0x9b, 0x74, 0x91, 0x20, 0x49}}
+  {0xf2cded73, 0x37f9, 0x4ec9, {0xd9, 0xf9, 0x89, 0x9b, 0x74, 0x91, 0x20, 0x49}},
+  /* Rd-N2-Cfg1    */
+  {0xa4941d3d, 0xfac3, 0x4ace, {0x9a, 0x7e, 0xce, 0x26, 0x76, 0x64, 0x5e, 0xda}},
 };
 
 /* System information */
diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformation.c b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformation.c
index 9ecaea3603de..b554ee6dea58 100644
--- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformation.c
+++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformation.c
@@ -27,7 +27,7 @@
 #define SOCKET_TYPE_BASE        3
 #define SOCKET_TYPE_NUM         1
 #define PROCESSOR_VERSION_BASE  (SOCKET_TYPE_BASE + SOCKET_TYPE_NUM)
-#define PROCESSOR_VERSION_NUM   8
+#define PROCESSOR_VERSION_NUM   9
 #define SERIAL_NUMBER_BASE      (PROCESSOR_VERSION_BASE + PROCESSOR_VERSION_NUM)
 #define TYPE4_STRINGS                                   \
   "0x000\0"                     /* Part Number */       \
@@ -41,6 +41,7 @@
   "Neoverse-V1\0"                                       \
   "Neoverse-V1\0"                                       \
   "Neoverse-N2\0"                                       \
+  "Neoverse-N2\0"                                       \
   "000-0\0"                     /* Serial number */     \
   "783-3\0"                                             \
   "786-1\0"                                             \
@@ -48,7 +49,8 @@
   "786-2\0"                                             \
   "78A-1\0"                                             \
   "78A-2\0"                                             \
-  "7B7-1\0"
+  "7B7-1\0"                                             \
+  "7B6-1\0"
 
 typedef enum {
   PartNumber = 1,
@@ -173,6 +175,7 @@ InstallType4ProcessorInformation (
     mArmRdSmbiosType4.Base.ThreadCount = CoreCount;
     break;
   case RdN2:
+  case RdN2Cfg1:
     mArmRdSmbiosType4.Base.CoreCount = CoreCount;
     mArmRdSmbiosType4.Base.EnabledCoreCount = CoreCount;
     mArmRdSmbiosType4.Base.ThreadCount = CoreCount;
diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c
index 6be62900bd71..aec7c1b585fc 100644
--- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c
+++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c
@@ -315,6 +315,24 @@ InstallType7CacheInformation (
     mArmRdSmbiosType7[4].Base.InstalledSize2 = 32768;    // 32MB SLC
     mArmRdSmbiosType7[4].Base.Associativity = CacheAssociativity16Way;
     break;
+  case RdN2Cfg1:
+    /* L1 instruction cache */
+    mArmRdSmbiosType7[0].Base.MaximumCacheSize2 = 64;    // 64KB
+    mArmRdSmbiosType7[0].Base.InstalledSize2 = 64;       // 64KB
+    mArmRdSmbiosType7[0].Base.Associativity = CacheAssociativity4Way;
+    /* L1 data cache */
+    mArmRdSmbiosType7[1].Base.MaximumCacheSize2 = 64;    // 64KB
+    mArmRdSmbiosType7[1].Base.InstalledSize2 = 64;       // 64KB
+    mArmRdSmbiosType7[1].Base.Associativity = CacheAssociativity4Way;
+    /* L2 cache */
+    mArmRdSmbiosType7[2].Base.MaximumCacheSize2 = 1024;  // 1MB
+    mArmRdSmbiosType7[2].Base.InstalledSize2 = 1024;     // 1MB
+    mArmRdSmbiosType7[2].Base.Associativity = CacheAssociativity8Way;
+    /* System level cache */
+    mArmRdSmbiosType7[4].Base.MaximumCacheSize2 = 8192;  // 8MB SLC
+    mArmRdSmbiosType7[4].Base.InstalledSize2 = 8192;     // 8MB SLC
+    mArmRdSmbiosType7[4].Base.Associativity = CacheAssociativity16Way;
+    break;
   }
 
   /* Install valid cache information tables */

--------------91BDA5260A42F937469DFA1E--