From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web12.632.1594231343584328516 for ; Wed, 08 Jul 2020 11:02:23 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=h3LKUiWV; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594231342; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zlaC92SkBgvYUxYO8qP4+/3XPVm2Yd2yv/WdjyrBI+k=; b=h3LKUiWVPtzdrVzNT7iddp9VeAPA/ipPSVAkpCYCAjxlOAwtzn4MNv0cSzUDrsY53+Fla1 dBnh3zTSORzeWffNaF7XfmM95S242iCfjP+4v21nhyRVNxpXZwB7Ld0/pXITv1DVSAmZQx N4lgfgZNkOXIw/nnm3MyF23gwOPMrP0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-114-6K0c2etVPPmLu5SzrZUezQ-1; Wed, 08 Jul 2020 14:02:20 -0400 X-MC-Unique: 6K0c2etVPPmLu5SzrZUezQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2803F88C797; Wed, 8 Jul 2020 18:02:19 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-73.ams2.redhat.com [10.36.112.73]) by smtp.corp.redhat.com (Postfix) with ESMTP id 02A5C5D9C9; Wed, 8 Jul 2020 18:02:17 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v4 8/9] UefiCpuPkg: Correct some typos. To: devel@edk2.groups.io, guomin.jiang@intel.com Cc: Eric Dong , Ray Ni , Rahul Kumar References: <20200708081059.691-1-guomin.jiang@intel.com> <20200708081059.691-9-guomin.jiang@intel.com> From: "Laszlo Ersek" Message-ID: <9cf06c92-6ddb-9a65-359b-8074263a448c@redhat.com> Date: Wed, 8 Jul 2020 20:02:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200708081059.691-9-guomin.jiang@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 07/08/20 10:10, Guomin Jiang wrote: > Correct some typos. > > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Kumar > Signed-off-by: Guomin Jiang > --- > UefiCpuPkg/CpuMpPei/CpuPaging.c | 4 ++-- > .../CpuExceptionHandlerLib/Ia32/ArchExceptionHandler.c | 4 ++-- > .../Library/CpuExceptionHandlerLib/SecPeiCpuException.c | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/UefiCpuPkg/CpuMpPei/CpuPaging.c b/UefiCpuPkg/CpuMpPei/CpuPaging.c > index 04a16fb2b620..891d1ef50cac 100644 > --- a/UefiCpuPkg/CpuMpPei/CpuPaging.c > +++ b/UefiCpuPkg/CpuMpPei/CpuPaging.c > @@ -153,7 +153,7 @@ GetPhysicalAddressWidth ( > Get the type of top level page table. > > @retval Page512G PML4 paging. > - @retval Page1G PAE paing. > + @retval Page1G PAE paging. > > **/ > PAGE_ATTRIBUTE OK. > @@ -583,7 +583,7 @@ SetupStackGuardPage ( > } > > /** > - Enabl/setup stack guard for each processor if PcdCpuStackGuard is set to TRUE. > + Enable/setup stack guard for each processor if PcdCpuStackGuard is set to TRUE. > > Doing this in the memory-discovered callback is to make sure the Stack Guard > feature to cover as most PEI code as possible. (1) This typo is present in the following two files: - UefiCpuPkg/CpuMpPei/CpuMpPei.h - UefiCpuPkg/CpuMpPei/CpuPaging.c Please fix the typo in both files. > diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchExceptionHandler.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchExceptionHandler.c > index 1aafb7dac139..903449e0daa9 100644 > --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchExceptionHandler.c > +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchExceptionHandler.c > @@ -18,8 +18,8 @@ > **/ > VOID > ArchUpdateIdtEntry ( > - IN IA32_IDT_GATE_DESCRIPTOR *IdtEntry, > - IN UINTN InterruptHandler > + OUT IA32_IDT_GATE_DESCRIPTOR *IdtEntry, > + IN UINTN InterruptHandler > ) > { > IdtEntry->Bits.OffsetLow = (UINT16)(UINTN)InterruptHandler; (2) This typo is present in the following files: - UefiCpuPkg/Library/CpuExceptionHandlerLib/CpuExceptionCommon.h - UefiCpuPkg/Library/CpuExceptionHandlerLib/Ia32/ArchExceptionHandler.c - UefiCpuPkg/Library/CpuExceptionHandlerLib/X64/ArchExceptionHandler.c Please fix the typo in all three files. > diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuException.c b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuException.c > index 20148db74cf8..d4ae153c5742 100644 > --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuException.c > +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuException.c > @@ -87,7 +87,7 @@ InitializeCpuExceptionHandlers ( > IdtEntryCount = (IdtDescriptor.Limit + 1) / sizeof (IA32_IDT_GATE_DESCRIPTOR); > if (IdtEntryCount > CPU_EXCEPTION_NUM) { > // > - // CPU exeption library only setup CPU_EXCEPTION_NUM exception handler at most > + // CPU exception library only setup CPU_EXCEPTION_NUM exception handler at most > // > IdtEntryCount = CPU_EXCEPTION_NUM; > } > Seems OK. Thanks! Laszlo