Re: [edk2-devel] [PATCH v1 2/6] OvmfPkg/OvmfPkg.dec: Add PcdShellFile in OVMF DEC file

["Laszlo Ersek" <lersek@redhat.com>]

Hi Hao,

On 05/27/19 07:19, Wu, Hao A wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1843
> 
> OVMF is currently using the PCD 'PcdShellFile' defined in
> IntelFrameworkModulePkg.
> 
> This commit will add this PCD into the OVMF DEC file in order to drop
> OVMF's dependency on IntelFrameworkModulePkg. The PCD token value 0x17 is
> selected to fill the hole (seems the only one left) in OvmfPkg.
> 
> Please note that, instead of adding the PCD under section:
> [PcdsFixedAtBuild, PcdsPatchableInModule]
> 
> as in IntelFrameworkModulePkg.dec file, it is added in section:
> [PcdsFixedAtBuild]
> 
> in OvmfPkg.dec instead.

Please replace patches #2 through #4 with the following approach:

- eliminate PcdShellFile completely, from OvmfPkg

- in PlatformBootManagerLib, please consume gUefiShellFileGuid, from
ShellPkg.dec.

(This is what ArmPkg and ArmVirtPkg do.)

Thanks!
Laszlo

> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
> ---
>  OvmfPkg/OvmfPkg.dec | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec
> index 9640360f62..38a2d4763d 100644
> --- a/OvmfPkg/OvmfPkg.dec
> +++ b/OvmfPkg/OvmfPkg.dec
> @@ -160,6 +160,9 @@ [PcdsFixedAtBuild]
>    #  For the corresponding bits, 0 = Edge triggered and 1 = Level triggered.
>    gUefiOvmfPkgTokenSpaceGuid.Pcd8259LegacyModeEdgeLevel|0x0000|UINT16|0x5
>  
> +  ## FFS filename to find the shell application.
> +  gUefiOvmfPkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 }|VOID*|0x17
> +
>    ## Indicates if BiosVideo driver will switch to 80x25 Text VGA Mode when
>    #  exiting boot service.
>    #   TRUE  - Switch to Text VGA Mode.
>