From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Thu, 13 Jun 2019 07:42:32 -0700
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 822984E92A;
	Thu, 13 Jun 2019 14:42:21 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-127.ams2.redhat.com [10.36.117.127])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 2166C54201;
	Thu, 13 Jun 2019 14:42:18 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH v1 2/6] OvmfPkg/OvmfPkg.dec: Add PcdShellFile in OVMF DEC file
To: devel@edk2.groups.io, hao.a.wu@intel.com
Cc: Ray Ni <ray.ni@intel.com>, Jordan Justen <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>
References: <20190527051922.5280-1-hao.a.wu@intel.com>
 <20190527051922.5280-3-hao.a.wu@intel.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <9d025c31-9eb9-e8c6-2602-4db235230952@redhat.com>
Date: Thu, 13 Jun 2019 16:42:18 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190527051922.5280-3-hao.a.wu@intel.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 13 Jun 2019 14:42:31 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi Hao,

On 05/27/19 07:19, Wu, Hao A wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1843
> 
> OVMF is currently using the PCD 'PcdShellFile' defined in
> IntelFrameworkModulePkg.
> 
> This commit will add this PCD into the OVMF DEC file in order to drop
> OVMF's dependency on IntelFrameworkModulePkg. The PCD token value 0x17 is
> selected to fill the hole (seems the only one left) in OvmfPkg.
> 
> Please note that, instead of adding the PCD under section:
> [PcdsFixedAtBuild, PcdsPatchableInModule]
> 
> as in IntelFrameworkModulePkg.dec file, it is added in section:
> [PcdsFixedAtBuild]
> 
> in OvmfPkg.dec instead.

Please replace patches #2 through #4 with the following approach:

- eliminate PcdShellFile completely, from OvmfPkg

- in PlatformBootManagerLib, please consume gUefiShellFileGuid, from
ShellPkg.dec.

(This is what ArmPkg and ArmVirtPkg do.)

Thanks!
Laszlo

> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
> ---
>  OvmfPkg/OvmfPkg.dec | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/OvmfPkg/OvmfPkg.dec b/OvmfPkg/OvmfPkg.dec
> index 9640360f62..38a2d4763d 100644
> --- a/OvmfPkg/OvmfPkg.dec
> +++ b/OvmfPkg/OvmfPkg.dec
> @@ -160,6 +160,9 @@ [PcdsFixedAtBuild]
>    #  For the corresponding bits, 0 = Edge triggered and 1 = Level triggered.
>    gUefiOvmfPkgTokenSpaceGuid.Pcd8259LegacyModeEdgeLevel|0x0000|UINT16|0x5
>  
> +  ## FFS filename to find the shell application.
> +  gUefiOvmfPkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 }|VOID*|0x17
> +
>    ## Indicates if BiosVideo driver will switch to 80x25 Text VGA Mode when
>    #  exiting boot service.
>    #   TRUE  - Switch to Text VGA Mode.
>