From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Wed, 10 Apr 2019 01:48:44 -0700
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 828A23001A84;
	Wed, 10 Apr 2019 08:48:43 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-49.rdu2.redhat.com [10.10.120.49])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 56876600D4;
	Wed, 10 Apr 2019 08:48:41 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH v2 01/31] OvmfPkg/ResetSystemLib: Add missing dependency on PciLib
To: devel@edk2.groups.io, anthony.perard@citrix.com
Cc: Jordan Justen <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@linaro.org>,
 Julien Grall <julien.grall@arm.com>, xen-devel@lists.xenproject.org
References: <20190409110844.14746-1-anthony.perard@citrix.com>
 <20190409110844.14746-2-anthony.perard@citrix.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <9d0a2a9b-21b9-de51-c232-c6847d7b03b3@redhat.com>
Date: Wed, 10 Apr 2019 10:48:39 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190409110844.14746-2-anthony.perard@citrix.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Wed, 10 Apr 2019 08:48:43 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 04/09/19 13:08, Anthony PERARD wrote:
> and remove extra includes of OvmfPlatforms.h.

(1) In commit messages, please don't rely on the subject line, and the
first paragraph of the body, being read as a single sentence.
(Similarly, please avoid empy commit message bodies.) If there's no
better way to prevent this, then just repeat the subject line in te
first paragraph.

I realize this is subjective & project dependent; it's certainly my
preference, but I recall other reviewers requesting the same on edk2-devel.

> 
> Contributed-under: TianoCore Contribution Agreement 1.1

(2) Please drop this line from all the commit messages:
<https://bugzilla.tianocore.org/show_bug.cgi?id=1655#c0>.

> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
> 
> Notes:
>     v2:
>     - also add PciLib.h include to the .c
>     - and remove extra include of OvmfPlatforms.h
> 
>  OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf | 1 +
>  OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c   | 3 +--
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf
> index 39ca805730..ebd722e66b 100644
> --- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf
> +++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf
> @@ -36,4 +36,5 @@ [Packages]
>  [LibraryClasses]
>    DebugLib
>    IoLib
> +  PciLib
>    TimerLib
> diff --git a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
> index cc75d046a8..9348502836 100644
> --- a/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
> +++ b/OvmfPkg/Library/ResetSystemLib/ResetSystemLib.c
> @@ -17,11 +17,10 @@
>  #include <Library/BaseLib.h>
>  #include <Library/DebugLib.h>
>  #include <Library/IoLib.h>
> +#include <Library/PciLib.h>
>  #include <Library/TimerLib.h>
>  #include <OvmfPlatforms.h>
>  
> -#include <OvmfPlatforms.h>
> -
>  VOID
>  AcpiPmControl (
>    UINTN SuspendType
> 

Hm, the duplicated #include is my fault, from commit 1466b76f9385
("OvmfPkg: determine PMBA value dependent on host bridge device ID",
2016-05-17). Thanks for fixing that up.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>