From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.6105.1582208407827720707 for ; Thu, 20 Feb 2020 06:20:08 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: liming.gao@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Feb 2020 06:20:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,464,1574150400"; d="scan'208";a="283415394" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 20 Feb 2020 06:20:07 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 20 Feb 2020 06:20:07 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by SHSMSX601.ccr.corp.intel.com (10.109.6.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 20 Feb 2020 22:20:05 +0800 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.1713.004; Thu, 20 Feb 2020 22:20:05 +0800 From: "Liming Gao" To: "devel@edk2.groups.io" , "Bi, Dandan" , "nickle.wang@hpe.com" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT. Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT. Thread-Index: AQHV5zAxpbw4LUtwD0qs/UnjhkDSMagjObwAgADpXXA= Date: Thu, 20 Feb 2020 14:20:05 +0000 Message-ID: <9d20d94f6d8e4c12b5a3f1fd89c4b45b@intel.com> References: <20200219142240.10448-1-nickle.wang@hpe.com> <3C0D5C461C9E904E8F62152F6274C0BB40D4473F@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <3C0D5C461C9E904E8F62152F6274C0BB40D4473F@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-product: dlpe-windows dlp-reaction: no-action x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Return-Path: liming.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Nickle: Is this a real issue found in production? Thanks Liming > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Dandan Bi > Sent: Thursday, February 20, 2020 4:24 PM > To: devel@edk2.groups.io; nickle.wang@hpe.com > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZe= roGuid() ASSERT. >=20 > Thanks Nickle for the fix. > One minor comment is that please pay attention to the format of commit m= essage. > Refer to https://github.com/tianocore/tianocore.github.io/wiki/Commit-M= essage-Format, Line length of commit message should be less > than 76 characters when possible. > Please address it when submit the patch. > Reviewed-by: Dandan Bi >=20 >=20 > Thanks, > Dandan >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Nickle Wang > > Sent: Wednesday, February 19, 2020 10:23 PM > > To: devel@edk2.groups.io; nickle.wang@hpe.com > > Cc: Bi, Dandan > > Subject: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix > > IsZeroGuid() ASSERT. > > > > From the function description of GetIfrBinaryData(), FormSetGuid can b= e > > NULL. However, FormSetGuid is passed to IsZeroGuid(). This causes > > exception when FormSetGuid is NULL. > > > > Signed-off-by: Nickle Wang > > --- > > MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > index 288f1c3197..82067b541c 100644 > > --- a/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > +++ b/MdeModulePkg/Universal/SetupBrowserDxe/Setup.c > > @@ -2,6 +2,7 @@ > > Entry and initialization module for the browser. > > > > Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved. > > +(C) Copyright 2020 Hewlett Packard Enterprise Development LP
> > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > **/ > > @@ -5844,7 +5845,7 @@ GetIfrBinaryData ( > > // > > // Try to compare against formset GUID > > // > > - if (IsZeroGuid (FormSetGuid) || > > + if (IsZeroGuid (ComparingGuid) || > > CompareGuid (ComparingGuid, (EFI_GUID *)(OpCodeData + s= izeof > > (EFI_IFR_OP_HEADER)))) { > > break; > > } > > -- > > 2.20.1.windows.1 > > > > > > >=20 >=20 >=20