Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Warn if out of flash space when writing variables

["Laszlo Ersek" <lersek@redhat.com>]

On 3/4/24 16:18, Oliver Steffen wrote:
> Emit a DEBUG_WARN message if there is not enough flash space left to
> write/update a variable. This condition is currently not logged
> appropriately in all cases, given that full variable store can easily
> render the system unbootable.
> This new message helps identifying this condition.
> 
> Cc: Bob Feng <bob.c.feng@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Yuwei Chen <yuwei.chen@intel.com>
> 
> Signed-off-by: Oliver Steffen <osteffen@redhat.com>
> ---
>  MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
> index d394d237a53f..1c7659031dc5 100644
> --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
> +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c
> @@ -2364,6 +2364,8 @@ UpdateVariable (
>                    );
>        ASSERT_EFI_ERROR (Status);
>      }
> +  } else if (Status == EFI_OUT_OF_RESOURCES) {
> +    DEBUG ((DEBUG_WARN, "UpdateVariable failed: Out of flash space\n"));
>    }
>  
>    return Status;

- I think DEBUG_ERROR is justified here, too.

- Not sure if "flash" is a term that's appropriate for this driver. The
function-top comment refers to "Variable region".

But these are just superficial observations.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116333): https://edk2.groups.io/g/devel/message/116333
Mute This Topic: https://groups.io/mt/104723945/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-