From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2624021A07A82 for ; Tue, 27 Nov 2018 03:02:44 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E46EE3961; Tue, 27 Nov 2018 11:02:43 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-96.rdu2.redhat.com [10.10.120.96]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1547E5DA9A; Tue, 27 Nov 2018 11:02:38 +0000 (UTC) To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" , Anthony PERARD , Andrew Jones , Igor Mammedov , Jordan Justen , Julien Grall , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20181125100152.25675-1-lersek@redhat.com> From: Laszlo Ersek Message-ID: <9d266d9d-4e5a-5e0b-e26f-9fb593ad4d93@redhat.com> Date: Tue, 27 Nov 2018 12:02:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 27 Nov 2018 11:02:44 +0000 (UTC) Subject: Re: [PATCH 0/4] OvmfPkg, ArmVirtPkg: add ACPI Test Support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 X-List-Received-Date: Tue, 27 Nov 2018 11:02:45 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 11/26/18 18:21, Ard Biesheuvel wrote: > On Sun, 25 Nov 2018 at 11:02, Laszlo Ersek wrote: >> >> Repo: https://github.com/lersek/edk2.git >> Branch: acpi_test_support >> >> The feature is described in the first patch. Build OvmfPkg and >> ArmVirtPkg platforms with "--pcd PcdAcpiTestSupport=TRUE" to enable it. >> >> Cc: Anthony Perard >> Cc: Ard Biesheuvel >> Cc: Drew Jones >> Cc: Igor Mammedov >> Cc: Jordan Justen >> Cc: Julien Grall >> Cc: Philippe Mathieu-Daudé >> >> Thanks, >> Laszlo >> >> Laszlo Ersek (4): >> OvmfPkg: introduce ACPI Test Support data structure and GUID >> OvmfPkg/AcpiPlatformDxe: list missing lib classes for >> QemuFwCfgAcpiPlatformDxe >> OvmfPkg/AcpiPlatformDxe: add [Un]RegisterAcpiTestSupport() skeletons >> OvmfPkg/AcpiPlatformDxe: fill in ACPI_TEST_SUPPORT at first >> Ready-To-Boot >> > > I'm not crazy about scraping memory, but since this is a test feature, > and since the hypervisor can be trusted to only scrape regions > populated with non-secure DRAM, I can live with it. > > Regarding the GUID: i thought about perhaps using the XOR of two known > GUIDs, but bitwise negation involving a all-ones GUID amounts to the > same thing in the end, so whatever :-) > > Reviewed-by: Ard Biesheuvel Thanks :) > >> OvmfPkg/AcpiPlatformDxe/AcpiPlatform.h | 10 ++ >> OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 8 ++ >> OvmfPkg/AcpiPlatformDxe/AcpiTestSupport.c | 119 ++++++++++++++++++++ >> OvmfPkg/AcpiPlatformDxe/EntryPoint.c | 24 +++- >> OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf | 10 ++ >> OvmfPkg/Include/Guid/AcpiTestSupport.h | 67 +++++++++++ >> OvmfPkg/OvmfPkg.dec | 6 + >> 7 files changed, 239 insertions(+), 5 deletions(-) >> create mode 100644 OvmfPkg/AcpiPlatformDxe/AcpiTestSupport.c >> create mode 100644 OvmfPkg/Include/Guid/AcpiTestSupport.h >> >> -- >> 2.19.1.3.g30247aa5d201 >>