From: "Rebecca Cran" <rebecca@bsdio.com>
To: Ard Biesheuvel <ardb@kernel.org>, devel@edk2.groups.io
Cc: Liming Gao <gaoliming@byosoft.com.cn>,
Bob Feng <bob.c.feng@intel.com>,
Yuwei Chen <yuwei.chen@intel.com>
Subject: Re: [edk2-devel] [edk2-stable202305 PATCH 2/4] BaseTools: Set the CLANGDWARF OBJCOPY path in tools_def.template
Date: Wed, 10 May 2023 06:09:09 -0600 [thread overview]
Message-ID: <9d398003-436a-0d99-66b5-17a84eb62e34@bsdio.com> (raw)
In-Reply-To: <CAMj1kXGkQyiRa_fojeK-o_=wbrzkHsvnGxOOKKJyK+O8_a2sDA@mail.gmail.com>
On 5/10/23 05:03, Ard Biesheuvel wrote:
> On Wed, 10 May 2023 at 01:53, Rebecca Cran <rebecca@bsdio.com> wrote:
>> Set the OBJCOPY path for the CLANGDWARF toolchain to 'llvm-objcopy' to
>> override the default of 'echo'.
>>
>> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> This appears to break the AArch64 CLANGDWARF build.
>
> https://ci.linaro.org/job/leg-virt-tianocore-edk2-upstream/4880/console
Ugh, I'm sorry. We're not overriding the OBJCOPY_FLAGS for ARM and
AARCH64, so it uses the default of "not needed for" which previously got
echoed.
I'll work on a better local testing process to avoid such an obvious
breakage in future.
Would you like this commit reverted, or should I submit a patch to fix it?
--
Rebecca Cran
next prev parent reply other threads:[~2023-05-10 12:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 23:53 [edk2-stable202305 PATCH 0/4] BaseTools: Fix CLANGDWARF HII resource rules and paths Rebecca Cran
2023-05-09 23:53 ` [edk2-stable202305 PATCH 1/4] BaseTools: Remove BUILDRULEFAMILY from CLANGDWARF in tools_def.template Rebecca Cran
2023-05-09 23:53 ` [edk2-stable202305 PATCH 2/4] BaseTools: Set the CLANGDWARF OBJCOPY path " Rebecca Cran
2023-05-10 11:03 ` [edk2-devel] " Ard Biesheuvel
2023-05-10 12:09 ` Rebecca Cran [this message]
2023-05-10 12:10 ` Ard Biesheuvel
2023-05-10 12:33 ` Rebecca Cran
2023-05-09 23:53 ` [edk2-stable202305 PATCH 3/4] BaseTools: Set CLANGDWARF RC path to llvm-objcopy " Rebecca Cran
2023-05-09 23:53 ` [edk2-stable202305 PATCH 4/4] BaseTools: Remove the CLANGCC build rule for Hii-Binary-Package.UEFI_HII Rebecca Cran
2023-05-10 2:36 ` [edk2-devel] [edk2-stable202305 PATCH 0/4] BaseTools: Fix CLANGDWARF HII resource rules and paths Michael D Kinney
2023-05-10 2:40 ` Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9d398003-436a-0d99-66b5-17a84eb62e34@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox