From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mx.groups.io with SMTP id smtpd.web10.14823.1683720553923214581 for ; Wed, 10 May 2023 05:09:14 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm1 header.b=fzyAc9DR; spf=pass (domain: bsdio.com, ip: 64.147.123.19, mailfrom: rebecca@bsdio.com) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id D4417320083A; Wed, 10 May 2023 08:09:12 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 10 May 2023 08:09:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1683720552; x=1683806952; bh=JDeR9g3oKt6QczICaUSX/C76Y/oAUgSFirf sD6GN5RM=; b=fzyAc9DRmZIQzRmBfEpCPZuYuWJrCz9PMnWkzcMu3nL+ZoKUJDX CbLW0LcAFYQfovW1wLO4Wd/QIGok1VuG1Be/xK+UiYu3gTH5RmtUUnSy5i2rx2gL /qxL3UY4h3SOw3JTXAEu3QCYqnDY6ig2IEW2Kg29KF15/khTgQw+inJCNeGNCjgo B2LzCY0zcW3o/Eed3CgzQpGQ+U8HN6mIMcHHKnSdZTSnP9lWkcGiL9tbBDOjxbtF md08oQPvJDTkoCX7iIqf0u0j4UKwYHbxMrJKyws7rGNpGHiHqdc7aAvNhoFWvnBs 7+Pyw6uiy6VQjDuPz9Vc869XJ9Nfe+ueaiA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1683720552; x=1683806952; bh=JDeR9g3oKt6QczICaUSX/C76Y/oAUgSFirf sD6GN5RM=; b=Fj+7tyft55Iiu5ezfDfY3HJ7JK56SolnK+KQEMaIy9qMfGPvinQ VQBlfRGnmz++VCDFcrd1VO0sFR8Ty69nGNncq1yYbLBf8vJjpxzaXdfKlboUx6+f brm4zUjUatKIon2EzKB3Cj8OAqNg8iAG/3y1i11knMwXZCiaOuXCzlTKh3s4DDDh z0uuei94aaKA28N2JuTEkEAXq+LT8phEpC3IJvVldqgwgxoNxwlCOqSdzwpAaglp Ayvdv5d1BryOCQdCaNFHuHZL4RimBWvCRRgwZtGNbqu6uRv9/2S0LES9CA+mDm9R YRuvTyOyi/3uzMJ6Nu9fq7vWJvaBB1VjGAg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeegiedgvdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeevjeeijedtjedttdevgeefhfehueelfedtheeghfduffeljefhfeehhfdt iedthfenucffohhmrghinheplhhinhgrrhhordhorhhgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomheprhgvsggvtggtrgessghsughiohdrtgho mh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 10 May 2023 08:09:11 -0400 (EDT) Message-ID: <9d398003-436a-0d99-66b5-17a84eb62e34@bsdio.com> Date: Wed, 10 May 2023 06:09:09 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [edk2-devel] [edk2-stable202305 PATCH 2/4] BaseTools: Set the CLANGDWARF OBJCOPY path in tools_def.template To: Ard Biesheuvel , devel@edk2.groups.io Cc: Liming Gao , Bob Feng , Yuwei Chen References: <20230509235337.1815842-1-rebecca@bsdio.com> <20230509235337.1815842-3-rebecca@bsdio.com> From: "Rebecca Cran" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/10/23 05:03, Ard Biesheuvel wrote: > On Wed, 10 May 2023 at 01:53, Rebecca Cran wrote: >> Set the OBJCOPY path for the CLANGDWARF toolchain to 'llvm-objcopy' to >> override the default of 'echo'. >> >> Signed-off-by: Rebecca Cran > This appears to break the AArch64 CLANGDWARF build. > > https://ci.linaro.org/job/leg-virt-tianocore-edk2-upstream/4880/console Ugh, I'm sorry. We're not overriding the OBJCOPY_FLAGS for ARM and AARCH64, so it uses the default of "not needed for" which previously got echoed. I'll work on a better local testing process to avoid such an obvious breakage in future. Would you like this commit reverted, or should I submit a patch to fix it? -- Rebecca Cran