From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1982C21A18AA9 for ; Mon, 29 May 2017 05:44:56 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B567C4E4C8; Mon, 29 May 2017 12:45:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B567C4E4C8 Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx09.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=lersek@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com B567C4E4C8 Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-94.phx2.redhat.com [10.3.116.94]) by smtp.corp.redhat.com (Postfix) with ESMTP id E8BD11810C; Mon, 29 May 2017 12:45:52 +0000 (UTC) To: "Kinney, Michael D" , edk2-devel-01 Cc: "Justen, Jordan L" References: <20170518150427.16435-1-lersek@redhat.com> <20170518150427.16435-8-lersek@redhat.com> From: Laszlo Ersek Message-ID: <9d5d8243-c14c-24f6-529d-7adbe13468b1@redhat.com> Date: Mon, 29 May 2017 14:45:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 29 May 2017 12:45:53 +0000 (UTC) Subject: Re: [PATCH 7/8] QuarkPlatformPkg/SpiFvbServices: correct NumOfLba vararg type in EraseBlocks() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2017 12:44:56 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 05/24/17 18:52, Kinney, Michael D wrote: > Reviewed-by: Michael D Kinney Commit b9036ebee9dd. Thanks! Laszlo >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek >> Sent: Thursday, May 18, 2017 8:04 AM >> To: edk2-devel-01 >> Cc: Kinney, Michael D ; Justen, Jordan L >> >> Subject: [edk2] [PATCH 7/8] QuarkPlatformPkg/SpiFvbServices: correct NumOfLba vararg >> type in EraseBlocks() >> >> According to the PI spec, Volume 3, >> EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.EraseBlocks(): >> >>> The variable argument list is a list of tuples. Each tuple describes a >>> range of LBAs to erase and consists of the following: >>> * An EFI_LBA that indicates the starting LBA >>> * A UINTN that indicates the number of blocks to erase >> >> (NB, in edk2, EFI_FIRMWARE_VOLUME_BLOCK_PROTOCOL is a typedef to >> EFI_FIRMWARE_VOLUME_BLOCK2_PROTOCOL.) >> >> In this driver, the NumOfLba local variable is defined with type UINTN, >> but the TYPE argument passed to VA_ARG() is UINT32. Fix the mismatch. >> >> Cc: Jordan Justen >> Cc: Kelly Steele >> Cc: Michael D Kinney >> Reported-by: Jordan Justen >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Laszlo Ersek >> --- >> >> Notes: >> unbuilt, untested >> >> QuarkPlatformPkg/Platform/SpiFvbServices/FwBlockService.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/QuarkPlatformPkg/Platform/SpiFvbServices/FwBlockService.c >> b/QuarkPlatformPkg/Platform/SpiFvbServices/FwBlockService.c >> index dbb5512f386e..0e7a7b79a1cf 100644 >> --- a/QuarkPlatformPkg/Platform/SpiFvbServices/FwBlockService.c >> +++ b/QuarkPlatformPkg/Platform/SpiFvbServices/FwBlockService.c >> @@ -1211,7 +1211,7 @@ Returns: >> break; >> } >> >> - NumOfLba = VA_ARG (args, UINT32); >> + NumOfLba = VA_ARG (args, UINTN); >> >> // >> // Check input parameters >> @@ -1235,7 +1235,7 @@ Returns: >> break; >> } >> >> - NumOfLba = VA_ARG (args, UINT32); >> + NumOfLba = VA_ARG (args, UINTN); >> >> while (NumOfLba > 0) { >> Status = FvbEraseBlock (FvbDevice->Instance, StartingLba, mFvbModuleGlobal, >> EfiGoneVirtual ()); >> -- >> 2.9.3 >> >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >