From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2736A7803D1 for ; Tue, 24 Oct 2023 12:32:58 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=XIOseJle+fRa+j6NNeqot+OciZS9XAvRPbmZ0qsiCfE=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698150777; v=1; b=nk8KEmH2znx9hHVAB7sVlgCcGIU5/fMBmG1xzPmhSgJcDU9mhRGLnF9XCiGHf4KOR2aVPPBE 2wKoH62djWLip1AYmNSDjRa5OLgPeGxMUW9W/CHFBgj50xrkPhw3ArLtFw3NaELScZvfTRVy+Rm HgG8FYdHdr8QoP2iExb6nmq0= X-Received: by 127.0.0.2 with SMTP id NebiYY7687511xBVZgHZAPIB; Tue, 24 Oct 2023 05:32:57 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.16781.1698150777196372154 for ; Tue, 24 Oct 2023 05:32:57 -0700 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-691-OWE5SpUDMuW_unYB-_j3pA-1; Tue, 24 Oct 2023 08:32:48 -0400 X-MC-Unique: OWE5SpUDMuW_unYB-_j3pA-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 457D73C0F439; Tue, 24 Oct 2023 12:32:48 +0000 (UTC) X-Received: from [10.39.195.39] (unknown [10.39.195.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C7DD91121318; Tue, 24 Oct 2023 12:32:46 +0000 (UTC) Message-ID: <9d8d67ce-db72-744b-c5c5-6c22f7bb8aed@redhat.com> Date: Tue, 24 Oct 2023 14:32:45 +0200 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v6 1/5] MdePkg: Move RISC-V Cache Management Declarations Into BaseLib To: devel@edk2.groups.io, dhaval@rivosinc.com Cc: Michael D Kinney , Liming Gao , Zhiguang Liu References: <20231021173314.19363-1-dhaval@rivosinc.com> <20231021173314.19363-2-dhaval@rivosinc.com> From: "Laszlo Ersek" In-Reply-To: <20231021173314.19363-2-dhaval@rivosinc.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 3xJ3JZ6ezpnUOBAcvvUq7g4fx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=nk8KEmH2; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/21/23 19:33, Dhaval Sharma wrote: > The declarations for cache Management functions belong to BaseLib > instead of instance source file. This helps with further restructuring > of cache management code for RISC-V. >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Laszlo Ersek >=20 > Signed-off-by: Dhaval Sharma > --- >=20 > Notes: > V5: > - Move cache management function declaration in baselib where it belo= ngs >=20 > MdePkg/Include/Library/BaseLib.h | 20 +++++++++++++++= +++++ > MdePkg/Library/BaseCacheMaintenanceLib/RiscVCache.c | 20 ---------------= ----- > 2 files changed, 20 insertions(+), 20 deletions(-) >=20 > diff --git a/MdePkg/Include/Library/BaseLib.h b/MdePkg/Include/Library/Ba= seLib.h > index 5d7067ee854e..7142bbfa42f2 100644 > --- a/MdePkg/Include/Library/BaseLib.h > +++ b/MdePkg/Include/Library/BaseLib.h > @@ -206,6 +206,26 @@ RiscVClearPendingTimerInterrupt ( > VOID > ); > =20 > +/** > + RISC-V invalidate instruction cache. > + > +**/ > +VOID > +EFIAPI > +RiscVInvalidateInstCacheAsm ( > + VOID > + ); > + > +/** > + RISC-V invalidate data cache. > + > +**/ > +VOID > +EFIAPI > +RiscVInvalidateDataCacheAsm ( > + VOID > + ); > + > #endif // defined (MDE_CPU_RISCV64) > =20 > #if defined (MDE_CPU_LOONGARCH64) > diff --git a/MdePkg/Library/BaseCacheMaintenanceLib/RiscVCache.c b/MdePkg= /Library/BaseCacheMaintenanceLib/RiscVCache.c > index d08fb9f193ca..d5efcf49a4bf 100644 > --- a/MdePkg/Library/BaseCacheMaintenanceLib/RiscVCache.c > +++ b/MdePkg/Library/BaseCacheMaintenanceLib/RiscVCache.c > @@ -10,26 +10,6 @@ > #include > #include > =20 > -/** > - RISC-V invalidate instruction cache. > - > -**/ > -VOID > -EFIAPI > -RiscVInvalidateInstCacheAsm ( > - VOID > - ); > - > -/** > - RISC-V invalidate data cache. > - > -**/ > -VOID > -EFIAPI > -RiscVInvalidateDataCacheAsm ( > - VOID > - ); > - > /** > Invalidates the entire instruction cache in cache coherency domain of = the > calling CPU. Reviewed-by: Laszlo Ersek -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110001): https://edk2.groups.io/g/devel/message/110001 Mute This Topic: https://groups.io/mt/102103776/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-