Re: [Patch 2/2] ShellPkg: Update Ifconfig command to accept 32bit subnet mask.

["Ni, Ruiyu" <ruiyu.ni@Intel.com>]

On 8/28/2018 10:55 PM, Carsey, Jaben wrote:
> looks good to me.  Ray?
> 
> Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> 
>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fu
>> Siyuan
>> Sent: Monday, August 27, 2018 6:53 PM
>> To: edk2-devel@lists.01.org
>> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Ye, Ting <ting.ye@intel.com>; Wu, Jiaxin
>> <jiaxin.wu@intel.com>
>> Subject: [edk2] [Patch 2/2] ShellPkg: Update Ifconfig command to accept
>> 32bit subnet mask.
>> Importance: High
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Fu Siyuan <siyuan.fu@intel.com>
>> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
>> Cc: Ye Ting <ting.ye@intel.com>
>> Cc: Wu Jiaxin <jiaxin.wu@intel.com>
>> ---
>>   ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c
>> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c
>> index 52415e0ad0..e9f644c739 100644
>> --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c
>> +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c
>> @@ -1032,6 +1032,7 @@ IfConfigSetInterfaceInfo (
>>         SubnetMask  = NTOHL (SubnetMask);
>>         TempGateway = NTOHL (TempGateway);
>>         if ((SubnetMask != 0) &&
>> +          (SubnetMask != 0xFFFFFFFFu) &&
>>             !NetIp4IsUnicast (TempGateway, SubnetMask)) {
>>           ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN
>> (STR_IFCONFIG_INVALID_GATEWAY), gShellNetwork1HiiHandle, VarArg-
>>> Arg);
>>           ShellStatus = SHELL_INVALID_PARAMETER;
>> --
>> 2.18.0.windows.1
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

-- 
Thanks,
Ray