From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 60F1321103996 for ; Tue, 28 Aug 2018 18:37:25 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Aug 2018 18:37:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,300,1531810800"; d="scan'208";a="84215271" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.8]) ([10.239.9.8]) by fmsmga004.fm.intel.com with ESMTP; 28 Aug 2018 18:37:10 -0700 To: "Carsey, Jaben" , "Fu, Siyuan" , "edk2-devel@lists.01.org" Cc: "Ye, Ting" , "Wu, Jiaxin" References: <20180828015235.60368-1-siyuan.fu@intel.com> <20180828015235.60368-3-siyuan.fu@intel.com> From: "Ni, Ruiyu" Message-ID: <9d9b5205-a257-b41b-17cc-6cdc5eda6c46@Intel.com> Date: Wed, 29 Aug 2018 09:37:57 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Subject: Re: [Patch 2/2] ShellPkg: Update Ifconfig command to accept 32bit subnet mask. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2018 01:37:25 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 8/28/2018 10:55 PM, Carsey, Jaben wrote: > looks good to me. Ray? > > Reviewed-by: Jaben Carsey > >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fu >> Siyuan >> Sent: Monday, August 27, 2018 6:53 PM >> To: edk2-devel@lists.01.org >> Cc: Ni, Ruiyu ; Ye, Ting ; Wu, Jiaxin >> >> Subject: [edk2] [Patch 2/2] ShellPkg: Update Ifconfig command to accept >> 32bit subnet mask. >> Importance: High >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Fu Siyuan >> Cc: Ruiyu Ni >> Cc: Ye Ting >> Cc: Wu Jiaxin >> --- >> ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c >> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c >> index 52415e0ad0..e9f644c739 100644 >> --- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c >> +++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/Ifconfig.c >> @@ -1032,6 +1032,7 @@ IfConfigSetInterfaceInfo ( >> SubnetMask = NTOHL (SubnetMask); >> TempGateway = NTOHL (TempGateway); >> if ((SubnetMask != 0) && >> + (SubnetMask != 0xFFFFFFFFu) && >> !NetIp4IsUnicast (TempGateway, SubnetMask)) { >> ShellPrintHiiEx (-1, -1, NULL, STRING_TOKEN >> (STR_IFCONFIG_INVALID_GATEWAY), gShellNetwork1HiiHandle, VarArg- >>> Arg); >> ShellStatus = SHELL_INVALID_PARAMETER; >> -- >> 2.18.0.windows.1 >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel Reviewed-by: Ruiyu Ni -- Thanks, Ray