From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 23018208D612F for ; Mon, 11 Feb 2019 02:55:33 -0800 (PST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B814D81F0C; Mon, 11 Feb 2019 10:55:32 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-124.rdu2.redhat.com [10.10.120.124]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0F1675C236; Mon, 11 Feb 2019 10:55:31 +0000 (UTC) To: Hao Wu , edk2-devel@lists.01.org References: <20190211075738.16676-1-hao.a.wu@intel.com> <20190211075738.16676-14-hao.a.wu@intel.com> From: Laszlo Ersek Message-ID: <9d9f3696-5db7-5e43-1614-e3fe7e0360b6@redhat.com> Date: Mon, 11 Feb 2019 11:55:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190211075738.16676-14-hao.a.wu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 11 Feb 2019 10:55:32 +0000 (UTC) Subject: Re: [PATCH v4 12/13] OvmfPkg/LockBoxLib: Update the comments for API UpdateLockBox() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Feb 2019 10:55:34 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 02/11/19 08:57, Hao Wu wrote: > The previous commit: > MdeModulePkg/SmmLockBoxLib: Support LockBox enlarge in UpdateLockBox() > > adds the support to enlarge a LockBox when using the LockBoxLib API > UpdateLockBox(). > > This commit is to sync the API description comment of UpdateLockBox() with > its counterparts in MdeModulePkg. > > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Hao Wu > --- > OvmfPkg/Library/LockBoxLib/LockBoxLib.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/OvmfPkg/Library/LockBoxLib/LockBoxLib.c b/OvmfPkg/Library/LockBoxLib/LockBoxLib.c > index 45481b9230..fe9ea1b0d5 100644 > --- a/OvmfPkg/Library/LockBoxLib/LockBoxLib.c > +++ b/OvmfPkg/Library/LockBoxLib/LockBoxLib.c > @@ -3,7 +3,7 @@ > Library implementing the LockBox interface for OVMF > > Copyright (C) 2013, Red Hat, Inc. > - Copyright (c) 2010 - 2014, Intel Corporation. All rights reserved.
> + Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.
> > This program and the accompanying materials are licensed and made available > under the terms and conditions of the BSD License which accompanies this > @@ -224,8 +224,13 @@ SetLockBoxAttributes ( > @retval RETURN_INVALID_PARAMETER the Guid is NULL, or Buffer is NULL, or > Length is 0. > @retval RETURN_NOT_FOUND the requested GUID not found. > - @retval RETURN_BUFFER_TOO_SMALL the original buffer to too small to hold > - new information. > + @retval RETURN_BUFFER_TOO_SMALL for lockbox with attribute > + LOCK_BOX_ATTRIBUTE_RESTORE_IN_PLACE, the > + original buffer to too small to hold new > + information. > + @retval RETURN_OUT_OF_RESOURCES for lockbox with attribute > + LOCK_BOX_ATTRIBUTE_RESTORE_IN_S3_ONLY, no > + enough resource to save the information. > @retval RETURN_ACCESS_DENIED it is too late to invoke this interface > @retval RETURN_NOT_STARTED it is too early to invoke this interface > @retval RETURN_UNSUPPORTED the service is not supported by > Reviewed-by: Laszlo Ersek Thanks! Laszlo