From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 992521A1DF1 for ; Mon, 26 Sep 2016 03:06:31 -0700 (PDT) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2D01480F7C; Mon, 26 Sep 2016 10:06:31 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-12.phx2.redhat.com [10.3.116.12]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8QA6Th6026400; Mon, 26 Sep 2016 06:06:30 -0400 To: Ruiyu Ni , edk2-devel@ml01.01.org References: <20160926093035.350612-1-ruiyu.ni@intel.com> <20160926093035.350612-20-ruiyu.ni@intel.com> Cc: Jordan Justen From: Laszlo Ersek Message-ID: <9db4ffeb-7436-1881-f42d-f689f099dd4a@redhat.com> Date: Mon, 26 Sep 2016 12:06:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20160926093035.350612-20-ruiyu.ni@intel.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 26 Sep 2016 10:06:31 +0000 (UTC) Subject: Re: [PATCH v2 19/19] OvmfPkg: Use the new LogoDxe driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Sep 2016 10:06:31 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 09/26/16 11:30, Ruiyu Ni wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Cc: Jordan Justen > Cc: Laszlo Ersek > Signed-off-by: Ruiyu Ni > --- > OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c | 8 +------- > OvmfPkg/OvmfPkgIa32.dsc | 3 +-- > OvmfPkg/OvmfPkgIa32.fdf | 4 +--- > OvmfPkg/OvmfPkgIa32X64.dsc | 3 +-- > OvmfPkg/OvmfPkgIa32X64.fdf | 4 +--- > OvmfPkg/OvmfPkgX64.dsc | 3 +-- > OvmfPkg/OvmfPkgX64.fdf | 4 +--- > 7 files changed, 7 insertions(+), 22 deletions(-) > > diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > index 4c5d259..74cb5a4 100644 > --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > @@ -1445,13 +1445,7 @@ Routine Description: > // > // Logo show > // > - //BootLogoEnableLogo ( > - // ImageFormatBmp, // ImageFormat > - // PcdGetPtr (PcdLogoFile), // Logo > - // EdkiiPlatformLogoDisplayAttributeCenter, // Attribute > - // 0, // OffsetX > - // 0 // OffsetY > - // ); > + BootLogoEnableLogo (); > > // > // Perform some platform specific connect sequence > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index d5bfa9f..7213197 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -79,7 +79,6 @@ [LibraryClasses] > SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf > - ImageDecoderLib|MdeModulePkg/Library/ImageDecoderLib/ImageDecoderLib.inf > FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > @@ -577,12 +576,12 @@ [Components] > MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.inf > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf { > > - NULL|MdeModulePkg/Library/BmpImageDecoderLib/BmpImageDecoderLib.inf > !ifdef $(CSM_ENABLE) > NULL|OvmfPkg/Csm/CsmSupportLib/CsmSupportLib.inf > NULL|IntelFrameworkModulePkg/Library/LegacyBootManagerLib/LegacyBootManagerLib.inf > !endif > } > + MdeModulePkg/Logo/LogoDxe.inf > MdeModulePkg/Application/UiApp/UiApp.inf { > > NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf > diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf > index c5e63a3..2a5b211 100644 > --- a/OvmfPkg/OvmfPkgIa32.fdf > +++ b/OvmfPkg/OvmfPkgIa32.fdf > @@ -287,9 +287,7 @@ [FV.DXEFV] > INF RuleOverride = BINARY EdkShellBinPkg/FullShell/FullShell.inf > !endif > > -FILE FREEFORM = PCD(gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdLogoFile) { > - SECTION RAW = MdeModulePkg/Logo/Logo.bmp > -} > +INF MdeModulePkg/Logo/LogoDxe.inf > > # > # Network modules > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index 2a9a86f..c27024a 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -84,7 +84,6 @@ [LibraryClasses] > SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf > - ImageDecoderLib|MdeModulePkg/Library/ImageDecoderLib/ImageDecoderLib.inf > FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > @@ -586,12 +585,12 @@ [Components.X64] > MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.inf > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf { > > - NULL|MdeModulePkg/Library/BmpImageDecoderLib/BmpImageDecoderLib.inf > !ifdef $(CSM_ENABLE) > NULL|OvmfPkg/Csm/CsmSupportLib/CsmSupportLib.inf > NULL|IntelFrameworkModulePkg/Library/LegacyBootManagerLib/LegacyBootManagerLib.inf > !endif > } > + MdeModulePkg/Logo/LogoDxe.inf > MdeModulePkg/Application/UiApp/UiApp.inf { > > NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf > diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf > index 11b623d..1c7df21 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.fdf > +++ b/OvmfPkg/OvmfPkgIa32X64.fdf > @@ -287,9 +287,7 @@ [FV.DXEFV] > INF RuleOverride = BINARY USE = X64 EdkShellBinPkg/FullShell/FullShell.inf > !endif > > -FILE FREEFORM = PCD(gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdLogoFile) { > - SECTION RAW = MdeModulePkg/Logo/Logo.bmp > -} > +INF MdeModulePkg/Logo/LogoDxe.inf > > # > # Network modules > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index 50c7af3..c34b266 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -84,7 +84,6 @@ [LibraryClasses] > SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf > - ImageDecoderLib|MdeModulePkg/Library/ImageDecoderLib/ImageDecoderLib.inf > FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > @@ -584,12 +583,12 @@ [Components] > MdeModulePkg/Universal/DriverHealthManagerDxe/DriverHealthManagerDxe.inf > MdeModulePkg/Universal/BdsDxe/BdsDxe.inf { > > - NULL|MdeModulePkg/Library/BmpImageDecoderLib/BmpImageDecoderLib.inf > !ifdef $(CSM_ENABLE) > NULL|OvmfPkg/Csm/CsmSupportLib/CsmSupportLib.inf > NULL|IntelFrameworkModulePkg/Library/LegacyBootManagerLib/LegacyBootManagerLib.inf > !endif > } > + MdeModulePkg/Logo/LogoDxe.inf > MdeModulePkg/Application/UiApp/UiApp.inf { > > NULL|MdeModulePkg/Library/DeviceManagerUiLib/DeviceManagerUiLib.inf > diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf > index 784aea1..3bb11cb 100644 > --- a/OvmfPkg/OvmfPkgX64.fdf > +++ b/OvmfPkg/OvmfPkgX64.fdf > @@ -287,9 +287,7 @@ [FV.DXEFV] > INF RuleOverride = BINARY EdkShellBinPkg/FullShell/FullShell.inf > !endif > > -FILE FREEFORM = PCD(gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdLogoFile) { > - SECTION RAW = MdeModulePkg/Logo/Logo.bmp > -} > +INF MdeModulePkg/Logo/LogoDxe.inf > > # > # Network modules > Reviewed-by: Laszlo Ersek