Re: [PATCH 1/1] ArmPkg: add DebugLib to OemMiscLibNull

["Rebecca Cran" <rebecca@nuviainc.com>]

On 2/8/21 4:48 PM, Leif Lindholm wrote:
> The just added OemMiscLibNull fails to build due to DebugLib.h not
> being included, missing the ASSERT definition. Add the include and the
> library dependency.
> 
> Cc: Rebecca Cran <rebecca@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Signed-off-by: Leif Lindholm <leif@nuviainc.com>
> ---
>   ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf | 2 +-
>   ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c       | 1 +
>   2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf
> index b21eeade64b5..5c4268f68b4a 100644
> --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf
> +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf
> @@ -28,4 +28,4 @@ [Packages]
>   
>   [LibraryClasses]
>     BaseMemoryLib
> -
> +  DebugLib
> diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
> index 767fc08d166b..73cebef2d1b9 100644
> --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
> +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
> @@ -11,6 +11,7 @@
>   
>   #include <Uefi.h>
>   #include <Library/BaseMemoryLib.h>
> +#include <Library/DebugLib.h>
>   #include <Library/HiiLib.h>
>   
>   #include <Library/OemMiscLib.h>
> 

Reviewed-by: Rebecca Cran <rebecca@nuviainc.com>

-- 
Rebecca Cran