From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) by mx.groups.io with SMTP id smtpd.web09.3407.1612829812625600482 for ; Mon, 08 Feb 2021 16:16:52 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=wlagl5vg; spf=pass (domain: nuviainc.com, ip: 209.85.219.46, mailfrom: rebecca@nuviainc.com) Received: by mail-qv1-f46.google.com with SMTP id f18so1768147qvm.9 for ; Mon, 08 Feb 2021 16:16:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8cmntIyh8PkXPQ2Hhq3giIM45X9YnpK1TYzRH/rS4oo=; b=wlagl5vgw8VbS25PEnXwKTeEh32cQCXoVj6kmPQftff6ZRb/qyC7fjDFsS2BS+hTk7 39/Wsk233gGK3H91gCmb3GAKdDSE3LVrtkt9jIzNQfzavV3fG3RrtfQtWmqkrnOnM0S3 ji4p+QGu3rsAQswd+1MenIVZixPAR5ChSpx4cJqdFN+4hb2SZymkTwd2K3trXKy0/W4+ YuLyrIeijnZ9e9cdD+5RnvBXXnem6MQGYLlGsznrx/k4X9pizOes+9xykCx5uz73Skkd nuH9eu3uKbJXr0lwWh2x0avyjox4IpurAMroLgiyla3obAdiWkvpJfKA6nkumDCJQ4Pg 1P/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8cmntIyh8PkXPQ2Hhq3giIM45X9YnpK1TYzRH/rS4oo=; b=pUgQVxBLhnRcC2+h3CeFLnyFXMAkBrZc+wm85Flkdec+7BLNFCF+fr1bcI2TWZypw8 DM0bHCA7f3LTa69jgMr20bI2mGjRcP8szPLhM7RgOeGZM0jdRIYMoSbCY2hjmQhWGPf1 z6J05WL3jMl/utUVf1xf4iBaT/lx2gTiofs+2CKr9usfLu3WEXx8ivBZFq2Wivi7UAZt mDanAZbfvCMbS3XQ2HkMO/j2tlKFW5NrNtwM4Q+GlXhsP7PFlN+ThL9m+ZjCQ+JWisIE rlWtYa6414y5uwD//rKVr8e39k+pBBiHDBcudCJhx060NuNUL40p9d77dHPUVbv7RQEk DLBQ== X-Gm-Message-State: AOAM531aAKfexmsn+Khr+tM2+Qz40t5NtwL3Xob1PYD+UgudWotXfiOA S01UDxK0wgIOAofPIaQc/u3r5Q== X-Google-Smtp-Source: ABdhPJzUXe1cSm+4QCRxKdBNyDzT+sE56LKBM9yB98dxe7y4ERAPthcknRF2SbHiieWQixt6z+GhBA== X-Received: by 2002:ad4:54ad:: with SMTP id r13mr5275128qvy.48.1612829811876; Mon, 08 Feb 2021 16:16:51 -0800 (PST) Return-Path: Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id x49sm16939851qth.95.2021.02.08.16.16.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Feb 2021 16:16:51 -0800 (PST) Subject: Re: [PATCH 1/1] ArmPkg: add DebugLib to OemMiscLibNull To: Leif Lindholm , devel@edk2.groups.io Cc: Ard Biesheuvel References: <20210208234849.13327-1-leif@nuviainc.com> From: "Rebecca Cran" Message-ID: <9db7f7b8-1d2d-cfe9-3455-0bc3ba7f79a3@nuviainc.com> Date: Mon, 8 Feb 2021 17:16:49 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210208234849.13327-1-leif@nuviainc.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 2/8/21 4:48 PM, Leif Lindholm wrote: > The just added OemMiscLibNull fails to build due to DebugLib.h not > being included, missing the ASSERT definition. Add the include and the > library dependency. > > Cc: Rebecca Cran > Cc: Ard Biesheuvel > Signed-off-by: Leif Lindholm > --- > ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf | 2 +- > ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf > index b21eeade64b5..5c4268f68b4a 100644 > --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf > +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf > @@ -28,4 +28,4 @@ [Packages] > > [LibraryClasses] > BaseMemoryLib > - > + DebugLib > diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c > index 767fc08d166b..73cebef2d1b9 100644 > --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c > +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c > @@ -11,6 +11,7 @@ > > #include > #include > +#include > #include > > #include > Reviewed-by: Rebecca Cran -- Rebecca Cran