* [PATCH 1/1] ArmPkg: add DebugLib to OemMiscLibNull
@ 2021-02-08 23:48 Leif Lindholm
2021-02-09 0:16 ` Rebecca Cran
2021-02-09 13:00 ` Ard Biesheuvel
0 siblings, 2 replies; 3+ messages in thread
From: Leif Lindholm @ 2021-02-08 23:48 UTC (permalink / raw)
To: devel; +Cc: Rebecca Cran, Ard Biesheuvel
The just added OemMiscLibNull fails to build due to DebugLib.h not
being included, missing the ASSERT definition. Add the include and the
library dependency.
Cc: Rebecca Cran <rebecca@nuviainc.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Signed-off-by: Leif Lindholm <leif@nuviainc.com>
---
ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf | 2 +-
ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf
index b21eeade64b5..5c4268f68b4a 100644
--- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf
+++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf
@@ -28,4 +28,4 @@ [Packages]
[LibraryClasses]
BaseMemoryLib
-
+ DebugLib
diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
index 767fc08d166b..73cebef2d1b9 100644
--- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
+++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
@@ -11,6 +11,7 @@
#include <Uefi.h>
#include <Library/BaseMemoryLib.h>
+#include <Library/DebugLib.h>
#include <Library/HiiLib.h>
#include <Library/OemMiscLib.h>
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] ArmPkg: add DebugLib to OemMiscLibNull
2021-02-08 23:48 [PATCH 1/1] ArmPkg: add DebugLib to OemMiscLibNull Leif Lindholm
@ 2021-02-09 0:16 ` Rebecca Cran
2021-02-09 13:00 ` Ard Biesheuvel
1 sibling, 0 replies; 3+ messages in thread
From: Rebecca Cran @ 2021-02-09 0:16 UTC (permalink / raw)
To: Leif Lindholm, devel; +Cc: Ard Biesheuvel
On 2/8/21 4:48 PM, Leif Lindholm wrote:
> The just added OemMiscLibNull fails to build due to DebugLib.h not
> being included, missing the ASSERT definition. Add the include and the
> library dependency.
>
> Cc: Rebecca Cran <rebecca@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Signed-off-by: Leif Lindholm <leif@nuviainc.com>
> ---
> ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf | 2 +-
> ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf
> index b21eeade64b5..5c4268f68b4a 100644
> --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf
> +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf
> @@ -28,4 +28,4 @@ [Packages]
>
> [LibraryClasses]
> BaseMemoryLib
> -
> + DebugLib
> diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
> index 767fc08d166b..73cebef2d1b9 100644
> --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
> +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
> @@ -11,6 +11,7 @@
>
> #include <Uefi.h>
> #include <Library/BaseMemoryLib.h>
> +#include <Library/DebugLib.h>
> #include <Library/HiiLib.h>
>
> #include <Library/OemMiscLib.h>
>
Reviewed-by: Rebecca Cran <rebecca@nuviainc.com>
--
Rebecca Cran
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] ArmPkg: add DebugLib to OemMiscLibNull
2021-02-08 23:48 [PATCH 1/1] ArmPkg: add DebugLib to OemMiscLibNull Leif Lindholm
2021-02-09 0:16 ` Rebecca Cran
@ 2021-02-09 13:00 ` Ard Biesheuvel
1 sibling, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2021-02-09 13:00 UTC (permalink / raw)
To: Leif Lindholm; +Cc: devel, Rebecca Cran, Ard Biesheuvel
On Tue, 9 Feb 2021 at 00:48, Leif Lindholm <leif@nuviainc.com> wrote:
>
> The just added OemMiscLibNull fails to build due to DebugLib.h not
> being included, missing the ASSERT definition. Add the include and the
> library dependency.
>
> Cc: Rebecca Cran <rebecca@nuviainc.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Signed-off-by: Leif Lindholm <leif@nuviainc.com>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf | 2 +-
> ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf
> index b21eeade64b5..5c4268f68b4a 100644
> --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf
> +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf
> @@ -28,4 +28,4 @@ [Packages]
>
> [LibraryClasses]
> BaseMemoryLib
> -
> + DebugLib
> diff --git a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
> index 767fc08d166b..73cebef2d1b9 100644
> --- a/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
> +++ b/ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c
> @@ -11,6 +11,7 @@
>
> #include <Uefi.h>
> #include <Library/BaseMemoryLib.h>
> +#include <Library/DebugLib.h>
> #include <Library/HiiLib.h>
>
> #include <Library/OemMiscLib.h>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-09 13:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-08 23:48 [PATCH 1/1] ArmPkg: add DebugLib to OemMiscLibNull Leif Lindholm
2021-02-09 0:16 ` Rebecca Cran
2021-02-09 13:00 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox