From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.85.128.66; helo=mail-wm1-f66.google.com; envelope-from=philmd@redhat.com; receiver=edk2-devel@lists.01.org Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 70BB72119620A for ; Wed, 28 Nov 2018 07:01:57 -0800 (PST) Received: by mail-wm1-f66.google.com with SMTP id r11-v6so2940907wmb.2 for ; Wed, 28 Nov 2018 07:01:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=I6jYtZ+k0z6O/YS8GeaYT6wN2faDwjfYu3v0pvEfCrA=; b=aFL8fh67IQt1xBmmq59PGBIOiFIns1QLEUG/7vjV77N5H6sCHeHUXJJEmomCGX4raE 7cZfUJHWoZ/o3V0CatJCsvA/TDs+eK+Arw15fH3nxpL6+KmcytyGico64xN2PMkxV+po 2haWfkezPepoJpJ/U2RLWYIZ8Y7GryfoBO3D3Nn/etasI2HF31C/Jvi9vXz59InpAAXC A1rQ7wR6UuzCr4kHzVMiFpP9m5nYUyVrVuuCGXjGS/21uvbL9nwn5C02/NuZ5KOja/sN xQXzf//Oz8XX31xcPQnh+lNM6Xn2Iz0mOiRdYOQKbfPWs0vX/utFYSRrw9Lw9iyT8kDc dBXA== X-Gm-Message-State: AA+aEWaHdKQgnk9rF/f27Om2qdUZcgY83dI6pPRYG61h4qAZMEJhte2M JfRynorjZ8v9memrfzA7ATOc0w== X-Google-Smtp-Source: AFSGD/U0vi8HqYclq60rysKPYSdtYbsDb2B+Lsa4O85/VF1v+b0owo8DG1mmjwNXBfc1bLp7pdIrJA== X-Received: by 2002:a1c:1a43:: with SMTP id a64mr2954666wma.136.1543417315884; Wed, 28 Nov 2018 07:01:55 -0800 (PST) Received: from ?IPv6:2a01:cb1d:8a0a:f500:48c1:8eab:256a:caf9? ([2a01:cb1d:8a0a:f500:48c1:8eab:256a:caf9]) by smtp.gmail.com with ESMTPSA id w9sm3363897wme.47.2018.11.28.07.01.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Nov 2018 07:01:55 -0800 (PST) To: Ard Biesheuvel , edk2-devel@lists.01.org Cc: Laszlo Ersek , Leif Lindholm , Eric Auger , Andrew Jones , Julien Grall References: <20181128143357.991-1-ard.biesheuvel@linaro.org> <20181128143357.991-11-ard.biesheuvel@linaro.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <9dcb7eb3-30cb-291d-9c0c-d37af9a1cc66@redhat.com> Date: Wed, 28 Nov 2018 16:01:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <20181128143357.991-11-ard.biesheuvel@linaro.org> Subject: Re: [PATCH v3 10/16] ArmPlatformPkg/PrePi: base GCD memory space size on CPU's PA range X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Nov 2018 15:01:58 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 28/11/18 15:33, Ard Biesheuvel wrote: > Derive the size of the GCD memory space map directly from the CPU's > information registers rather than from the PcdPrePiCpuMemorySize PCD, > which will be removed. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel Reviewed-by: Philippe Mathieu-Daudé > --- > ArmPlatformPkg/PrePi/PeiMPCore.inf | 1 - > ArmPlatformPkg/PrePi/PeiUniCore.inf | 1 - > ArmPlatformPkg/PrePi/PrePi.c | 2 +- > 3 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/ArmPlatformPkg/PrePi/PeiMPCore.inf b/ArmPlatformPkg/PrePi/PeiMPCore.inf > index 242b03175536..7e2ad6fc483d 100644 > --- a/ArmPlatformPkg/PrePi/PeiMPCore.inf > +++ b/ArmPlatformPkg/PrePi/PeiMPCore.inf > @@ -97,7 +97,6 @@ [FixedPcd] > > gArmPlatformTokenSpaceGuid.PcdCoreCount > > - gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize > gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize > > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory > diff --git a/ArmPlatformPkg/PrePi/PeiUniCore.inf b/ArmPlatformPkg/PrePi/PeiUniCore.inf > index a45cdef4ed91..26328b7e8f67 100644 > --- a/ArmPlatformPkg/PrePi/PeiUniCore.inf > +++ b/ArmPlatformPkg/PrePi/PeiUniCore.inf > @@ -90,7 +90,6 @@ [FixedPcd] > > gArmPlatformTokenSpaceGuid.PcdCoreCount > > - gEmbeddedTokenSpaceGuid.PcdPrePiCpuMemorySize > gEmbeddedTokenSpaceGuid.PcdPrePiCpuIoSize > > gEmbeddedTokenSpaceGuid.PcdMemoryTypeEfiACPIReclaimMemory > diff --git a/ArmPlatformPkg/PrePi/PrePi.c b/ArmPlatformPkg/PrePi/PrePi.c > index 02cff7ddc204..245bdded1eb3 100644 > --- a/ArmPlatformPkg/PrePi/PrePi.c > +++ b/ArmPlatformPkg/PrePi/PrePi.c > @@ -115,7 +115,7 @@ PrePiMain ( > BuildStackHob (StacksBase, StacksSize); > > //TODO: Call CpuPei as a library > - BuildCpuHob (PcdGet8 (PcdPrePiCpuMemorySize), PcdGet8 (PcdPrePiCpuIoSize)); > + BuildCpuHob (ArmGetPhysicalAddressBits (), PcdGet8 (PcdPrePiCpuIoSize)); > > if (ArmIsMpCore ()) { > // Only MP Core platform need to produce gArmMpCoreInfoPpiGuid >