public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: devel@edk2.groups.io, bret@corthon.com
Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Update the NASM dependency
Date: Mon, 15 Feb 2021 21:59:52 +0100	[thread overview]
Message-ID: <9dd900ea-5b9f-aa54-04b9-cddf4a0f3ede@redhat.com> (raw)
In-Reply-To: <20210212204926.1114-1-bret.barkelew@microsoft.com>

Hi Bret,

On 02/12/21 21:49, Bret Barkelew wrote:
> This is primarily used by CI builds, but may also be used by platforms.
> 
> Update NASM to support newer structures and features, as agreed in recent
> community meetings:
> https://edk2.groups.io/g/devel/message/71289
> ---
>  BaseTools/Bin/nasm_ext_dep.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Bin/nasm_ext_dep.yaml b/BaseTools/Bin/nasm_ext_dep.yaml
> index 60b1f71b56aa..56703d4c18e7 100644
> --- a/BaseTools/Bin/nasm_ext_dep.yaml
> +++ b/BaseTools/Bin/nasm_ext_dep.yaml
> @@ -13,6 +13,6 @@
>    "type": "nuget",
>    "name": "mu_nasm",
>    "source": "https://api.nuget.org/v3/index.json",
> -  "version": "2.14.02",
> +  "version": "2.15.5",
>    "flags": ["set_path", "host_specific"]
>  }
> 

(1) I'm confused by the "patchlevel" number being "5" and not "05", in
the "2.15.5" version. Per
<https://edk2.groups.io/g/devel/message/71045>, my understanding has
been that the latest release is "2.15.05".

(2) The minimum required version, according to
<https://edk2.groups.io/g/devel/message/71070>, is "2.15.01". In the
RHEL build environments that matter to me, I can satisfy a NASM
dependency up to 2.15.03, at this time, but not beyond. And this matters
because...

(3) ... arguably, the NASM requirement in
"BaseTools/Conf/tools_def.template" should be updated too, in the same
patch:

#   - NASM 2.10 or later for use with the GCC toolchain family
#   - NASM 2.12.01 or later for use with all other toolchain families

Thanks
Laszlo


  reply	other threads:[~2021-02-15 20:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-12 20:49 [PATCH v1 1/1] BaseTools: Update the NASM dependency Bret Barkelew
2021-02-15 20:59 ` Laszlo Ersek [this message]
2021-02-18  3:39   ` 回复: [edk2-devel] " gaoliming
2021-02-18  4:07     ` Bret Barkelew
2021-02-19 14:30       ` Laszlo Ersek
2021-02-19 17:10         ` Bret Barkelew
2021-02-20  5:16           ` 回复: " gaoliming
2021-02-22 10:19             ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9dd900ea-5b9f-aa54-04b9-cddf4a0f3ede@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox