From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web10.134.1613422799572767810 for ; Mon, 15 Feb 2021 12:59:59 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MW6tXlbI; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613422798; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TKFHlir2W+kPTRaFYmCEvTDUe2PPR+Vgag+eNxQLqMk=; b=MW6tXlbIGDWtMfI9lvFx1zGlkpw+C+0Fe5uDPFSGg/xxb0UwYdtExS6IxseRHcmrmCaoGo KHzodNu1dwvsmnrFilNLWmF2efVARNMRNySWlWd3jItbWYIsdUrKfjeX0P+TLbqWQTC8Ug M+TnFQf/kTiu9cTNlRFXqhhjqYbG+kI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-386-5bSQriksOg62bkGQDK1n-Q-1; Mon, 15 Feb 2021 15:59:55 -0500 X-MC-Unique: 5bSQriksOg62bkGQDK1n-Q-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0DBBE85B663; Mon, 15 Feb 2021 20:59:54 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-65.ams2.redhat.com [10.36.112.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5FC17101E679; Mon, 15 Feb 2021 20:59:53 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Update the NASM dependency To: devel@edk2.groups.io, bret@corthon.com References: <20210212204926.1114-1-bret.barkelew@microsoft.com> From: "Laszlo Ersek" Message-ID: <9dd900ea-5b9f-aa54-04b9-cddf4a0f3ede@redhat.com> Date: Mon, 15 Feb 2021 21:59:52 +0100 MIME-Version: 1.0 In-Reply-To: <20210212204926.1114-1-bret.barkelew@microsoft.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Bret, On 02/12/21 21:49, Bret Barkelew wrote: > This is primarily used by CI builds, but may also be used by platforms. > > Update NASM to support newer structures and features, as agreed in recent > community meetings: > https://edk2.groups.io/g/devel/message/71289 > --- > BaseTools/Bin/nasm_ext_dep.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Bin/nasm_ext_dep.yaml b/BaseTools/Bin/nasm_ext_dep.yaml > index 60b1f71b56aa..56703d4c18e7 100644 > --- a/BaseTools/Bin/nasm_ext_dep.yaml > +++ b/BaseTools/Bin/nasm_ext_dep.yaml > @@ -13,6 +13,6 @@ > "type": "nuget", > "name": "mu_nasm", > "source": "https://api.nuget.org/v3/index.json", > - "version": "2.14.02", > + "version": "2.15.5", > "flags": ["set_path", "host_specific"] > } > (1) I'm confused by the "patchlevel" number being "5" and not "05", in the "2.15.5" version. Per , my understanding has been that the latest release is "2.15.05". (2) The minimum required version, according to , is "2.15.01". In the RHEL build environments that matter to me, I can satisfy a NASM dependency up to 2.15.03, at this time, but not beyond. And this matters because... (3) ... arguably, the NASM requirement in "BaseTools/Conf/tools_def.template" should be updated too, in the same patch: # - NASM 2.10 or later for use with the GCC toolchain family # - NASM 2.12.01 or later for use with all other toolchain families Thanks Laszlo