public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Peter Grehan" <grehan@freebsd.org>
To: "Corvin Köhne" <c.koehne@beckhoff.com>, devel@edk2.groups.io
Cc: p.bruenn@beckhoff.com, rebecca@bsdio.com, lersek@redhat.com,
	ardb+tianocore@kernel.org, jordan.l.justen@intel.com
Subject: Re: [PATCH v3 1/2] OvmfPkg/Bhyve: add USB support
Date: Fri, 2 Jul 2021 09:45:47 +1000	[thread overview]
Message-ID: <9e0cefed-c239-566e-19c5-86ce5cd8a29b@freebsd.org> (raw)
In-Reply-To: <20210701120152.27482-1-c.koehne@beckhoff.com>

Reviewed-by: Peter Grehan <grehan@freebsd.org>

> An USB driver is required to use a keyboard or mouse while installing
> an OS or while in a bootloader menu like grub when using GPU + USB
> Passthrough.
> ---
>   OvmfPkg/Bhyve/BhyveX64.dsc | 9 +++++++++
>   OvmfPkg/Bhyve/BhyveX64.fdf | 8 ++++++++
>   2 files changed, 17 insertions(+)
> 
> diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc
> index 39cd354932..a0a2071b86 100644
> --- a/OvmfPkg/Bhyve/BhyveX64.dsc
> +++ b/OvmfPkg/Bhyve/BhyveX64.dsc
> @@ -163,6 +163,7 @@
>     FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf
>     UefiCpuLib|UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf
>     SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib/DxeSecurityManagementLib.inf
> +  UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf
>     SerializeVariablesLib|OvmfPkg/Library/SerializeVariablesLib/SerializeVariablesLib.inf
>     QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibNull.inf
>     QemuFwCfgS3Lib|OvmfPkg/Library/QemuFwCfgS3Lib/BaseQemuFwCfgS3LibNull.inf
> @@ -778,6 +779,14 @@
>   !endif
>     OvmfPkg/VirtioNetDxe/VirtioNet.inf
>   
> +  #
> +  # Usb Support
> +  #
> +  MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf
> +  MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf
> +  MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf
> +  MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf
> +
>   !ifdef $(CSM_ENABLE)
>     IntelFrameworkModulePkg/Csm/BiosThunk/VideoDxe/VideoDxe.inf {
>       <LibraryClasses>
> diff --git a/OvmfPkg/Bhyve/BhyveX64.fdf b/OvmfPkg/Bhyve/BhyveX64.fdf
> index f4050c4934..f9e9a4cc3e 100644
> --- a/OvmfPkg/Bhyve/BhyveX64.fdf
> +++ b/OvmfPkg/Bhyve/BhyveX64.fdf
> @@ -292,6 +292,14 @@ INF MdeModulePkg/Logo/LogoDxe.inf
>   !include NetworkPkg/Network.fdf.inc
>     INF  OvmfPkg/VirtioNetDxe/VirtioNet.inf
>   
> +#
> +# Usb Support
> +#
> +INF  MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf
> +INF  MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf
> +INF  MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf
> +INF  MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf
> +
>   !ifdef $(CSM_ENABLE)
>   INF  IntelFrameworkModulePkg/Csm/BiosThunk/VideoDxe/VideoDxe.inf
>   !endif
> 


      parent reply	other threads:[~2021-07-01 23:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-01 12:01 [PATCH v3 1/2] OvmfPkg/Bhyve: add USB support Corvin Köhne
2021-07-01 12:01 ` [PATCH v3 2/2] OvmfPkg/Bhyve: use static PCI32Base address Corvin Köhne
2021-07-01 23:46   ` Peter Grehan
2021-07-02 15:18   ` [edk2-devel] " Laszlo Ersek
2021-07-02 17:05   ` Rebecca Cran
2021-07-01 23:45 ` Peter Grehan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e0cefed-c239-566e-19c5-86ce5cd8a29b@freebsd.org \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox