From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from alto.onthenet.com.au (alto.onthenet.com.au [203.13.68.39])
 by mx.groups.io with SMTP id smtpd.web08.2840.1625183151727231324
 for <devel@edk2.groups.io>;
 Thu, 01 Jul 2021 16:45:52 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: iredmail.onthenet.com.au, ip: 203.13.68.39, mailfrom: srs0=fxgo=lz=freebsd.org=grehan@iredmail.onthenet.com.au)
Received: from iredmail.onthenet.com.au (iredmail.onthenet.com.au [203.13.68.150])
	by alto.onthenet.com.au (Postfix) with ESMTPS id D5CFD2094A4B
	for <devel@edk2.groups.io>; Fri,  2 Jul 2021 09:45:48 +1000 (AEST)
Received: from iredmail.onthenet.com.au (iredmail.onthenet.com.au [127.0.0.1])
	by iredmail.onthenet.com.au (Postfix) with ESMTP id C4EDF211FAD6
	for <devel@edk2.groups.io>; Fri,  2 Jul 2021 09:45:48 +1000 (AEST)
Received: from iredmail.onthenet.com.au ([127.0.0.1])
	by iredmail.onthenet.com.au (iredmail.onthenet.com.au [127.0.0.1]) (amavisd-new, port 10026)
	with ESMTP id myWP1-a8y6JM for <devel@edk2.groups.io>;
	Fri,  2 Jul 2021 09:45:48 +1000 (AEST)
Received: from MacBook-Air-4.local (unknown [120.29.51.224])
	by iredmail.onthenet.com.au (Postfix) with ESMTPSA id 2B0EB211FAD3;
	Fri,  2 Jul 2021 09:45:48 +1000 (AEST)
Subject: Re: [PATCH v3 1/2] OvmfPkg/Bhyve: add USB support
To: =?UTF-8?Q?Corvin_K=c3=b6hne?= <c.koehne@beckhoff.com>,
 devel@edk2.groups.io
Cc: p.bruenn@beckhoff.com, rebecca@bsdio.com, lersek@redhat.com,
 ardb+tianocore@kernel.org, jordan.l.justen@intel.com
References: <20210701120152.27482-1-c.koehne@beckhoff.com>
From: "Peter Grehan" <grehan@freebsd.org>
Message-ID: <9e0cefed-c239-566e-19c5-86ce5cd8a29b@freebsd.org>
Date: Fri, 2 Jul 2021 09:45:47 +1000
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0)
 Gecko/20100101 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <20210701120152.27482-1-c.koehne@beckhoff.com>
X-CMAE-Score: 0
X-CMAE-Analysis: v=2.3 cv=Q6BJH7+a c=1 sm=1 tr=0
	a=A6CF0fG5TOl4vs6YHvqXgw==:117 a=y5XNLLSx+aZC9npArTYviw==:17
	a=IkcTkHD0fZMA:10 a=e_q4qTt1xDgA:10 a=6I5d2MoRAAAA:8
	a=rBn9ejBjjjcpk_gyGFEA:9 a=QEXdDO2ut3YA:10 a=IjZwj45LgO3ly-622nXo:22
	wl=host:3
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Peter Grehan <grehan@freebsd.org>

> =EF=BB=BFAn USB driver is required to use a keyboard or mouse while ins=
talling
> an OS or while in a bootloader menu like grub when using GPU + USB
> Passthrough.
> ---
>   OvmfPkg/Bhyve/BhyveX64.dsc | 9 +++++++++
>   OvmfPkg/Bhyve/BhyveX64.fdf | 8 ++++++++
>   2 files changed, 17 insertions(+)
>=20
> diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc
> index 39cd354932..a0a2071b86 100644
> --- a/OvmfPkg/Bhyve/BhyveX64.dsc
> +++ b/OvmfPkg/Bhyve/BhyveX64.dsc
> @@ -163,6 +163,7 @@
>     FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.in=
f
>     UefiCpuLib|UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLib.inf
>     SecurityManagementLib|MdeModulePkg/Library/DxeSecurityManagementLib=
/DxeSecurityManagementLib.inf
> +  UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf
>     SerializeVariablesLib|OvmfPkg/Library/SerializeVariablesLib/Seriali=
zeVariablesLib.inf
>     QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLibNull.inf
>     QemuFwCfgS3Lib|OvmfPkg/Library/QemuFwCfgS3Lib/BaseQemuFwCfgS3LibNul=
l.inf
> @@ -778,6 +779,14 @@
>   !endif
>     OvmfPkg/VirtioNetDxe/VirtioNet.inf
>  =20
> +  #
> +  # Usb Support
> +  #
> +  MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf
> +  MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf
> +  MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf
> +  MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf
> +
>   !ifdef $(CSM_ENABLE)
>     IntelFrameworkModulePkg/Csm/BiosThunk/VideoDxe/VideoDxe.inf {
>       <LibraryClasses>
> diff --git a/OvmfPkg/Bhyve/BhyveX64.fdf b/OvmfPkg/Bhyve/BhyveX64.fdf
> index f4050c4934..f9e9a4cc3e 100644
> --- a/OvmfPkg/Bhyve/BhyveX64.fdf
> +++ b/OvmfPkg/Bhyve/BhyveX64.fdf
> @@ -292,6 +292,14 @@ INF MdeModulePkg/Logo/LogoDxe.inf
>   !include NetworkPkg/Network.fdf.inc
>     INF  OvmfPkg/VirtioNetDxe/VirtioNet.inf
>  =20
> +#
> +# Usb Support
> +#
> +INF  MdeModulePkg/Bus/Pci/XhciDxe/XhciDxe.inf
> +INF  MdeModulePkg/Bus/Usb/UsbBusDxe/UsbBusDxe.inf
> +INF  MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf
> +INF  MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf
> +
>   !ifdef $(CSM_ENABLE)
>   INF  IntelFrameworkModulePkg/Csm/BiosThunk/VideoDxe/VideoDxe.inf
>   !endif
>=20