From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::641; helo=mail-pl1-x641.google.com; envelope-from=ming.huang@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 79C972194EB76 for ; Tue, 12 Feb 2019 18:21:36 -0800 (PST) Received: by mail-pl1-x641.google.com with SMTP id o6so393446pls.13 for ; Tue, 12 Feb 2019 18:21:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=iYJnwoEF0/GY5gd9Azqblx4FZM46UreStfazs0X5hNs=; b=cnIc0nAprv15gYj1+8fxmXtcqeLG/RMLXG6/0ddWB9ivTBFtqQtn8SQrv1QervMU8z 0fTrdnJGk7QEvHwk4VTgQ2vhWzAJSbE6GBH2mbyKFrfG0VlzEIZ9X/rwxMR6b6KpGOeD eUgz7S3xms1g8DXZYL15OpSsTtw9cw1ZJVYM+c4A8YRQxUjLmc0lIXc8fnv91hq3xxxQ zEz6wILfqkhfSOBGSuA4g8bXQyDhfZA4MN3zDuTtGIkns7aO5n9fG5OG4gKcwXk9SYDk tZWkAWabHfCiMa90zWILM9xr8TIu70gQ2pPe+bivCWakJXddLV6NrUOZYIQ+db3uLoDY 3GPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iYJnwoEF0/GY5gd9Azqblx4FZM46UreStfazs0X5hNs=; b=hMdBlvuU1F3Mizir8zC/2mzR/WgRPmxMHDJjqBfihMCd1a1U9Q0eNTnFkimXjYmGIN 5BBvO4Atb5SnfGSPJa+TZvoBxUh8V9NT4XOtaQdBb9tZH4rJ53Eaj/WWlxXhWqtMyUlG JKgH2IXBKYdCF81Dn1M8eQm/qNTkGCjgnuUBxJB8O4HIG85DNcCRKhLVI2tbrmCvSxsy 0HjCL4e+i/TJp0bObeV2oQGPK2oi1pUwCSMbhs1Xvqjk67nFb5cMzFEfZjdBUxNskbvE aG70id2d58BewWxWMTbahvD6TBxvfBA+cS49Ro7aBzbWip7WlGvDvQt2DlqJh70EkldL pbsw== X-Gm-Message-State: AHQUAubYXnsoJOI/MG93Q7Z4iwgMURF0/z3ZFwngn4GIq4NI9oiBAFGQ H/VzlFYwY67x1WVHt+1s0aCrlA== X-Google-Smtp-Source: AHgI3IayeQHEU55wRkhG7tOfZn05NdDP/MkvMZZ/KVqWl9rJ1MkrJkugrYokbzKEGjf01w0oPI6Hdw== X-Received: by 2002:a17:902:aa07:: with SMTP id be7mr7209819plb.63.1550024496462; Tue, 12 Feb 2019 18:21:36 -0800 (PST) Received: from [10.58.0.74] ([64.64.108.254]) by smtp.gmail.com with ESMTPSA id p64sm24789431pfi.56.2019.02.12.18.21.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 12 Feb 2019 18:21:35 -0800 (PST) To: Leif Lindholm Cc: linaro-uefi@lists.linaro.org, edk2-devel@lists.01.org, graeme.gregory@linaro.org, ard.biesheuvel@linaro.org, michael.d.kinney@intel.com, lersek@redhat.com, wanghuiqiang@huawei.com, huangming23@huawei.com, zhangjinsong2@huawei.com, huangdaode@hisilicon.com, john.garry@huawei.com, xinliang.liu@linaro.org, zhangfeng56@huawei.com References: <20190201133436.10500-1-ming.huang@linaro.org> <20190201133436.10500-5-ming.huang@linaro.org> <20190212151703.zf4dwnavu4jo2fut@bivouac.eciton.net> From: Ming Huang Message-ID: <9e0df9cc-48ea-04da-62e6-55180ed31907@linaro.org> Date: Wed, 13 Feb 2019 10:21:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20190212151703.zf4dwnavu4jo2fut@bivouac.eciton.net> Subject: Re: [PATCH edk2-platforms v1 04/16] Hisilicon/D06: Fix access variable fail issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Feb 2019 02:21:37 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 2/12/2019 11:17 PM, Leif Lindholm wrote: > On Fri, Feb 01, 2019 at 09:34:24PM +0800, Ming Huang wrote: >> From: Jason Zhang >> >> BmcWdtEnable is a field of OemConfigData structure, need have >> runtime service attribution if use it during exit boot service > > This sounds like a very shady thing to do. > Which module is seeing issues, and what issues are it seeing, during > ExitBootServices? Yes,WatchDog module read the OemConfigData.BmcWdtEnable during ExitBootServices and will get fail log before boot kernel: Get Variable failed. Status Not Found [ 0.000000] Booting Linux on physical CPU 0x0000010000 [0x480fd010] Thanks. > > / > Leif > >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ming Huang >> --- >> Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr | 2 +- >> Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr >> index 470e9ace3dcf..08236704fbfe 100644 >> --- a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr >> +++ b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfigVfr.vfr >> @@ -23,7 +23,7 @@ formset >> help = STRING_TOKEN(STR_OEM_CONFIG), >> classguid = gEfiIfrFrontPageGuid, // for MdeModule Bds. >> efivarstore OEM_CONFIG_DATA, >> - attribute = EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_NON_VOLATILE, >> + attribute = EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_RUNTIME_ACCESS, >> name = OemConfig, >> guid = gOemConfigGuid; >> >> diff --git a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c >> index 012d45bc0214..6668103af027 100644 >> --- a/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c >> +++ b/Silicon/Hisilicon/Hi1620/Hi1620OemConfigUiLib/OemConfig.c >> @@ -316,7 +316,7 @@ OemConfigUiLibConstructor ( >> Status = gRT->SetVariable ( >> OEM_CONFIG_NAME, >> &gOemConfigGuid, >> - EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS, >> + EFI_VARIABLE_NON_VOLATILE | EFI_VARIABLE_BOOTSERVICE_ACCESS | EFI_VARIABLE_RUNTIME_ACCESS, >> sizeof (OEM_CONFIG_DATA), >> &Configuration >> ); >> -- >> 2.9.5 >>