From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1C9F721ECCB04 for ; Wed, 20 Sep 2017 04:06:38 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4A552267C8; Wed, 20 Sep 2017 11:09:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 4A552267C8 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=lersek@redhat.com Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-23.rdu2.redhat.com [10.10.120.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id 196205D9CB; Wed, 20 Sep 2017 11:09:41 +0000 (UTC) To: "Ni, Ruiyu" , Paulo Alcantara , "edk2-devel@lists.01.org" Cc: "Dong, Eric" , "Zeng, Star" References: <1321928015f9ed919425051e0d75c132de77348c.1505653040.git.pcacjr@zytor.com> <734D49CCEBEEF84792F5B80ED585239D5BA44216@SHSMSX151.ccr.corp.intel.com> <71ad2dca-6b6a-f6f7-cf4b-1018f7682306@zytor.com> <734D49CCEBEEF84792F5B80ED585239D5BA63C82@SHSMSX103.ccr.corp.intel.com> <30172dc1-c168-4ad0-9cb4-12da8752ec37@redhat.com> <734D49CCEBEEF84792F5B80ED585239D5BA6407B@SHSMSX103.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: <9e1a970d-8a1e-f7f7-ff02-c569f73323ca@redhat.com> Date: Wed, 20 Sep 2017 13:09:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5BA6407B@SHSMSX103.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 20 Sep 2017 11:09:43 +0000 (UTC) Subject: Re: [PATCH v2 2/3] MdeModulePkg/PartitionDxe: Fix creation of UDF logical partition X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Sep 2017 11:06:38 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 09/20/17 12:11, Ni, Ruiyu wrote: > I am surprised that you don't know ECC tool. 😊 > It's a much more complex tool than PatchCheck.py. > It's to report all coding style issues that doesn't follow EDKII C coding style. Well, before my previous email, I tried to execute the command line you named, but it didn't work: $ source edksetup.sh $ Ecc -t MdeModulePkg/Universal/Disk/PartitionDxe -s Traceback (most recent call last): File "BaseTools/BinWrappers/PosixLike/../../Source/Python/Ecc/Ecc.py", line 24, in from Check import Check File "BaseTools/Source/Python/Ecc/Check.py", line 20, in import c File "BaseTools/Source/Python/Ecc/c.py", line 18, in import CodeFragmentCollector File "BaseTools/Source/Python/Ecc/CodeFragmentCollector.py", line 23, in import antlr3 ImportError: No module named antlr3 Now I'v checked both Fedora and RHEL7 packages for an "antlr3" python module, but it doesn't exist. The "antlr3" package itself exists in both distros, but the changelogs say, > * Thu Feb 23 2012 Miloš Jakubíček > - 3.4-5 - Disable python runtime (incompatible with current antlr version) The following RHBZ looks relevant: Either way, I don't think I can use the ECC tool. Thanks, Laszlo >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Wednesday, September 20, 2017 5:59 PM >> To: Ni, Ruiyu ; Paulo Alcantara ; >> edk2-devel@lists.01.org >> Cc: Dong, Eric ; Zeng, Star >> Subject: Re: [PATCH v2 2/3] MdeModulePkg/PartitionDxe: Fix creation of >> UDF logical partition >> >> Ray, >> >> On 09/20/17 10:14, Ni, Ruiyu wrote: >> >>> When you add the header comments, please run Python >>> BaseTools/Source/Python/Ecc/Ecc.py -t >>> MdeModulePkg/Universal/Disk/PartitionDxe -s To make sure there is no >> other coding style issue. >> >> side question: do you mean "PatchCheck.py"? >> >> I've never heard of "Ecc.py" before, what does it do? (The top comment only >> says "This file is used to be the main entrance of ECC tool", and the >> "BaseTools/UserManuals" directory doesn't seem to contain anything >> related.) >> >> Thanks, >> Laslzo