From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.8732.1662562815654673165 for ; Wed, 07 Sep 2022 08:00:15 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=maZeRiWF; spf=pass (domain: linux.microsoft.com, ip: 13.77.154.182, mailfrom: mikuback@linux.microsoft.com) Received: from [192.168.4.22] (unknown [47.195.228.134]) by linux.microsoft.com (Postfix) with ESMTPSA id 357F820B929C; Wed, 7 Sep 2022 08:00:14 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 357F820B929C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1662562815; bh=/wdWz6Xfy1+ZmpoIEP32nHQ2OvfVSBjIqxGiHZzzk+E=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=maZeRiWFSk3d5xfXGG1zkoCcCmBYuK+9/vrzibU95OST5dvshZYoA27YmfPYocNl1 fTR3n2gvDnZfBu3lWYP5xwa7jrlI/OULLcI6AGwOBodS0BMjIQDJB7mA2lZDsDfkqx IF8puPQi+Hc9VKX7GaM0wUg6rp51vzxAlLqJaeqs= Message-ID: <9e215e11-31cc-9b4d-2290-6cfd26f816a2@linux.microsoft.com> Date: Wed, 7 Sep 2022 11:00:12 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI To: devel@edk2.groups.io, ardb@kernel.org Cc: Leif Lindholm , Ard Biesheuvel , Abner Chang , Daniel Schaefer References: <20220907023649.312-1-mikuback@linux.microsoft.com> From: "Michael Kubacki" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit When would you like to have that discussion? The Tianocore Tool, CI, Codebase meeting is every week. In that meeting we've discussed getting all edk2 packages to at least run CI. https://github.com/tianocore/edk2/discussions/2614 If you prefer to have it here, that's fine as well. On 9/7/2022 3:37 AM, Ard Biesheuvel wrote: > On Wed, 7 Sept 2022 at 04:37, wrote: >> >> From: Michael Kubacki >> >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4046 >> >> Adds EmbeddedPkg to edk2 CI. >> >> Due to a number of build errors (some intentional) such as >> 'BUILD_EPOCH' only being defined for GCC in >> VirtualRealTimeClockLib.inf, the package is only run on GCC >> build agents. >> >> This still allows build to be verified and non-build CI checks >> to be performed. >> >> In the edk2 PR for this change, you can see that the package only >> runs on GCC and CI passes with this configuration. >> >> https://github.com/tianocore/edk2/pull/3299 >> >> Cc: Leif Lindholm >> Cc: Ard Biesheuvel >> Cc: Abner Chang >> Cc: Daniel Schaefer >> Signed-off-by: Michael Kubacki >> >> Michael Kubacki (3): >> EmbeddedPkg/AcpiLib: Fix code formatting errors >> EmbeddedPkg: Add CI YAML file >> EmbeddedPkg: Only run in CI for GCC5 >> > > NAK until we have a discussion about strictness of CI and ways to > permit manual override of merge time CI restrictions. > > >> EmbeddedPkg/Library/AcpiLib/AcpiLib.c | 88 +++++++++---------- >> .azurepipelines/templates/pr-gate-build-job.yml | 4 + >> .pytool/CISettings.py | 1 + >> EmbeddedPkg/EmbeddedPkg.ci.yaml | 89 ++++++++++++++++++++ >> EmbeddedPkg/EmbeddedPkg.dec | 8 ++ >> EmbeddedPkg/Include/Library/AcpiLib.h | 22 ++--- >> 6 files changed, 158 insertions(+), 54 deletions(-) >> create mode 100644 EmbeddedPkg/EmbeddedPkg.ci.yaml >> >> -- >> 2.28.0.windows.1 >> > > > >