From: "Laszlo Ersek" <lersek@redhat.com>
To: Dandan Bi <dandan.bi@intel.com>, devel@edk2.groups.io
Cc: Eric Dong <eric.dong@intel.com>, Ray Ni <ray.ni@intel.com>,
Rahul Kumar <rahul1.kumar@intel.com>
Subject: Re: [patch V2 25/29] UefiCpuPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib
Date: Mon, 22 Mar 2021 19:32:02 +0100 [thread overview]
Message-ID: <9e56401b-9265-1269-806b-4fec5457182f@redhat.com> (raw)
In-Reply-To: <20210322080941.6780-26-dandan.bi@intel.com>
On 03/22/21 09:09, Dandan Bi wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246
>
> MdeLibs.dsc.inc was added for some basic/default library
> instances provided by MdePkg and RegisterFilterLibNull Library
> was also added into it as the first version of MdeLibs.dsc.inc.
>
> So update platform dsc to consume MdeLibs.dsc.inc for
> RegisterFilterLibNull which will be consumed by IoLib and BaseLib.
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> UefiCpuPkg/UefiCpuPkg.dsc | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc
> index 7db419471d..6c7cc6b273 100644
> --- a/UefiCpuPkg/UefiCpuPkg.dsc
> +++ b/UefiCpuPkg/UefiCpuPkg.dsc
> @@ -1,9 +1,9 @@
> ## @file
> # UefiCpuPkg Package
> #
> -# Copyright (c) 2007 - 2019, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2007 - 2021, Intel Corporation. All rights reserved.<BR>
> #
> # SPDX-License-Identifier: BSD-2-Clause-Patent
> #
> ##
>
> @@ -20,10 +20,12 @@ [Defines]
> #
> # External libraries to build package
> #
>
> [LibraryClasses]
> + !include MdePkg/MdeLibs.dsc.inc
> +
> BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf
> DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
> SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf
>
I would suggest un-indenting the !include directive here as well.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks
Laszlo
next prev parent reply other threads:[~2021-03-22 18:32 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 8:09 [patch V2 00/29] Add a new library class RegisterFilterLib in edk2 to filter/trace port IO/MMIO/MSR access Dandan Bi
2021-03-22 8:09 ` [patch V2 01/29] MdePkg: Add RegisterFilterLib class and NULL instance Dandan Bi
2021-03-23 2:24 ` [edk2-devel] " Abner Chang
2021-03-22 8:09 ` [patch V2 02/29] MdePkg: Add MdeLibs.dsc.inc file to MdePkg Dandan Bi
2021-03-22 17:46 ` Laszlo Ersek
2021-03-23 3:40 ` [edk2-devel] " Ni, Ray
2021-03-26 0:48 ` Michael D Kinney
2021-03-26 1:51 ` Dandan Bi
2021-03-26 7:39 ` Dandan Bi
2021-03-22 8:09 ` [patch V2 03/29] ArmPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib Dandan Bi
2021-03-22 8:09 ` [patch V2 04/29] ArmPlatformPkg: " Dandan Bi
2021-03-22 8:09 ` [patch V2 05/29] ArmVirtPkg: " Dandan Bi
2021-03-22 18:30 ` Laszlo Ersek
2021-03-22 8:09 ` [patch V2 06/29] CryptoPkg: " Dandan Bi
2021-03-22 8:20 ` Yao, Jiewen
2021-03-22 8:09 ` [patch V2 07/29] DynamicTablesPkg: " Dandan Bi
2021-03-22 8:09 ` [patch V2 08/29] EmbeddedPkg: " Dandan Bi
2021-03-22 8:09 ` [patch V2 09/29] EmulatorPkg: " Dandan Bi
2021-03-25 23:29 ` Ni, Ray
2021-03-22 8:09 ` [patch V2 10/29] FatPkg: " Dandan Bi
2021-03-25 23:30 ` Ni, Ray
2021-03-22 8:09 ` [patch V2 11/29] FmpDevicePkg: " Dandan Bi
2021-03-22 8:09 ` [patch V2 12/29] IntelFsp2Pkg: " Dandan Bi
2021-03-22 8:09 ` [patch V2 13/29] IntelFsp2WrapperPkg: " Dandan Bi
2021-03-22 8:09 ` [patch V2 14/29] MdeModulePkg: " Dandan Bi
2021-03-23 1:01 ` Wu, Hao A
2021-03-22 8:09 ` [patch V2 15/29] MdePkg: " Dandan Bi
2021-03-22 8:09 ` [patch V2 16/29] NetworkPkg: " Dandan Bi
2021-03-22 8:09 ` [patch V2 17/29] OvmfPkg: " Dandan Bi
2021-03-22 18:31 ` Laszlo Ersek
2021-03-22 8:09 ` [patch V2 18/29] PcAtChipsetPkg: " Dandan Bi
2021-03-25 23:30 ` Ni, Ray
2021-03-22 8:09 ` [patch V2 19/29] RedfishPkg: " Dandan Bi
2021-03-23 2:17 ` Abner Chang
2021-03-23 2:32 ` Nickle Wang
2021-03-22 8:09 ` [patch V2 20/29] SecurityPkg: " Dandan Bi
2021-03-22 8:09 ` [patch V2 21/29] ShellPkg: " Dandan Bi
2021-03-22 8:09 ` [patch V2 22/29] SignedCapsulePkg: " Dandan Bi
2021-03-22 8:09 ` [patch V2 23/29] SourceLevelDebugPkg: " Dandan Bi
2021-03-23 1:02 ` Wu, Hao A
2021-03-22 8:09 ` [patch V2 24/29] StandaloneMmPkg: " Dandan Bi
2021-03-22 8:09 ` [patch V2 25/29] UefiCpuPkg: " Dandan Bi
2021-03-22 18:32 ` Laszlo Ersek [this message]
2021-03-25 23:32 ` [edk2-devel] " Ni, Ray
2021-03-26 0:32 ` Dong, Eric
2021-03-22 8:09 ` [patch V2 26/29] UefiPayloadPkg: " Dandan Bi
2021-03-22 14:03 ` Ma, Maurice
2021-03-23 5:20 ` Guo Dong
2021-03-22 8:09 ` [patch V2 27/29] UnitTestFrameworkPkg: " Dandan Bi
2021-03-22 18:25 ` [EXTERNAL] " Bret Barkelew
2021-03-23 1:52 ` Dandan Bi
2021-03-25 18:35 ` Bret Barkelew
2021-03-26 7:36 ` Dandan Bi
2021-03-22 8:09 ` [patch V2 28/29] MdePkg/IoLib: Filter/trace port IO/MMIO access Dandan Bi
2021-03-22 8:09 ` [patch V2 29/29] MdePkg/Baseib: Filter/trace MSR access for IA32/X64 Dandan Bi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9e56401b-9265-1269-806b-4fec5457182f@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox