From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web08.1804.1616437929472550291 for ; Mon, 22 Mar 2021 11:32:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=RxAqiT9n; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616437928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PjffCLYc300hNSKlWYxRcQ4aSBdOCRy28EJmPPwhuDk=; b=RxAqiT9n/xx57Agxq6sifKJxx6lVavL4tuoh++aepzTYY8rN3L0JThtWYbcrYmpBLHW5UX vhhe/P1C8rqsooh1omRCmvh0Q6VAGom4XB7JH5u5/4O97aCbKyoI1fRHuqyhc28cz9yCJI afi8jKVtQGWTA0IjDZUghj8JMRM1j8M= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-203-DuHDWqjUNzCYG7QmPMcpFg-1; Mon, 22 Mar 2021 14:32:05 -0400 X-MC-Unique: DuHDWqjUNzCYG7QmPMcpFg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5F695593A0; Mon, 22 Mar 2021 18:32:04 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-223.ams2.redhat.com [10.36.115.223]) by smtp.corp.redhat.com (Postfix) with ESMTP id 391E11002388; Mon, 22 Mar 2021 18:32:03 +0000 (UTC) Subject: Re: [patch V2 25/29] UefiCpuPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib To: Dandan Bi , devel@edk2.groups.io Cc: Eric Dong , Ray Ni , Rahul Kumar References: <20210322080941.6780-1-dandan.bi@intel.com> <20210322080941.6780-26-dandan.bi@intel.com> From: "Laszlo Ersek" Message-ID: <9e56401b-9265-1269-806b-4fec5457182f@redhat.com> Date: Mon, 22 Mar 2021 19:32:02 +0100 MIME-Version: 1.0 In-Reply-To: <20210322080941.6780-26-dandan.bi@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 03/22/21 09:09, Dandan Bi wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3246 > > MdeLibs.dsc.inc was added for some basic/default library > instances provided by MdePkg and RegisterFilterLibNull Library > was also added into it as the first version of MdeLibs.dsc.inc. > > So update platform dsc to consume MdeLibs.dsc.inc for > RegisterFilterLibNull which will be consumed by IoLib and BaseLib. > > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Rahul Kumar > Signed-off-by: Dandan Bi > --- > UefiCpuPkg/UefiCpuPkg.dsc | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc > index 7db419471d..6c7cc6b273 100644 > --- a/UefiCpuPkg/UefiCpuPkg.dsc > +++ b/UefiCpuPkg/UefiCpuPkg.dsc > @@ -1,9 +1,9 @@ > ## @file > # UefiCpuPkg Package > # > -# Copyright (c) 2007 - 2019, Intel Corporation. All rights reserved.
> +# Copyright (c) 2007 - 2021, Intel Corporation. All rights reserved.
> # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > ## > > @@ -20,10 +20,12 @@ [Defines] > # > # External libraries to build package > # > > [LibraryClasses] > + !include MdePkg/MdeLibs.dsc.inc > + > BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf > DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > SerialPortLib|MdePkg/Library/BaseSerialPortLibNull/BaseSerialPortLibNull.inf > I would suggest un-indenting the !include directive here as well. Reviewed-by: Laszlo Ersek Thanks Laszlo