From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <mark.kettenis@sibelius.xs4all.nl>
Received-SPF: None (no SPF record) identity=mailfrom; client-ip=83.163.83.176;
 helo=sibelius.xs4all.nl; envelope-from=mark.kettenis@sibelius.xs4all.nl;
 receiver=edk2-devel@lists.01.org 
Received: from sibelius.xs4all.nl (sibelius.xs4all.nl [83.163.83.176])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 7F84121190710
 for <edk2-devel@lists.01.org>; Tue, 20 Nov 2018 00:05:08 -0800 (PST)
Received: from localhost (bloch.sibelius.xs4all.nl [local])
 by bloch.sibelius.xs4all.nl (OpenSMTPD) with ESMTPA id 1fff1775;
 Tue, 20 Nov 2018 08:38:27 +0100 (CET)
Date: Tue, 20 Nov 2018 08:38:27 +0100 (CET)
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
CC: edk2-devel@lists.01.org
In-reply-to: <20181119160338.5774-1-ard.biesheuvel@linaro.org> (message from
 Ard Biesheuvel on Mon, 19 Nov 2018 08:03:38 -0800)
References: <20181119160338.5774-1-ard.biesheuvel@linaro.org>
Message-ID: <9e5c99b032f71776@bloch.sibelius.xs4all.nl>
Subject: Re: [PATCH] Silicon/SynQuacer: remove bogus PL011 _HID from DSDT ACPI table
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Nov 2018 08:05:10 -0000

> From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Date: Mon, 19 Nov 2018 08:03:38 -0800
> 
> PL011 is not a valid ACPI identifier so don't expose it as a _CID.
> Since _CID (Comptable ID) is optional, let's just drop it.

Heh, I Noticed that one when adding ACPI support for OpenBSD/arm64.

Reviewed-by: Mark Kettenis <kettenis@openbsd.org>

> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
> index 3f73c191d4d6..7c7677f1fea0 100644
> --- a/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
> +++ b/Silicon/Socionext/SynQuacer/AcpiTables/Dsdt.asl
> @@ -135,7 +135,6 @@ DefinitionBlock ("DsdtTable.aml", "DSDT", 1, "SNI", "SYNQUACR",
>      // UART PL011
>      Device (COM0) {
>        Name (_HID, "ARMH0011")
> -      Name (_CID, "PL011")
>        Name (_UID, Zero)
>        Name (_CRS, ResourceTemplate () {
>          Memory32Fixed (ReadWrite, FixedPcdGet32 (PcdSerialRegisterBase), 0x1000)
> -- 
> 2.17.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
>