From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.49]) by mx.groups.io with SMTP id smtpd.web12.788.1621024371843932721 for ; Fri, 14 May 2021 13:32:52 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=hyN0hkER; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.220.49, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kcZ74FEXLKdrzGk3gHYovnTSI0trOq9N5fx+HHIO8jkxyaAOMDtJ4iNM0SByMj0qMtn/3AFq0ZQz5r1O3xYGROJW0ED43/2ltYMHO0dniu+bzT3XdgvEOGt7M0yAXDjI7R+PGmWM4T9fyFeMLVGcZiPur6ffRk7TySNfT4wex9c4CVEe6npbLlM+QJFYcYLK6lpLwD8dGMUhMfO+ozjGaTiLxMxUeBX3DD1DEe5jhR3nnFZIjg0l/PUqvTP8cS/BUtJGvN6RBKs4UrHXSoVgQk5mJaIYTUL7Eg2OLeDU9h7mbDDjJm47OZXkPUkNJl/MLWffD0voXQ7xQXfiXJpMzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DGVx7+itS0fNxrXMcw67fd3f/VO0B7QAkwZdVS2sO0Y=; b=JJXPwnXUGMiguwgDns+nCvTDWtuXXBANe9TSHAQAldX0TH3Wd+oLFb+E5WXJHwIGj5b84TEWJ4sLsX23SSfzANtM+0HcuuBTC9EUuEX8fxMPkbqlBwFQF8k1hfOeiVBbBGQtXLOG4JdMwN1FWjOeATeyd9rN2FusQ3vyZKINxGAYFql5GrCLmqyiQgKbhWcxz9rDsfwXPg0jSE3Ahe6pNv4rRELyAEtS70VJTsMB168XJJWrfVf9xIhU6fdLBE6PnTJNO7Uz7h0t8KacFaqX0WJtUMZXH0PPJPzhFy57RC1hZQq7SDlOgVQOzrC4ZzXAq/va9GT8c8JZOYBW5FZw9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DGVx7+itS0fNxrXMcw67fd3f/VO0B7QAkwZdVS2sO0Y=; b=hyN0hkERp3Dm0aajrkvEkE4ycDop21AQp6XQm2/ASbyscAZJePWx0BOf8UC+oJhVjUC7SksmNuRSJU3YFJG3vvTcV84mSU94tdg8pKupgQAyeZoHLAXVKNe9YHBoJ5CrJZ+QYQcZO/KGy4fyC/m3VKszRcnY5KOXPzj2HjZAV6A= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=amd.com; Received: from DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) by DM6PR12MB3964.namprd12.prod.outlook.com (2603:10b6:5:1c5::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.26; Fri, 14 May 2021 20:32:50 +0000 Received: from DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::b914:4704:ad6f:aba9]) by DM5PR12MB1355.namprd12.prod.outlook.com ([fe80::b914:4704:ad6f:aba9%12]) with mapi id 15.20.4129.025; Fri, 14 May 2021 20:32:49 +0000 Subject: =?UTF-8?B?UmU6IOWbnuWkjTogW2VkazItZGV2ZWxdIFtQQVRDSF0gVWVmaUNwdVBrZy9NcEluaXRMaWI6IFByb3Blcmx5IGNhc3QgZnJvbSBQQ0QgdG8gU0VWLUVTIGp1bXAgdGFibGUgcG9pbnRlcg==?= To: devel@edk2.groups.io, gaoliming@byosoft.com.cn CC: 'Brijesh Singh' , 'Eric Dong' , 'Ray Ni' , 'Laszlo Ersek' , 'Rahul Kumar' References: <008c01d74612$4d9428b0$e8bc7a10$@byosoft.com.cn> <167F06F8CCEA121A.12775@groups.io> From: "Lendacky, Thomas" Message-ID: <9e63ecbe-ebd8-2603-c750-c07aba842f28@amd.com> Date: Fri, 14 May 2021 15:32:47 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 In-Reply-To: <167F06F8CCEA121A.12775@groups.io> X-Originating-IP: [67.79.209.213] X-ClientProxiedBy: SA9PR13CA0142.namprd13.prod.outlook.com (2603:10b6:806:27::27) To DM5PR12MB1355.namprd12.prod.outlook.com (2603:10b6:3:6e::7) Return-Path: thomas.lendacky@amd.com MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from office-linux.texastahm.com (67.79.209.213) by SA9PR13CA0142.namprd13.prod.outlook.com (2603:10b6:806:27::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.11 via Frontend Transport; Fri, 14 May 2021 20:32:49 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cdd817b8-eede-4e0c-b929-08d9171770f9 X-MS-TrafficTypeDiagnostic: DM6PR12MB3964: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: puxVJDNMrQ0XTMwpzj/8/FBmdk3B4wVSYtNOKhtcaK+GYuSLuvLP5+TAydBtxnqm+/RzUmgOPVIUEEJzMryrxfYrS6qTI/VCi7dedvAYI54mpu1kvASxm5ndxDFYNlXlAoOjnvExUgaOT9mORSZQC1deha/D+kwpU1Ita/BWHkR9Z12RYuaseDj7Oe0BnW+0mxTme/HfEs8uTCeuRevWji1oVJ5ecSJFdLQl+zB6UMgnSAEeUZerVEaOhHweBzEZEd73cUoshgA41Q5b2cmUiTRjo9M/FUO+ebdyHv7kdjoFSc9T5DBfqqv1yObS0VY0HEnV8dnbJzeMJoQydfE96HGt5ro46ta5R9s4fU/kbPIhcLWf4efCF6DNu31ISoG27tcmfo3wds15O002kYxRuPe3wEcw2a2dp+YVMopXPuU0HZ4i2bfygeOPaBYkEkc5wsliYmlBzggEcBJb5oUjSD02sAmcrMYvmeraJ1s61f/DGo64WmQH0I4KiHUGH+XBJ7/NQ2MKpMoGxFa8pqQpRbzHQyPq2ovDd2VyPFi4WlnPZYAcccDV0xdJk8oXdF7eekPzRcMt9Fw7sTdocdS2vuue2SS+4EzmtVcOCzVLirfJwZ2/WL13oI/KDWZp9GEJUtKaJUJKCQ2yFe3bqikEcqfQA+bfE8WUxikocIi7M/ZsW29LMifLuvoElM5XAG5zitLKk1P/ItnbnPwT11GbQgbNSigaKRqUJgsdexqktPbodz8Z3ZwNO3nHqo2gjGEoS0MTYcDipHDJKbj5OWy6jQkttBdOTGEYdO/tbDh5XTjWpgV8nmYmR4dWoQ3Eg+Fn X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR12MB1355.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(136003)(376002)(366004)(346002)(396003)(39860400002)(956004)(66556008)(53546011)(31686004)(16526019)(6506007)(26005)(38100700002)(36756003)(6486002)(4326008)(83380400001)(8936002)(45080400002)(186003)(478600001)(66946007)(66476007)(6512007)(86362001)(966005)(2616005)(224303003)(5660300002)(2906002)(31696002)(54906003)(316002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?jtTD2tNMCLWnvMwAz/z40QnZMk6s1/b+gyjx9xeT5OngX+jPvMvWmAe0X3Ea?= =?us-ascii?Q?NTTuYZ7Kh08+Zd86DmFvvwwOO9xfZS1Gz/OPoVC9SpMJoaO63J9XoSPiyvel?= =?us-ascii?Q?PAZ6MKCMrKDIpO7XKkG51EWGpoyIg9/V2l0W4+LfWkVXw6u0GAjn2mUKnuMg?= =?us-ascii?Q?By0NmTa8lezfthaIHhFiUl7f1I8HfPmDf/FAr7naNsWMCuXywZ9LlAR8Nk2a?= =?us-ascii?Q?xuZAF7rsns9iss2gZTxb/0ql5rbuul9ilcH7eGV+jxaBs1zC5wkLMTMVsCrs?= =?us-ascii?Q?AyElTblPpc2RHL7xVXG7DgjaqE0d/a5e5Nsu+UNhVDxHQqZlYSHLoFwNJGho?= =?us-ascii?Q?kH6z2KVU+4Rbc0E5tW3cYGEk/OMvrjj8p7kHQuOinIl48LuDsIoJL3ge85cI?= =?us-ascii?Q?W7ZpZavZA1sreG7Hma5izyixRMSxJRUp+YEYx4M25lXDuPPrSfXUREwiHX8K?= =?us-ascii?Q?Oy5PwYoMqOWx7bu+BEz7BBVN7Qa6IzoC8ud9/e09pm+pM9o6Fr1ztlr4hPAe?= =?us-ascii?Q?H0wqdwweDCIbWGcF7nE1iG7fyugyQWtdsiz6JwsOTLa3nO7lqCyhXJAw5jAo?= =?us-ascii?Q?GpODEZOqP9WXkguHjGCXfIirJwvuRZ/MDn9Kso623mpQ68DjMEaGmP9TM3Me?= =?us-ascii?Q?WIctfwyTFe88MC7/9EB8uryAUEGWWymIYLxyAPyJ5bl6cRnVDETHuSYTxkIB?= =?us-ascii?Q?/D01hXQs1IbUAZgxz8qnvrWA7n1YU0q7IaIxf/q79uOg2ExQgFNWvYwAhvHB?= =?us-ascii?Q?ywULXXc0YZxd5r5Ckp/37bCzySe0RBzsVyvBPR+AgK7YW66LUEQ8jMZ56ziW?= =?us-ascii?Q?NeS0Fn1huipNiSMTJNi+qUvJJxvrZDlfcib49GpHAn80KX1F4dKG/WEkVyIi?= =?us-ascii?Q?gAoYjoQnTfiDJmcM0DEKs0Op1O1CAtfW77WtI/xQAHaM9ZJElmZiNJqr0TA4?= =?us-ascii?Q?Q6G4zljCxHD2xJPveY3WEjNOaO6lA3fbEaSlXY05AdKJoAArgAdxC43clNAI?= =?us-ascii?Q?3eaBlSsLM8CwoBkiEi2DvbKmqoHjt/8kHz3GVi/+LBa/wjIquLF6BXWiKZ1B?= =?us-ascii?Q?Ip+C/UeKTcdQQnsEBziPUPVBGE3vbcWsVruFnJf8THM6KP8tJfnMJVE8Vdsh?= =?us-ascii?Q?Uw9gmkIj4oBjyUOCWkVheTDHZBX8mT8oXw8XYCFLWYQwS4eNhadCzxZiEVyA?= =?us-ascii?Q?iPWHvUSho2H92ZkhonesLCRYbmCyI6ORXZL74malFtuzVOt9tN2G+cq252nb?= =?us-ascii?Q?WPjjrOzWTNygtLuz3HhjCyP+p9JlqdLhU6VwRk2ETCUG/0efrcKaNoksyRcv?= =?us-ascii?Q?roXxQrkfOQfMWlDklrK7g/W2?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: cdd817b8-eede-4e0c-b929-08d9171770f9 X-MS-Exchange-CrossTenant-AuthSource: DM5PR12MB1355.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2021 20:32:49.7936 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Vapc+k16VChZHmZ7gEuxUXKPsndVYN0r6crCF+0GHobhxTj1HdyA659oVh0semTM1AEEJtu2lggDnAa5mzwaGA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3964 Content-Type: text/plain; charset=gbk Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 5/14/21 2:54 PM, Lendacky, Thomas via groups.io wrote: > On 5/10/21 10:04 PM, gaoliming via groups.io wrote: >> Reviewed-by: Liming Gao >=20 > Thanks, Liming. >=20 > Sorry, for the delay, your email ended up in my Spam folder... urg, IT = at > its best. Anyway... >=20 > The patch is changing enough that I don't think I should add your > Reviewed-by: just yet. Look for a new version soon. Ugh, I thought this was for AP reset stack... wrong patch. Disregard. Thanks, Tom >=20 > Thanks, > Tom >=20 >> >>> -----=D3=CA=BC=FE=D4=AD=BC=FE----- >>> =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA= = =B1=ED Lendacky, >>> Thomas >>> =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA5=D4=C210=C8=D5 22:25 >>> =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io >>> =B3=AD=CB=CD: Brijesh Singh ; Eric Dong >>> ; Ray Ni ; Laszlo Ersek >>> ; Rahul Kumar >>> =D6=F7=CC=E2: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Properly cast= from PCD to >>> SEV-ES jump table pointer >>> >>> BZ: https://nam11.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%= 2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3385&data=3D04%7C01%7Cth= omas.lendacky%40amd.com%7C0587fecbb35842c6d81408d9171212b5%7C3dd8961fe4884e= 608e11a82d994e183d%7C0%7C0%7C637566188656978758%7CUnknown%7CTWFpbGZsb3d8eyJ= WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&= sdata=3DsdSuHzrY%2BTfhad8aLKLSHvnPnL91CqHxclfH5E07aAc%3D&reserved=3D0 >>> >>> A VS2012 build fails with a cast conversion warning when the SEV-ES wo= rk >>> area PCD is cast as a pointer to the SEV_ES_AP_JMP_FAR type. >>> >>> When casting from a PCD value to a pointer, the cast should first be d= one >>> to a UINTN and then to the pointer. Update the code to perform a cast = to >>> a UINTN before casting to a pointer to the SEV_ES_AP_JMP_FAR type. >>> >>> Cc: Eric Dong >>> Cc: Ray Ni >>> Cc: Laszlo Ersek >>> Cc: Rahul Kumar >>> Signed-off-by: Tom Lendacky >>> --- >>> UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c >>> b/UefiCpuPkg/Library/MpInitLib/MpLib.c >>> index 3d945972a025..dc2a54aa31e8 100644 >>> --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c >>> +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c >>> @@ -1265,7 +1265,7 @@ SetSevEsJumpTable ( >>> UINT32 Offset, InsnByte; >>> UINT8 LoNib, HiNib; >>> >>> - JmpFar =3D (SEV_ES_AP_JMP_FAR *) FixedPcdGet32 >>> (PcdSevEsWorkAreaBase); >>> + JmpFar =3D (SEV_ES_AP_JMP_FAR *) (UINTN) FixedPcdGet32 >>> (PcdSevEsWorkAreaBase); >>> ASSERT (JmpFar !=3D NULL); >>> >>> // >>> -- >>> 2.31.0 >>> >>> >>> >>> >>> >> >> >> >> >> >> >> >> >=20 >=20 >=20 >=20 >=20