From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E33DE210F2574 for ; Tue, 3 Jul 2018 08:52:48 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2A33981ACF3E; Tue, 3 Jul 2018 15:52:48 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-222.rdu2.redhat.com [10.10.120.222]) by smtp.corp.redhat.com (Postfix) with ESMTP id B5D171C5B4; Tue, 3 Jul 2018 15:52:46 +0000 (UTC) To: Ruiyu Ni References: <20180703063743.373172-1-ruiyu.ni@intel.com> From: Laszlo Ersek Cc: edk2-devel@lists.01.org, "Leif Lindholm (Linaro address)" , Ard Biesheuvel , David Wei , Mang Guo Message-ID: <9e74a4d8-60b8-eeb9-8acd-2ff3418c9e83@redhat.com> Date: Tue, 3 Jul 2018 17:52:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180703063743.373172-1-ruiyu.ni@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Tue, 03 Jul 2018 15:52:48 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Tue, 03 Jul 2018 15:52:48 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH v3 0/7] Add platform hook for ultimate boot failure. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 15:52:49 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Ray, On 07/03/18 08:37, Ruiyu Ni wrote: > Ruiyu Ni (7): > MdeModulePkg/PlatformBootManager: Add PlatformBootManagerUnableToBoot > CorebootPayload/PlatformBDS: Impl PlatformBootManagerUnableToBoot > OvmfPkg/PlatformBds: Implement PlatformBootManagerUnableToBoot > Nt32Pkg/PlatformBDS: Implement PlatformBootManagerUnableToBoot > QuarkPlatform/PlatformBDS: Implement PlatformBootManagerUnableToBoot > MdeModulePkg/BdsDxe: Revert "fall back to UI loop before hanging" > MdeModulePkg/BdsDxe: Call PlatformBootManagerUnableToBoot() > > .../PlatformBootManagerLib/PlatformBootManager.c | 19 ++++++- > .../Include/Library/PlatformBootManagerLib.h | 13 +++++ > .../PlatformBootManager.c | 19 ++++++- > MdeModulePkg/Universal/BdsDxe/BdsEntry.c | 61 ++-------------------- > .../PlatformBootManagerLib/PlatformBootManager.c | 19 ++++++- > .../Library/PlatformBootManagerLib/BdsPlatform.c | 61 +++++++++++++++++++++- > .../PlatformBootManagerLib/PlatformBootManager.c | 19 ++++++- > 7 files changed, 150 insertions(+), 61 deletions(-) > thanks a lot for this version as well! It seems we have the following PlatformBootManagerLib instances in the edk2 tree: ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf MdeModulePkg/Library/PlatformBootManagerLibNull/PlatformBootManagerLibNull.inf Nt32Pkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf This series updates all but ArmPkg, ArmVirtPkg and Vlv2TbltDevicePkg. So I think three more patches would be necessary, before patch #6. Originally, with the registration pattern, I offered to port the OvmfPkg update to ArmVirtPkg myself, later. However, with the present pattern, these three platforms would stop building, so I think they should be updated before we commit patches #6 and #7. For ArmPkg and Vlv2TbltDevicePkg, I *think* the Null implementation ("do nothing") is appropriate. (I'm CC'ing those package maintainers). For ArmVirtPkg, duplicating the OvmfPkg approach would be correct. Can you take on updating these three platforms as well? Or can I help somehow with it? (It's tricky because the three platform patches that I could post should go in the middle of the series, neither before nor after.) Thank you! Laszlo