From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR04-HE1-obe.outbound.protection.outlook.com (EUR04-HE1-obe.outbound.protection.outlook.com [40.107.7.50]) by mx.groups.io with SMTP id smtpd.web10.9967.1663952150091634972 for ; Fri, 23 Sep 2022 09:55:51 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=0i4x9uuT; spf=pass (domain: arm.com, ip: 40.107.7.50, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=QKCrLjt+VCuY3SOmgBVeTL1D7t7W4rFMWIrcpGfx35qcAqhlulHJT7jQBycXNCYVos1toSUpgCd7suREli1qOkJ6EENVbmP5nOXvUWmLZqQZ1tOb4foW55gehfipVSZ79OKxfc1TUoMr07vh2iKhmOMSBxXZzI3pjpsPVgOharQUocqiKDFFw8XwKdg1ybE1SaxLjU1swshNVmnGXB1mC39JAtT/bMGFPZJ/mQ0hm+8UstGfCvcPx7cMWlwMK2Zwhm62nnOGyT4d9g1RcgwQ7gAr8hyY+tHlqtEQ84a3W2PEW5WxnhDiZqjloqnsAjMD7c7SEZJbLTDb8gedJrtz1g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ImifEXhiyroju2U25tYD9klgsfyqI8fExgnBQ42mwFM=; b=S02Ai+fA00pNR6h5LZB/u/Q2oI2TNeLlGaCrNEca7Jij3goAnp29yiXEP80j4kFqRZURk2kL1NhUj/2XJHp0dS3SFbOesuWFAR80TWok+JvM58XmCrhPyrehvWzDLby6DvtCAlGUL0KCnda2T4DnbvZWFfF2KLwnDICfy2wgP4VvU9XjTi2mGABvodsoOJ4oEtRQlheKidbZGo0Do+YUsnUp9cIyHUBzvbRPaYCLnHKhpFvQmL5IchGRefA5zIml5R/+n+YkTX+MAI7/TkHayC5ZHGGU2ew+IJjmP+ZR+qCbvsj/Hc9UsAbdS65O++BdluXBT1ckotwkFG6YhIbAWA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ImifEXhiyroju2U25tYD9klgsfyqI8fExgnBQ42mwFM=; b=0i4x9uuTphGHmYCXDKAC7yfUWq77qmM418PKu6XjErKaZ8+TNxrUhUIiYpP3Gm668WdoquBUm2bxopnyZRUSOsXYy7+j/4cnvwJjHxzu/NUy83h+8LB5tN3pXgsBO6s44qGjOo+V7io8mkxqBI+Txns4npB4lK9RnqELy0ss860= Received: from AS8PR04CA0075.eurprd04.prod.outlook.com (2603:10a6:20b:313::20) by AS2PR08MB9151.eurprd08.prod.outlook.com (2603:10a6:20b:579::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.18; Fri, 23 Sep 2022 16:55:43 +0000 Received: from AM7EUR03FT014.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:313:cafe::d9) by AS8PR04CA0075.outlook.office365.com (2603:10a6:20b:313::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.20 via Frontend Transport; Fri, 23 Sep 2022 16:55:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT014.mail.protection.outlook.com (100.127.140.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.14 via Frontend Transport; Fri, 23 Sep 2022 16:55:43 +0000 Received: ("Tessian outbound fc2405f9ecaf:v124"); Fri, 23 Sep 2022 16:55:43 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 3a3d4bd17095e6e8 X-CR-MTA-TID: 64aa7808 Received: from 8950f8518a0e.2 by 64aa7808-outbound-1.mta.getcheckrecipient.com id C67603FE-DA88-49F8-BE67-795278ADD049.1; Fri, 23 Sep 2022 16:55:31 +0000 Received: from EUR03-AM7-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8950f8518a0e.2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 23 Sep 2022 16:55:31 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BgfmkvPpNdqRFw4MVfOsYZEofv8XLePW/6qUPVpL89K0glKzOCIVAqXcXpbW3ia/TkUiiRfOvCYE510sFTUZ6rt8h+FAUbDdfK6V0v/z7dXwlCM/qSYdNGkAm8z/0QAVFmLFxAoYkQczCd/WZn/FFs+cIQuce0DMPv+PRlSPZ9HhljjXricgc5tUGsDJ83i4Aj/2LwH6pXg/r1RUIyxkJDRhVKshFTHvglbiMzD+byn+uQMWJdhHFwwlE81+El+4C8BiaW00VuOCiyxpxTw65NHjfeVeZXntTTRyYtMWWrUyo7tuTuHwquatKOam2SdAtexGCWY+aOR0NhMDxYJFbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ImifEXhiyroju2U25tYD9klgsfyqI8fExgnBQ42mwFM=; b=gXmbw09ax5AFjcbnmNbldU/S/YxyF+rF8SSoN2Y+EFquZQYKs/WV/WlIVsodgKOA1hxwj9ubkYaIUiFjTZRw6nhHjt4Fv4Xd5EBuiGjqQxtNN/8ZpgW4CS0TSoxEUlxtdcAaw8a0boZJrC2WDC5bwkz2On24Nh8D6896yyRHicPOJ41JscOJW8SI2cNU3OC4V0ZmYJNgnQMZBVeX5rEAYHeTHCNvWyLLzNbdlRZImnHOAhtLjx10r4uwAyJNFnqP24k4exKr5nTIf+QO5Mn1pcrrldnCOahOiN+oR5gqQ52D2RoM60TigTD8lHxWEccZHE1poXlPWI9eweojIFFC/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ImifEXhiyroju2U25tYD9klgsfyqI8fExgnBQ42mwFM=; b=0i4x9uuTphGHmYCXDKAC7yfUWq77qmM418PKu6XjErKaZ8+TNxrUhUIiYpP3Gm668WdoquBUm2bxopnyZRUSOsXYy7+j/4cnvwJjHxzu/NUy83h+8LB5tN3pXgsBO6s44qGjOo+V7io8mkxqBI+Txns4npB4lK9RnqELy0ss860= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by PR3PR08MB5595.eurprd08.prod.outlook.com (2603:10a6:102:83::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.20; Fri, 23 Sep 2022 16:55:29 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::b480:677a:ac9b:8f24]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::b480:677a:ac9b:8f24%7]) with mapi id 15.20.5654.020; Fri, 23 Sep 2022 16:55:29 +0000 Message-ID: <9e752a96-e578-6641-19b9-7de75137fb22@arm.com> Date: Fri, 23 Sep 2022 17:55:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v5 0/3] DynamicTablesPkg: _CPC support To: Jeff Brasen , devel@edk2.groups.io Cc: ardb+tianocore@kernel.org, Alexei.Fedorov@arm.com, pierre.gondois@arm.com, nd@arm.com References: From: "Sami Mujawar" In-Reply-To: X-ClientProxiedBy: LO2P265CA0506.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:13b::13) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|PR3PR08MB5595:EE_|AM7EUR03FT014:EE_|AS2PR08MB9151:EE_ X-MS-Office365-Filtering-Correlation-Id: 30cb89ed-5184-437b-94fd-08da9d847413 X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: 4b4iYB1N+p7jmxOdoPBzFDxPERwHgq33iWXr/4z9eRQx7ECkDmqFu7epiW7P7IAokM0qQXTAMmbmmiBrIqr4WbK27mcMUDz+d1+/L7Nia1Z+3QtXqHakf4XCDkf7QQfw9eOtiW20yX4aP0nmGLYtkbHAdYLK44AOgprdadC3xKG86f1gqyNal3kpUbkvOIr8gq9IN8CNV3QvYwN2fa0M4MbFROPdUrKgHY3y7Rt8rTSDkNdSPHPbsvpGUgrqoR4jZzYF8RLDHBsDafq+qui1mSv8kxE83ocLsmHy594/d+qbK/m6NzoV9+qXAXEHQ87diXMT8ioe+6QbyET26gQmCHf96GXEDPy7uS5ZuJ4O7Q1GeHpXU7Vc96DYfVkltc+d7Gr2conMlUFA8s5wto9+VPMqbZTzjWoC3T/rD64szp6E2kl79ZnPAfGwZ0/zbDG+zGDDLfpLzkoGQJQnB7BsARk2eOvjJYOGsFZPDzMwXJBp41d+NGSPOZa3syA1IQvieXG0gaH2A6UpozRXYOQVdUFAC+p1aLiZObhnutHb7b3WgNcyzFjuvE6OCcL4Sb9/rA4L3UhBX9lbbEwrC9/wxmErkiL8UkVLj3QGajAv/8xyLW0OmIlKhgkUpTd6n04XPNlSA2Xt2ScR3bfV0dxQiA9KQ29+LKPGtDLmq4ZjahbT/b+wJWC5+GpE/pkdrOlsUg1WWvVbGvhAQQs4qhfhrQBL/NQZDB1rBbMgd8ktYHvn/Xgr6N+KjjttLuv3PZga71jrzEuKYyuLiOii4wOSgWjF/ivdX3kc59lfbK3xnmR+oMneietrOSEpaCZxp8+wsM5I8+rH72yP7GBGwVqk16EeONlj7zzPQ6NpMAemzyU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(396003)(346002)(136003)(376002)(366004)(39860400002)(451199015)(8936002)(66946007)(66476007)(66556008)(38100700002)(4326008)(36756003)(86362001)(31696002)(2906002)(44832011)(5660300002)(53546011)(478600001)(6506007)(6512007)(2616005)(186003)(83380400001)(6486002)(8676002)(26005)(41300700001)(966005)(316002)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR08MB5595 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 9330a637-a311-4fcd-c077-08da9d846b8d X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MuM3Z/MaGyfRv/13FOS6rUU4iNEIBd68F3uQ6kQHagJaoRHMMti6KBrZYNF28Jhs9bp7lf2NyO886He7Mxj8p9jgUEpVPHeKpfNXb6U4Bi0/9wbov4S82E4H4aWpFbFSraxRhh7xSn2f/5MTt2/HUypEdRGsT6W3SyOw2drAXV76unCJVIwWPcQQFA01NRlQEyKg2QSpK1qrV5SgL0T9uS3QyIwVEUOLKr+y0lz75SbriNKMTLt8balyVI4eImDS0aJhuO98l7KxnlkYhRP2hrYuaNJnIRSm3OpqEf+XsEqeUEy+1MPDITtmNiKyObAVUcMCv4J8jgQAPPwbQx8Nqdc77CO+A/YIrVazEXbw3uEaMmAnlI5cqTh93LU+XP3hVQ5y1mzpjJpEtgAIhtELp0wFZW155N7NZUGLs5IxeH3PV8pEWhm98RWN/QXPcmMcdSyn8gp3tTvcSHT6q36uKfP069hvl3Uhw7KCEZvyx8TOXBIFKB6B86TtVMliaNnORHfpVjBcAXPXsnI4v308K03parJsAOmsl0yWgxNqYOcSsED5pb0PB0RAJf5oTEGn8jJ+rmd8QEbEhUgSH9xPFJMI+Dp1fCVEoNQpHTSWijHKYYWkUlnPxrgp6YOpWdXfHUrWCZiUq3hyk7JDJUIe7ceFQ/B/Tsmk+uy4GZJiVwgReN0xCx0Ds8EIbmZLKih/eGarrEFTkG8FB7GShIOQpQnQcs71v5/uVgOzsvtFcd8Vt5yFtbj7pD64Zmn6jF0fzWd4rIb/miy8vtcBggvKzstMXC3W/JyL3+lHCPwmq+yqtb45rHQ1lFC35OIis2ypGhTII/LqwUsJ4IuFCeVpor5hDBu5BhN3WSmTUeso3vXHbijRMPAdt4okl7NRALA5 X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(136003)(396003)(376002)(39860400002)(451199015)(36840700001)(46966006)(40470700004)(966005)(186003)(40480700001)(6486002)(2616005)(83380400001)(53546011)(26005)(6506007)(6512007)(44832011)(336012)(2906002)(82310400005)(40460700003)(70586007)(478600001)(70206006)(316002)(47076005)(8676002)(4326008)(8936002)(41300700001)(5660300002)(356005)(82740400003)(86362001)(36860700001)(31696002)(36756003)(81166007)(31686004)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Sep 2022 16:55:43.4405 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 30cb89ed-5184-437b-94fd-08da9d847413 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT014.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9151 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jeff, Thank you for the updated patch series. I have made some minor changes: 1. Move DynamicTablesPkg/Include/Library/AmlCpcInfo.h to DynamicTablesPkg/Include/AmlCpcInfo.h to stop edk2 CI from complaining. 2. Minor update to the documentation for CpcToken in CM_ARM_GICC_INFO. I have scheduled a pull request (https://github.com/samimujawar/edk2/pull/new/REVIEW_2369_dynamic_cpc_support_v5) for checking that edk2 CI is happy with the changes. Please let me know if you are ok with the above changes, and I will push these changes. For this series: Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 22/09/2022 09:36 pm, Jeff Brasen wrote: > Add generator for creating the _CPC object for CPU nodes. > > If viewing this review by a pull request is helpful one exists here: > https://github.com/NVIDIA/edk2/pull/12 > > Change Log: > v1 - Initial Revision > v2 - Added revision to object, improved error handling, changed to ACPI 6.4 structures. > v3 - Minor review feedback > v4 - Convert CpcInfo to structure and use that for APIs > v5 - Cleanup parameter checks, add token to parser > > Jeff Brasen (3): > DynamicTablesPkg: Add CM_ARM_CPC_INFO object > DynamicTablesPkg: AML Code generation to add _CPC entries > DynamicTablesPkg: SSDT CPU _CPC generator > > .../Include/ArmNameSpaceObjects.h | 60 ++- > DynamicTablesPkg/Include/Library/AmlCpcInfo.h | 124 +++++ > .../Include/Library/AmlLib/AmlLib.h | 54 ++ > .../SsdtCpuTopologyGenerator.c | 133 ++++- > .../Common/AmlLib/CodeGen/AmlCodeGen.c | 475 ++++++++++++++++++ > .../ConfigurationManagerObjectParser.c | 115 ++++- > 6 files changed, 921 insertions(+), 40 deletions(-) > create mode 100644 DynamicTablesPkg/Include/Library/AmlCpcInfo.h >