public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Lendacky, Thomas via groups.io" <thomas.lendacky=amd.com@groups.io>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: devel@edk2.groups.io, Paolo Bonzini <pbonzini@redhat.com>,
	Michael Roth <michael.roth@amd.com>,
	Jiewen Yao <jiewen.yao@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Laszlo Ersek <lersek@redhat.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Min Xu <min.m.xu@intel.com>, Erdem Aktas <erdemaktas@google.com>,
	Oliver Steffen <osteffen@redhat.com>,
	Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [edk2-devel] GuestPhysAddrSize questions
Date: Mon, 4 Mar 2024 11:23:53 -0600	[thread overview]
Message-ID: <9e7e617c-d398-81b4-2c92-6b3a092e354c@amd.com> (raw)
In-Reply-To: <sts2yiwovw2bzkpun4mwmrfgylcwqvw2b3g6vi6lhtiskwcd3o@2yte7farelgu>

On 3/4/24 07:09, Gerd Hoffmann wrote:
>    Hi,
> 
>>>     23:16 GuestPhysAddrSize Maximum guest physical address size in bits.
>>>                             This number applies only to guests using nested
>>>                             paging. When this field is zero, refer to the
>>>                             PhysAddrSize field for the maximum guest
>>>                             physical address size. See “Secure Virtual
>>>                             Machine” in APM Volume 2.
> 
>> I believe the main purpose of GuestPhysAddrSize was for software use (for
>> nested virtualization) and that the hardware itself has always returned zero
>> for that value. So you should be able to use that field. Adding @Paolo for
>> his thoughts.
> 
> Posted patches for kernel
> https://lore.kernel.org/kvm/20240301101410.356007-1-kraxel@redhat.com/
> and qemu
> https://lore.kernel.org/kvm/20240301101713.356759-1-kraxel@redhat.com/
> (sorry forgot to Cc you).
> 
> Reviewers mentioned this is meant for nested guests, i.e. (if I
> understand this correctly) the l0 hypervisor can use that to tell
> the l1 hypervisor what the l2 guest phys-bits should be.
> 
> Is this nested virtualization use documented somewhere?  Tried to
> search for GuestPhysAddrSize or Fn8000_0008_EAX in APM Volume 2,
> found nothing.

Right, and I don't think you'll see anything added to the APM that will 
state how it can be used by software. The APM is an architectural 
definition and won't talk about hypervisors and using nested paging, etc.

> 
> Is there any case where the phys-bits limits for an l1 guest and
> l2 guest would be different?

I haven't really thought about this before and all the implications that 
may or may not be in play, so I don't think I can really answer that.

Thanks,
Tom

> 
> thanks & take care,
>    Gerd
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116332): https://edk2.groups.io/g/devel/message/116332
Mute This Topic: https://groups.io/mt/104510523/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2024-03-04 17:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-22 10:54 [edk2-devel] [PATCH v4 0/3] OvmfPkg: Add support for 5-level paging Gerd Hoffmann
2024-02-22 10:54 ` [edk2-devel] [PATCH v4 1/3] MdeModulePkg/DxeIplPeim: fix PcdUse5LevelPageTable assert Gerd Hoffmann
2024-03-01 12:44   ` [edk2-devel] 回复: " gaoliming via groups.io
2024-02-22 10:54 ` [edk2-devel] [PATCH v4 2/3] MdeModulePkg/DxeIplPeim: rename variable Gerd Hoffmann
2024-03-01 12:44   ` [edk2-devel] 回复: " gaoliming via groups.io
2024-02-22 10:54 ` [edk2-devel] [PATCH v4 3/3] OvmfPkg/PlatformInitLib: add 5-level paging support Gerd Hoffmann
2024-02-22 11:24   ` [edk2-devel] GuestPhysAddrSize questions (was: Re: [PATCH v4 3/3] OvmfPkg/PlatformInitLib: add 5-level paging) support Gerd Hoffmann
2024-02-22 15:44     ` [edk2-devel] GuestPhysAddrSize questions Lendacky, Thomas via groups.io
2024-02-22 16:13       ` Paolo Bonzini
2024-02-22 17:39         ` Paolo Bonzini
2024-03-04 13:09       ` Gerd Hoffmann
2024-03-04 17:23         ` Lendacky, Thomas via groups.io [this message]
2024-03-06 22:45           ` Paolo Bonzini
2024-02-27 12:54 ` [edk2-devel] [PATCH v4 0/3] OvmfPkg: Add support for 5-level paging Laszlo Ersek
2024-02-29 10:16 ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e7e617c-d398-81b4-2c92-6b3a092e354c@amd.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox