From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web09.11280.1582877166653211818 for ; Fri, 28 Feb 2020 00:06:06 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AB5e7Abe; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582877165; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vVg7l3aOuTtQvxiqtCyUCGihppUujv6nDvLi1nBUO0M=; b=AB5e7Abeh46ofytDP9lTRWFxsbOjKTMlA0GuemE7M9c/kGVx5RxWfNemkxUhT3SjfgoFeU DT8mCmKQcNcOr1rk/5+7pvygxWNrI5RifR6gcxu+TVDjcncskUngQN2JISmIOkGWpo5vvz u+dq1e9NRrx5CijaY98Cy8AWxtG3r+w= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-411-GAGV7lahMZOmRHbhzTyboA-1; Fri, 28 Feb 2020 03:06:04 -0500 X-MC-Unique: GAGV7lahMZOmRHbhzTyboA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B0ECD107ACC7; Fri, 28 Feb 2020 08:06:02 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-243.ams2.redhat.com [10.36.116.243]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3D8E8101D48A; Fri, 28 Feb 2020 08:06:01 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 00/13] OvmfPkg: Support booting from Fusion-MPT SCSI controllers From: "Laszlo Ersek" To: devel@edk2.groups.io, nikita.leshchenko@oracle.com Cc: liran.alon@oracle.com, aaron.young@oracle.com, jordan.l.justen@intel.com, ard.biesheuvel@linaro.org References: <20200226164151.125182-1-nikita.leshchenko@oracle.com> Message-ID: <9e9a83fb-796a-e9fc-57c0-8b0d90f4259c@redhat.com> Date: Fri, 28 Feb 2020 09:06:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 02/28/20 08:51, Laszlo Ersek wrote: > On 02/26/20 17:41, Nikita Leshenko wrote: >> This series adds driver support for: >> - LSI53C1030 >> - SAS1068 >> - SAS1068E >> >> These controllers are widely supported by QEMU, VirtualBox and VMWare. This work >> is part of the more general agenda of enhancing OVMF boot device support to have >> feature parity with SeaBIOS. >> >> We have also developed support for PVSCSI which we will submit in a separate >> patch series. >> >> I pushed a copy of these patches to https://github.com/nikital/edk2/tree/mptscsi >> >> v1->v2: >> - Map() DMAed buffers >> - Fixed various code convention issues >> - Newer debug macros >> - Updated INF version > > General comments: > > [...] (6) Please run "BaseTools/Scripts/SetupGit.py" in your local edk2 clone, before future postings. That will help for example with: - generating diff hunks in the preferred file order (based on "BaseTools/Conf/diff.order"), - generating function names and section names into the @@ hunk headers (based on "BaseTools/Conf/gitattributes" and the xfuncname setting). Thanks Laszlo