From: Laszlo Ersek <lersek@redhat.com>
To: Paulo Alcantara <pcacjr@zytor.com>, edk2-devel@lists.01.org
Cc: Hao Wu <hao.a.wu@intel.com>, Ruiyu Ni <ruiyu.ni@intel.com>,
Eric Dong <eric.dong@intel.com>, Star Zeng <star.zeng@intel.com>
Subject: Re: [PATCH] MdeModulePkg/PartitionDxe: Fix UDF fs access on certain CD/DVD medias
Date: Fri, 13 Oct 2017 15:37:25 +0200 [thread overview]
Message-ID: <9ea64e48-25e1-f978-e1b1-c70a0b46e7dd@redhat.com> (raw)
In-Reply-To: <a05cba4ef156aba5afab6fafe32f478fbd765a5d.1507900772.git.pcacjr@zytor.com>
Hi Paulo,
On 10/13/17 15:24, Paulo Alcantara wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=725
Thank you for the patch. Some meta comments:
When you post a patch for a TianoCore BZ, can you please
(1) flip the TianoCore BZ in question to status IN_PROGRESS,
(2) add a comment to the BZ, with a link to the patch in the mailing
list archive <https://lists.01.org/pipermail/edk2-devel/> -- in this
case, the link would be:
https://lists.01.org/pipermail/edk2-devel/2017-October/016031.html
(3) optionally, assign the BZ to yourself?
In particular step (2) is very helpful when a BZ takes several
iterations of a patch set, and later someone would like to review the
evolution of the patches.
(It's not necessary to comment at length in the BZ about the patch set
versions -- that's what the patch set cover letters are for --,
capturing the archive links is enough and helpful.)
Finally, when the patch is applied and the BZ is fixed, it's best to:
(4) kick the BZ to RESOLVED|FIXED, and
(5) add a comment about the git commit hash of the patch.
Thanks!
Laszlo
next prev parent reply other threads:[~2017-10-13 13:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 13:24 [PATCH] MdeModulePkg/PartitionDxe: Fix UDF fs access on certain CD/DVD medias Paulo Alcantara
2017-10-13 13:37 ` Laszlo Ersek [this message]
2017-10-13 13:49 ` Paulo Alcantara
2017-11-14 7:48 ` Wu, Hao A
2017-11-15 12:45 ` Wu, Hao A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ea64e48-25e1-f978-e1b1-c70a0b46e7dd@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox