From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (NAM02-SN1-obe.outbound.protection.outlook.com [40.107.96.45]) by mx.groups.io with SMTP id smtpd.web10.71684.1680531856171238161 for ; Mon, 03 Apr 2023 07:24:16 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@amd.com header.s=selector1 header.b=3kuL0q5H; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.96.45, mailfrom: thomas.lendacky@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T0+pqYhPrmOIAnI61XRM9Hcc1BLs/LlwEvLaTZsZCPalt+sHiqxLsFxgQrNxvztAsflILEdoCYY5RxpiIOg+Qn0s2hK20QFwKrJGD+KF2CZ6PYhUsj37TlOJ3rrcKjjndvMeqfBMcl82TT9P1rSHUIvsjKE0Oc1zOVFHmnoaShQGYmQ8yFtbKy02SWUTnXgLLfwUJWGrdYpuWN74aAIpelD723fa5SnOEySazzb+O6cunNnEl2Mk13/WmZWZjoc9lx4wszhUQo5MOxPragMi1PYPXdk1HRRavE0W8+sqJNxMG/UJnL1Fz9SUWwPDpDF+2Gc1DcXMRUDlRW47rQx6Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/VbmrsrcmQGX3twV/3r3ICRsp0Qd2o8G3CNAxzlhpDg=; b=hrUrYmnjMKrpAkDkmR21LevMnxD2kfhEIPAe/uNSBdXs9Ah3DykaRMk3ZkWJFLiR1TpOr7MfFdUTOOTNwhJcvk2Z/dioZYHqKrfIX8H3aHLTt44VjrkNwhdFYIqMwy1blEKIDx46UHn10y1vE/uTcGxNofcw37OmmPgX1QzXh0kiTA/P0jS7yL9YH1y8h7X4DdWoeflKp4x8ZdP9SKilzj5oBh061bc1BpK5p7M/ldGHqEDaaY7vYVrQJ0/R5Cg6foZ6obqufxFJcXEP7P9wHAcZq7OaNnRlxR4XX+DhhCkv/3FD1QV8+ivOpZMdjl75oHZvYHcA0YrjMNFinylEEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/VbmrsrcmQGX3twV/3r3ICRsp0Qd2o8G3CNAxzlhpDg=; b=3kuL0q5HQ6U7Szf5iqhG/umTDbjA7ODz2HbCJpJuRMN5oRT1pxhlAEOLYeFdZ+fTIHMRMMmKXilhRIp+5KP9QQTNDq8km3GmHziyjrf2O4RMt9ImNmWkZxg28cb3MjmhRhkz1rv5iFvYds2DT3wRJTd/hZbPYJ3wnjBmOmKkmvw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) by SA0PR12MB4431.namprd12.prod.outlook.com (2603:10b6:806:95::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Mon, 3 Apr 2023 14:24:13 +0000 Received: from DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::5b56:bf13:70be:ea60]) by DM4PR12MB5229.namprd12.prod.outlook.com ([fe80::5b56:bf13:70be:ea60%5]) with mapi id 15.20.6254.033; Mon, 3 Apr 2023 14:24:13 +0000 Message-ID: <9ecca246-63db-2cd1-212d-7801deb3b27c@amd.com> Date: Mon, 3 Apr 2023 09:24:11 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [edk2-devel] [Patch V2 0/8] Create page table by CpuPageTableLib in DxeIpl From: "Lendacky, Thomas" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Ni, Ray" References: <17517763F19F09A0.27612@groups.io> <0b8cbd21-9c80-26cf-8934-c4df9158441d@amd.com> In-Reply-To: <0b8cbd21-9c80-26cf-8934-c4df9158441d@amd.com> X-ClientProxiedBy: CH0PR08CA0021.namprd08.prod.outlook.com (2603:10b6:610:33::26) To DM4PR12MB5229.namprd12.prod.outlook.com (2603:10b6:5:398::12) Return-Path: Thomas.Lendacky@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB5229:EE_|SA0PR12MB4431:EE_ X-MS-Office365-Filtering-Correlation-Id: c7129bc4-1764-4632-d0e8-08db344f196c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: plC45Dd82ESQ5KlcpsPJV0pbis5tmAo3fjtEr6hANXJHdo+tnWKudlpujj133Pxm5HUnC/H9UhBeLYcVKGsykFEC6/V8OFNbNxZzknuqIvnjtQxebpRBia1p6fhYmCvT9cGbS3PZhJRho4OdNtSumFlYGywLGL9gmbJDUm15GMd8LGVI6PvAMZshLiY3+8xCvtHEVqDAyJO1qFvZC4fzcEiaHPRIoh8IbBbgaKBRI2TsmgxxnYwXKm7Y05808FdRqVJzet5pYdo89OidtWeTu5OXEKL5WuguxVk9Ht5juNHUKzebrh+2ew8L+/xgoh+hKBkhf0dysZmUWG9SKaTbNozGc5DCE5QXWW2lfmO9juZi5t8ilu1sk9vzBEPeFQDVg0H5sr9CteRLFrWS5LGc8Yf5NSKBiVxvtqR2JW165oUsZC+KRBPPrOOb+ankWMUb9YDWcJV926Z3Ah77JUIO+oTAdR4PU2eAQUHEuzM/63TXcS5aWvgpjMvb1NNtgfueXXp8Mde61oi6JKPQoA1k3Au5S6CyG+DuGBJuCxgf2rgp8YIu6yLgZlBZHJ9HgdO3bOu2Gp+vwy0HWc/oNEWZmCBTU8Awyr2z9xDEUbZD1+6/9VbN9kdr16d4HycIA9K9 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5229.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(396003)(346002)(136003)(366004)(39860400002)(451199021)(38100700002)(5660300002)(2616005)(83380400001)(31696002)(110136005)(316002)(6486002)(966005)(186003)(478600001)(86362001)(53546011)(6506007)(26005)(6512007)(19627235002)(36756003)(41300700001)(8676002)(4326008)(8936002)(66476007)(66946007)(66556008)(2906002)(31686004)(66899021)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lGBSGM09NhlMhCrrXt7Yh+F9WBxium5wfP9o1TzRNr1/tIe5BL7EXvWTRfCt?= =?us-ascii?Q?BIy0hIkKjOLpXe+nwiRvD4hxBTT6C9xTD3zTbv0SODLKuBnlGFQdy/vY47Nq?= =?us-ascii?Q?Acmrs3Pl3LHcHfPeTywfiCw6Xd7SkYKEKMEkPI183v7p7GxBAeE/UAdGw/gL?= =?us-ascii?Q?F/YaPrihkQ9yB2wuFAze+SPd3mSfwQXWWp38t1y32ZWYtof1nrjY42KfBTWi?= =?us-ascii?Q?C372w4oBBMH4QH9ldbWOhA+Y6AqIYafr/1ywI1uGPU6TXpktYUcZQ1q6yYST?= =?us-ascii?Q?omPlJa0GT7AN1QtvtVmrTgVlIjjbhmLAD88j41XRVehYRvcF1uFyMAQMkpV9?= =?us-ascii?Q?g7oVg2RMTl3tRGi1ZQsWzwh/7j879qS74mY67rVsyfARSYTswYkCW/7M2FyT?= =?us-ascii?Q?zls4TnGJ2vmuvho1dEe3flkEMu9F+bWIYQhDqqrQJF0f2ZOUP8HQZ2XFvn9S?= =?us-ascii?Q?YPIuM3g8D0OzPQddz9+uHfw/nLEp/61jaSrkukUgpvZ/iIChWaK32ABQc94t?= =?us-ascii?Q?A2uDLKLRRXoV6JyXCmWtjjhf8IDWgrA7vXRJvWbNsJ3bLl1lZdIghGhVcg/D?= =?us-ascii?Q?S6uEJVDO85EHjOEi9Hk43s/5fo/ifsK+XIkKCH04460BdsL+AUT4FqB6x1VZ?= =?us-ascii?Q?4DyCaTFBqtVyV5HUAJN0NspK9OXvZWZf5cpiJV+gqVk9z1QMNNwH/LNVs4E5?= =?us-ascii?Q?EKSbBebclcBtgro7lzSrg3N9O6yL00881UzYcTClT8Frx6KkyKcNWtOt1xbG?= =?us-ascii?Q?MmICJZMviqgkiaDlh9tzh+KGpkaT0tMyVMpax1qmYpp3WHOIVB0ZnRtfHC8n?= =?us-ascii?Q?2egf4XSDGIlpIQ40iuaM1mTlNllpNCzfzAWrnrRjvWSwOcrW4X1sgmXZWQfi?= =?us-ascii?Q?rLD6II3pwJ8vHzFExv4wW/+kT6IUJNYF2XcxTGQ2OTmCi5NRfOdvaeI/RIIC?= =?us-ascii?Q?nIJP9ibnw9r/adsJlvwLAUHWCtfYIv+HH1aSYWWQiZ84rM6Gtj6/xy+pjEiy?= =?us-ascii?Q?sOT/lMGGbLaMAVl4Sus0s+mw+JdXm2VA3m0u8DrBwiuoqJdMajEKLz9yshAE?= =?us-ascii?Q?3zJD/k3nCzm8fqUiRMUHj2boRZwRWpK1pUpXJWVyna++M1hoL4BYPkA7Lggy?= =?us-ascii?Q?tFDa1fTzkvn22NLoy3NtCWwG4ZqSJYOt8GRy6y36Q4JTLLsa9rXg98eMUbtl?= =?us-ascii?Q?N1QXzbyOZ8gWA5qFevcu5YFV8KQvsz2sJR6T7U+Zbjuld8P4x2V/kkH1iy6O?= =?us-ascii?Q?5yRrKT/QkF5SxxCxoXFe5UUv7ECEXrZNLU4WYWHnU0qx9jCUGiWnfP00MfEf?= =?us-ascii?Q?WSBhYGJOzeMN1cS7yZoVKYfXz2Fw91qJSmZZI1s+XS/9nLzB3oc5UoV2CE/O?= =?us-ascii?Q?uHL/ZTHvS3HGB+b7TMnBrvhrSmLnXSO8PffjkOC8QQj8aHa4hfsCETpowAXX?= =?us-ascii?Q?3LJUYhi0086U7yA3dDqBz0UMuN2TTZVabDgjonB8NQzayCDw775v54DZnDOk?= =?us-ascii?Q?01mYzXb9ApA+/XHVhRfNKuDTrmyKmjYR/Fjo0gmRxhzxy7pepkw7X3ORR3Xl?= =?us-ascii?Q?inicR4CXyznSWOy++C5fuh6XsVWN6TutwzwYo4LD?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: c7129bc4-1764-4632-d0e8-08db344f196c X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5229.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2023 14:24:13.7583 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dXzY+ISvV5NDc2wh0gcfObwmFSfxGbXRFaXYuDSF384tvEiL86XK3M+7nULcOA67VfCS40BaNeoSnaFE0XM3eg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4431 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 3/31/23 09:35, Tom Lendacky wrote: > On 3/31/23 04:41, Tan, Dun wrote: >> Hi Tom, >> >> Reccentlly I sent this patch set to change DxeIpl code to use=20 >> CpuPageTableLib to create page table. I have done some test on Intel CPU= =20 >> to make sure that the page table created by DxeIpl before the change is= =20 >> the same as the page table created by DxeIpl after the change. But there= =20 >> was a remaining case that I didn't cover. The case is that=20 >> PcdPteMemoryEncryptionAddressOrMask, PcdGhcbBase and PcdGhcbSize are not= =20 >> zero(when memory encryption is enabled on AMD processors supporting the= =20 >> SEV feature). >> So could you please help do a test on AMD processor to make sure that=20 >> the SEV feature still works good with this pacth set? >=20 > Yes, I can test it. This is breaking the SEV-ES and SEV-SNP boots. I'll see if I can figure=20 out what or where the breakage is, but this patchset can't be merged as is. Thanks, Tom >=20 > Thanks, > Tom >=20 >> >> Thanks, >> Dun >> >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of duntan >> Sent: Friday, March 31, 2023 5:34 PM >> To: devel@edk2.groups.io >> Subject: [edk2-devel] [Patch V2 0/8] Create page table by=20 >> CpuPageTableLib in DxeIpl >> >> In this V2 patch set: >> 1.Remove the unneeded patch for ArmVirtPkg 2.In this patch 'Create page= =20 >> table by CpuPageTableLib', change the input parameter name from=20 >> Is32BitPageTable to Is64BitPageTable and add a line of=20 >> "MapAttribute.Bits.Present =3D 0" before set a range to non-present. >> 3.In this patch 'Refinement to the code to set PageTable as RO', add a= =20 >> line of "MapAttribute.Bits.ReadWrite =3D 0" before set a range to ReadOn= ly. >> >> Dun Tan (8): >> =C2=A0=C2=A0 EmulatorPkg: Add CpuPageTableLib required by DxeIpl in DSC >> =C2=A0=C2=A0 IntelFsp2Pkg: Add CpuPageTableLib required by DxeIpl in DSC >> =C2=A0=C2=A0 MdeModulePkg: Add CpuPageTableLib required by DxeIpl in DSC >> =C2=A0=C2=A0 OvmfPkg: Add CpuPageTableLib required by DxeIpl in DSC file >> =C2=A0=C2=A0 MdeModulePkg: Add UefiCpuPkg.dec to pass DependencyCheck >> =C2=A0=C2=A0 MdeModulePkg/DxeIpl: Create page table by CpuPageTableLib >> =C2=A0=C2=A0 MdeModulePkg/DxeIpl: Remove duplicated code to enable NX >> =C2=A0=C2=A0 MdeModulePkg/DxeIpl: Refinement to the code to set PageTabl= e as RO >> >> =C2=A0 EmulatorPkg/EmulatorPkg.dsc=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 |=C2=A0=C2=A0 3 ++- >> =C2=A0 IntelFsp2Pkg/Tools/Tests/QemuFspPkg.dsc=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 3 ++- >> =C2=A0 MdeModulePkg/Core/DxeIplPeim/DxeIpl.h=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 3 ++- >> =C2=A0 MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 4 +++- >> =C2=A0 MdeModulePkg/Core/DxeIplPeim/Ia32/DxeLoadFunc.c=C2=A0 | 112=20 >> ++++--------------------------------------------------------------------= ---------------------------------------- >> =C2=A0 MdeModulePkg/Core/DxeIplPeim/X64/DxeLoadFunc.c=C2=A0=C2=A0 |=C2= =A0=C2=A0 5 +++-- >> =C2=A0 MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.c | 711=20 >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= ++++++++++++---------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= ---------------------------------------------------------------------------= --------------------------------------- >> =C2=A0 MdeModulePkg/Core/DxeIplPeim/X64/VirtualMemory.h | 182=20 >> ++++++++++--------------------------------------------------------------= ---------------------------------------------------------------------------= ----------------------------------- >> =C2=A0 MdeModulePkg/MdeModulePkg.ci.yaml=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 = 5 +++-- >> =C2=A0 MdeModulePkg/MdeModulePkg.dsc=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 |=C2=A0=C2=A0 3 ++- >> =C2=A0 OvmfPkg/AmdSev/AmdSevX64.dsc=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 |=C2=A0=C2=A0 2 +- >> =C2=A0 OvmfPkg/Bhyve/BhyveX64.dsc=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 3 ++- >> =C2=A0 OvmfPkg/CloudHv/CloudHvX64.dsc=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= |=C2=A0=C2=A0 2 +- >> =C2=A0 OvmfPkg/Microvm/MicrovmX64.dsc=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= |=C2=A0=C2=A0 2 +- >> =C2=A0 OvmfPkg/OvmfPkgIa32.dsc=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 3 ++- >> =C2=A0 OvmfPkg/OvmfPkgIa32X64.dsc=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 2 +- >> =C2=A0 OvmfPkg/OvmfPkgX64.dsc=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 2 +- >> =C2=A0 OvmfPkg/OvmfXen.dsc=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 |=C2=A0=C2=A0 2 +- >> =C2=A0 18 files changed, 200 insertions(+), 849 deletions(-) >> >> --=20 >> 2.31.1.windows.1 >> >> >> >>=20 >> >>