From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120])
 by mx.groups.io with SMTP id smtpd.web12.12362.1600173290038878193
 for <devel@edk2.groups.io>;
 Tue, 15 Sep 2020 05:34:50 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=de2j1rCK;
 spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1600173289;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=cw2tq1XdcAbdy0lbZQLTtJ13Nza+JNJPKOPt5eeVjas=;
	b=de2j1rCKszzgvS7+1/xjtGuLrtYD657KablxGbmWtem2abvHGCna3EwTARfpxRNuoe9Km6
	5FWRtw2M7EE1lXRUKEKfA/ShQkCKpTX93gr5MxFhkwWLBHS6nrrHPBArMbpXwPCeszzWaS
	zB9muNOgQnwrHWbDWcYGIUzOpHcd7Q8=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-270-zQqNzlVsOgqjmeZ5k6k_AA-1; Tue, 15 Sep 2020 08:34:45 -0400
X-MC-Unique: zQqNzlVsOgqjmeZ5k6k_AA-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9B57ACD040;
	Tue, 15 Sep 2020 12:34:43 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-53.ams2.redhat.com [10.36.112.53])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 129C07EB74;
	Tue, 15 Sep 2020 12:34:40 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH v2 1/2] MdeModulePkg: Fix OptionROM scanning
To: Anthony Perard <anthony.perard@citrix.com>, Julien Grall
 <julien@xen.org>, Rebecca Cran <rebecca@bsdio.com>,
 Peter Grehan <grehan@freebsd.org>
Cc: devel@edk2.groups.io, marcello.bauer@9elements.com,
 Patrick Rudolph <patrick.rudolph@9elements.com>,
 Christian Walter <christian.walter@9elements.com>,
 Hao A Wu <hao.a.wu@intel.com>, Jian J Wang <jian.j.wang@intel.com>,
 Ray Ni <ray.ni@intel.com>
References: <20200915122616.17196-1-marcello.bauer@9elements.com>
 <20200915122616.17196-2-marcello.bauer@9elements.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <9eef3270-3ec3-5c15-9e2a-431c039879fd@redhat.com>
Date: Tue, 15 Sep 2020 14:34:40 +0200
MIME-Version: 1.0
In-Reply-To: <20200915122616.17196-2-marcello.bauer@9elements.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0.002
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US

Anthony, Julien, Rebecca, Peter,

FYI:

On 09/15/20 14:26, Marcello Sylvester Bauer wrote:
> From: Patrick Rudolph <patrick.rudolph@9elements.com>
> 
> The Option ROM scanner can't work as enumeration was done by the
> first stage bootloader. Running it will disable the ability of the
> PCIPlatform code to scan for ROMs.
> 
> Required for the following patch that enables custom Option ROM
> scanning using gPciPlatformProtocol.
> 
> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> Signed-off-by: Marcello Sylvester Bauer <marcello.bauer@9elements.com>
> Cc: Patrick Rudolph <patrick.rudolph@9elements.com>
> Cc: Christian Walter <christian.walter@9elements.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> ---
>  MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> index 6c68a97d4e46..7420f0079f7d 100644
> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> @@ -2530,10 +2530,12 @@ PciEnumeratorLight (
>        //
>        RemoveRejectedPciDevices (RootBridgeDev->Handle, RootBridgeDev);
>  
> -      //
> -      // Process option rom light
> -      //
> -      ProcessOptionRomLight (RootBridgeDev);
> +      if (!PcdGetBool (PcdPciDisableBusEnumeration)) {
> +        //
> +        // Process option rom light
> +        //
> +        ProcessOptionRomLight (RootBridgeDev);
> +      }
>  
>        //
>        // Determine attributes for all devices under this root bridge
> 

I suggest checking the effects of this patch on Xen and bhyve.

Thanks
Laszlo