From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.118]) by mx.groups.io with SMTP id smtpd.web11.70250.1684083716348107645 for ; Sun, 14 May 2023 10:01:56 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@amperemail.onmicrosoft.com header.s=selector1-amperemail-onmicrosoft-com header.b=t2SOD6hU; spf=pass (domain: os.amperecomputing.com, ip: 40.107.92.118, mailfrom: tinhnguyen@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PZIFdDeUZRDJLV56kuR/FYTPCbcE6lyEfEjD3NMFuV+rNRYWSH2PY2WOQ41GaNbUpjimGS/qHwvOBWl2WSYfFc2SLZL9FDCB67tDZ1eCO/GE2uCAW0CyGf7tNhbanKcOTw8FLRXBKqF1dIBQmiVih/MH50E9mAqKUMygf2rM5z1n+wfcLTXz0SL8M21mjnmNWdYgT/IpZNSCofC13Ey7pmwuiS8scArCG80Y3Y7B7PodG7jdpTYFbX8NweNRMC0HxK9U/xN0xh30coFaH1er0Pwmuous5+ta+eo54KGub5nc/k4VjYnc4PFZAFHqyn8gmjoXDrIo66lk0Wo7sc12qg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4ub/YbgdLgUgF0CRRAof7b4jaj1x/gAzTuMdt+kfumA=; b=WZeZ5uLT3BEKITZJFcUmmQnLRujHs/2mSqSucxSPCKyF/z9wKMJmo0TNcy02ty3Em0wt9JqXLyzYS1eZM4icNjftaCEa0mIFzKymzzClV+mCTp0hq+KK7/t7s13xSFFGTofKWryWXGlmR4K7LZyayBdcoCT7/4t+h/gnrB3YTURs+57ArWrxcaja5W8dKvnYqljHoCJzi8l8+BRVLxwCy1hci3PA1ytLtPcDsQQlamHjAV3uPNgYqiWgCe5Ib/ayh3J2/nOreQqL6taULNLy64Ri0/zb9GHagngFHkcOb13HtGcSIGKWB3xWpkTjofF/J9P7ldj0YAPe25Rw19wuPQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-amperemail-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4ub/YbgdLgUgF0CRRAof7b4jaj1x/gAzTuMdt+kfumA=; b=t2SOD6hU7PgJILgHEzAQw0oej4vi0UfNcbjNgiaaH6muKz+N+UynGc1jTbVRRmyutPtMqb+IBVZXrhbs+ySuidRKlOcP5dkozo8b56/zfyo2+qD182+vYBwW3ITPCiUEVFtXLpgxlmCTYdKp9uaK6+44RXa0pmDWcDJ1pTp8pGE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amperemail.onmicrosoft.com; Received: from DM5PR0102MB3336.prod.exchangelabs.com (2603:10b6:4:9f::11) by DM5PR01MB3228.prod.exchangelabs.com (2603:10b6:3:fc::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.30; Sun, 14 May 2023 17:01:54 +0000 Received: from DM5PR0102MB3336.prod.exchangelabs.com ([fe80::fefc:e2a9:e823:fe42]) by DM5PR0102MB3336.prod.exchangelabs.com ([fe80::fefc:e2a9:e823:fe42%6]) with mapi id 15.20.6387.020; Sun, 14 May 2023 17:01:54 +0000 Message-ID: <9efcf5f6-ee09-b5e6-b2a4-662028387dd5@amperemail.onmicrosoft.com> Date: Mon, 15 May 2023 00:01:47 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [edk2-devel] [edk2-platforms][PATCH 2/2] ManageabilityPkg/IpmiOsWdt: Add to ManageabilityPkg To: devel@edk2.groups.io, abner.chang@amd.com Cc: Isaac Oram , Abdul Lateef Attar , Nickle Wang References: <20230512040649.384-1-abner.chang@amd.com> <20230512040649.384-2-abner.chang@amd.com> From: "Tinh Nguyen" In-Reply-To: <20230512040649.384-2-abner.chang@amd.com> X-ClientProxiedBy: SI1PR02CA0018.apcprd02.prod.outlook.com (2603:1096:4:1f4::7) To DM5PR0102MB3336.prod.exchangelabs.com (2603:10b6:4:9f::11) Return-Path: tinhnguyen@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR0102MB3336:EE_|DM5PR01MB3228:EE_ X-MS-Office365-Filtering-Correlation-Id: 86023ec7-d576-41df-165a-08db549ceb02 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MJvGLuQHTQG4raJnfvoBA/ayxYzitfEO9I9bWgsMK4G4VUQM+W2bngnBKfhhDGUZZ9zihMK6tI2Y/lrIBbttn6wYn5B/3AtTTApzS79cwjxpemhDnGbVAgdtlPoHYPZNb5CWFA57Wmxr/dfX+OrNDd72urU+qOJjnDSFnPXRs/qICN23G7W+ICgMZkm/0zBzturpNhw4HqSoqsQhtSMmktPfxyrggUhPVIQ+BLjayxuB/ayeW7pFwm5/YlGY3iYiI/IDuV3OPnnLaSVNv+6Z7wa30Z/3nokkeSwtxtzvqHtbPEfANnArXSo8n+os9ujCCPXxJmTG7av4gJz6+5C+UGma64BPIjCcE/5Q4x2isHy3h+L1nTcbkZbbjcMrvE0BzyFRt0MBbd1fyONadbQCJLQ210F83ZhZCY49UrrKMacDkCEXdHRyf1FZV56ZkcP5wjeyvB0xGe8R2ekYX70/BIu6h7nDanWKTMFVrKNTdNq1v0ov7hE3WfynNw6TW1tUZJpYb9qzuIo9eTOle/nr7zpHWKXHt1DzdNm2D6BL7OLLT0XIAPDD7C1vUNAt5zCjZAypiqy6gajmSEBXSyBlBUGi52Eddxhb7YzuArZ6VDpqL5KXNAelSjyGwCodyVcx X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR0102MB3336.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(6029001)(4636009)(39840400004)(396003)(376002)(346002)(366004)(136003)(451199021)(54906003)(478600001)(66556008)(66476007)(4326008)(66946007)(6666004)(6486002)(316002)(2906002)(8936002)(8676002)(41300700001)(5660300002)(26005)(83170400001)(31696002)(38100700002)(2616005)(42882007)(186003)(53546011)(6512007)(6506007)(31686004)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eUhjaS9wM0djMkVIcGJUU29CR2I5ZTF1TlVTbmNuRllCTGZUOE5adHZoZzg0?= =?utf-8?B?Y0xtSkc4K0NhUk4yckVWd2MxY25SdXlaM3ZDRGdVZ3h0YS9USHNOck8xK3M2?= =?utf-8?B?ZFpJQk1YdEpaYjREdFJ3cGNaenNiOEpsd0lKZWpDbWV6enltVjdFN010b2NS?= =?utf-8?B?ZWFHcTdNRTY1QitrQ1c2NmFwVEVQemg4ajMxV1J5R3Z6WllnRnNveHhZQ1pp?= =?utf-8?B?Zi9yQ1daaXNCV3dZZ0xXVjZOandlVVVlcTQ2SUxHek80dUtNV1VmcS9KVWM0?= =?utf-8?B?UEVzWTRQWVI2R0FsakgrUzdyYXRSY2l3OE14KzhraXNneHl3cHc0Zk5HMGZx?= =?utf-8?B?Yk1lNy9mUEpxeDlWczNDVnpwanFybzFWUFluSW1SYVhRazV1cXkvVy8wMVhV?= =?utf-8?B?SjM3cWp3cEczU3FDWnRwVnRKdWl4TEk2R3J2bEVmOFpIM01DdUk1NXU2WWNx?= =?utf-8?B?QnFHdXBZTW9DQjVZVUYrYXZ1aW43MG8rWWJrRUJNVm54SHVVWi9SZVV5dSsy?= =?utf-8?B?YkNqaWgzVi91cGJZZXhLMW5PSm1UVXR3T21CY2ovekNmSnBsS0xjei9LMjlp?= =?utf-8?B?ZFo3T202RC9jTk01U0pYUDFPVVZRM21zK3BORHp5aTVQaWpJaUhuTHg5OU95?= =?utf-8?B?bVhhem9KWGt5RkNnZUUrRDMySTVvS3V0Qk8wcEl4eWhzZTN5bU9scjNPUm9w?= =?utf-8?B?M3I2enlValRhWG9xY1dBRFNudXhuSzRpNlF2VVhab2RjaUNML0tKd1diN0Jl?= =?utf-8?B?cHRuSjJ5Wm8xOUplR3NQY1dPN0lCOEo5WFFOTDNJVU10ZVFLSnBTdXFNSldI?= =?utf-8?B?VnJwZ0JxbFRoUUZYL3RkTTZGWXhyUUZOVGE1cVUvN0wrc2tUNldHRTNhREs2?= =?utf-8?B?R0c3eHBWK3h6dmJDeEZXOHZma3NqU2Z5eloxSkxXQjdZeW5ra2R6a1pxb2t4?= =?utf-8?B?aXFlbTNsdUJJVCtJV0VOK2ZobWZBUmhQWXNJeVlTUkNuM2xkMEdhQlNGWFhx?= =?utf-8?B?MDhLRkJ2QUdCWEpSa2hDODFYNmgwc1lWRDVqRWw2Y3BLcENkUGFWQTZSbjk5?= =?utf-8?B?NDNocDVmR3NtTzgxb2FVWks0SzR0WFdPa1JpVTN1QWc2RE1TaXFWSW56cmgz?= =?utf-8?B?YnZYTDRLaVJtU3o5Y3N3WEpWdy8wU2h0dlJJb1FNUE1QVTdmUDV0ODhzbmFJ?= =?utf-8?B?bjErT1lSZURwWmtxMEZXTkRxTys4NVZ6UjNtelArMVI5MlBhMHZGZVhFSDBi?= =?utf-8?B?cHp4Q0ZpeFZTVURtLzB5dTc4UCtYc29SRVVOb1BuN2VaRlZtUldnRUFEbjI1?= =?utf-8?B?WXZxZzNoRytJemY3T3NrdElIdUNpbWgyYmRmcVZSUVVXSGJXV2dOT3AwVDd2?= =?utf-8?B?bXAvQWR2WnpnNERMbDFwbDJNODNxclJQcUQwUGZucWlaMjZEa2gzcFVsSFQr?= =?utf-8?B?aEdIcU1Bdi9neUk4a3FBTTNKZ2Fockw4eU1ienNoVmJDam9jbU5zNURGVGkw?= =?utf-8?B?RXZ4bjN6Z1J1bkl5UHkvekgzdGp1ZnZpSHdCRHZaSlZYQkl6SkljQmpGK0lX?= =?utf-8?B?NEJPRTQvRGdtYnV2N0c4aHNlNTl4Rk11MFN3cjIwRjJPSFhWVU91aFViblhN?= =?utf-8?B?cmhlKzZwbm5Db3VLNnoyS1RDT1ZqL3RycjFRYXRnRGdlQVpwVmE5YUlUZ2U1?= =?utf-8?B?bGJLT2t1M0c4U2ExNFYyK0Nxc1FQeDVVUlRPcHF1ak4zNUUzekE3cE94NmNQ?= =?utf-8?B?WXR2aCswMEwySGdyZk42ME1qTk05bDlxbkZGOTZCeHY5Yys5eER2ejJpNFNv?= =?utf-8?B?NnZsdmp2K05rRkFNMWJFSFdqWHFJNDAzeTFJS2I4OHdCa0NlTWs0d25pOWtv?= =?utf-8?B?eW5qZENmRlIxR21Qb2JZZnVjUE9kamp4TmV5YklSY213Y0FtMzRTOTAyZnY4?= =?utf-8?B?VG95dzRVR1ZwOWxIRXpEeVMvNVhMK3dWNlNQUVRkZE9xVEE0R0RzWWNBNDZs?= =?utf-8?B?dk5idGp5Tkt4MllMT2hDK0RFYVFLYUFSNUdWS3pCVXZwZzlNQkJyK1VUK1hJ?= =?utf-8?B?QzhSekltdzhMRldDSVNmQzFSRkVEdzBZMlVYZHVrU2dMUnZQSTFNWWNnWnpo?= =?utf-8?B?VkROdGc1OHpHZkNXaWpPbitmNkRTcDNVTklYWE9pbXhYNm5zUXJZZXN4cVhs?= =?utf-8?Q?bpC2A0YgGBJQwDFyRpy/uUg=3D?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 86023ec7-d576-41df-165a-08db549ceb02 X-MS-Exchange-CrossTenant-AuthSource: DM5PR0102MB3336.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2023 17:01:54.0743 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pZqBqCdRLlwVFlHomk+JWe5eccBFQxJKH+4X6G6M25KnJzgD/OaSVfHNANflAnGIDqy+RnZ4pJbSX8cGdjOHq2fJD7Oawdzqel2BvuW+OTJlaT1Oo+QbIgEhg3MSQk0i X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR01MB3228 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reviewed-by: Tinh Nguyen Regards, - Tinh On 12/05/2023 11:06, Chang, Abner via groups.io wrote: > From: Abner Chang > > Add IpmiOsWdt to ManageabilityPkg. > > Signed-off-by: Abner Chang > Cc: Isaac Oram > Cc: Abdul Lateef Attar > Cc: Nickle Wang > --- > Features/ManageabilityPkg/ManageabilityPkg.dec | 1 + > Features/ManageabilityPkg/Include/Manageability.dsc | 4 ++++ > Features/ManageabilityPkg/ManageabilityPkg.dsc | 2 ++ > Features/ManageabilityPkg/Include/PostMemory.fdf | 4 ++++ > 4 files changed, 11 insertions(+) > > diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec b/Features/ManageabilityPkg/ManageabilityPkg.dec > index 38813c5f48..0a1c527107 100644 > --- a/Features/ManageabilityPkg/ManageabilityPkg.dec > +++ b/Features/ManageabilityPkg/ManageabilityPkg.dec > @@ -79,4 +79,5 @@ > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmEnable|FALSE|BOOLEAN|0x10000004 > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable|FALSE|BOOLEAN|0x10000005 > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmSmbiosTransferEnable|FALSE|BOOLEAN|0x10000006 > + gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiOsWdt|FALSE|BOOLEAN|0x10000008 > > diff --git a/Features/ManageabilityPkg/Include/Manageability.dsc b/Features/ManageabilityPkg/Include/Manageability.dsc > index a432b0ff26..439f3be1ce 100644 > --- a/Features/ManageabilityPkg/Include/Manageability.dsc > +++ b/Features/ManageabilityPkg/Include/Manageability.dsc > @@ -51,3 +51,7 @@ > !if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable == TRUE > ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocolDxe.inf > !endif > + > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiOsWdt == TRUE > + ManageabilityPkg/Universal/IpmiOsWdt/OsWdt.inf > +!endif > diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dsc b/Features/ManageabilityPkg/ManageabilityPkg.dsc > index e3baf27f2a..177c900360 100644 > --- a/Features/ManageabilityPkg/ManageabilityPkg.dsc > +++ b/Features/ManageabilityPkg/ManageabilityPkg.dsc > @@ -37,6 +37,7 @@ > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmEnable |TRUE > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable |TRUE > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmSmbiosTransferEnable|TRUE > + gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiOsWdt |TRUE > > # > # Include common libraries > @@ -53,5 +54,6 @@ > > [LibraryClasses] > ManageabilityTransportLib|ManageabilityPkg/Library/BaseManageabilityTransportNullLib/BaseManageabilityTransportNull.inf > + IpmiLib|MdeModulePkg/Library/BaseIpmiLibNull/BaseIpmiLibNull.inf > > !include Include/Manageability.dsc > diff --git a/Features/ManageabilityPkg/Include/PostMemory.fdf b/Features/ManageabilityPkg/Include/PostMemory.fdf > index 9100cb2646..1a2fed2253 100644 > --- a/Features/ManageabilityPkg/Include/PostMemory.fdf > +++ b/Features/ManageabilityPkg/Include/PostMemory.fdf > @@ -26,3 +26,7 @@ > !if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable == TRUE > INF ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocolDxe.inf > !endif > + > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiOsWdt == TRUE > + INF ManageabilityPkg/Universal/IpmiOsWdt/OsWdt.inf > +!endif