From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web09.4995.1622110906708490575 for ; Thu, 27 May 2021 03:21:46 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=IKMWxQ4F; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622110905; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yCqBA/rl+tX3vSmKpimOgOxeylD378RrGAcKLzLpUXs=; b=IKMWxQ4FUsZ+e/ZKI8FXmPSFE/jm00GOb3E2KA0b9EzmsHshIaWQEIuJRn4Il+Sh8f7XiJ oOwloOPzL7ovD/8nyhhpgXgPhKiEsuaUh+9RFUh0O/Ytexun58NMqrc3xtvnu6La2DravH dt/NJo391OuCBaIEjA6zQV63TYcF6+0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-357-U9npAeNEPb2cscLDAqsR5g-1; Thu, 27 May 2021 06:21:42 -0400 X-MC-Unique: U9npAeNEPb2cscLDAqsR5g-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 558B1107ACC7; Thu, 27 May 2021 10:21:40 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-115-44.ams2.redhat.com [10.36.115.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E73BC10013C1; Thu, 27 May 2021 10:21:37 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v1] OvmfPkg: Add build options for 8MB and 16MB X64 OVMF images From: "Laszlo Ersek" Cc: devel@edk2.groups.io, dbautista@newmexicoconsortium.org, Brijesh Singh , Erdem Aktas , James Bottomley , Jiewen Yao , Min Xu , Tom Lendacky References: <7bfd4b82fc725302beb37e13c4a89d389c34ec34.1622048433.git.dbautista@newmexicoconsortium.org> To: "Jordan Justen (Intel address)" , "Ard Biesheuvel (TianoCore)" Message-ID: <9f0b0b50-1c2c-2d49-b2b6-00dd1f480e35@redhat.com> Date: Thu, 27 May 2021 12:21:36 +0200 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Ard, Jordan, On 05/27/21 12:14, Laszlo Ersek wrote: > On 05/27/21 12:12, Laszlo Ersek wrote: >> On 05/26/21 19:08, Devon Bautista wrote: >>> Currently, the largest volume size for building OVMF images is 4MB. With >>> the growth of the Linuxboot project, maintainers have had to maintain a >>> fork containing this patch which allows larger image sizes in order for >>> Linuxboot developers/users to have enough space to experiment with >>> and test including their own Linux kernel in the DXE section of OVMF >>> firmware. Testing using OVMF is valuable since it allows testing in QEMU >>> and thus does not require any hardware to do so. >>> >>> This patch allows specifying '-D FD_SIZE_8MB' or '-D FD_SIZE_16MB' to >>> the OVMF build script in order to add the ability to build 8MB or 16MB >>> x86_64 (X64) OVMF images, respectively. >>> >>> Signed-off-by: Devon Bautista >>> --- >>> OvmfPkg/OvmfPkgDefines.fdf.inc | 34 ++++++++++++++++++++++++++++++++++ >>> OvmfPkg/OvmfPkgX64.dsc | 10 +++++++++- >>> OvmfPkg/VarStore.fdf.inc | 16 ++++++++-------- >>> 3 files changed, 51 insertions(+), 9 deletions(-) >>> > >> I'm providing minimal feedback here just to get this review off my plate >> as quickly as possible. Sorry, I'm collapsing under my TODO list. > > PS: please file a tianocore feature request at , and please link the current (v1) posting into it (in a new bugzilla comment), with the following URLs: > > https://edk2.groups.io/g/devel/message/75666 > https://listman.redhat.com/archives/edk2-devel-archive/2021-May/msg01106.html > http://mid.mail-archive.com/7bfd4b82fc725302beb37e13c4a89d389c34ec34.1622048433.git.dbautista@newmexicoconsortium.org You weren't CC'd on the patch up-front, and I too forgot adding you immediately. Please consider checking the thread from the root; please see the archive URLs above. Thanks! Laszlo