From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mx.groups.io with SMTP id smtpd.web08.4295.1663908175436976125 for ; Thu, 22 Sep 2022 21:42:55 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=aSlWEMiU; spf=pass (domain: gmail.com, ip: 209.85.216.42, mailfrom: kuqin12@gmail.com) Received: by mail-pj1-f42.google.com with SMTP id fv3so11868052pjb.0 for ; Thu, 22 Sep 2022 21:42:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=CbtzmfjvA9eVO2B8NZVTYK9oKYpRVxcyrKkQdcPFUuc=; b=aSlWEMiULgEf2JqHRCe8Q2vcg+zLv8Q1j/ZPN5Cabg/8HI8J2T6GMqLow50jVZr6c+ 3VlM/lwH20ezIP0izY3zEPsMvp+zH+lI+HISpHcBqgWGcVmt5km6rpGQZ0JYNZblqnru aIhD7q9nfL4jGsPCn+sqd7U6u1P403WGLnLWidXvLz9302pDLtJ08kiddEi/pWbqWt3c Ah2iZhi076NzO1UM4CN3x+StyjaH5kfk7m4jVmdRjDnf3EVqcS6+9HuEsIXmc96sBuN2 IHb7ASC48+OY5aR5y3Im9xakeADyY6AsFU7FvU2aqIPGrpCwftViTv8LUf3eLiXXfAfc pDFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=CbtzmfjvA9eVO2B8NZVTYK9oKYpRVxcyrKkQdcPFUuc=; b=C3A8rMTBCkE43tsELyi6lZR8V0VkE5S7UOZHxy9cAqNNoFA5rBtfb3clzTJHUN7mnB YMVj0anearaA3U5F9v+jfXENI1ggJf5xZJUns9j1+J8unY9Qrc0XvwN5/zwnUBapWi42 ICY+fbLAWEmvk4R3VPERlNj/lYsKko8V4LjqTldoA4VuYJ9uiPESih3lk77dMQZNyuaC FOtKIjnFE9JlMk2kgP3ascyDkbBPZ0TRN4jzVFdPEl0DFKHHKJ1Pv/cwKjuLT213eKaq Cj7V+xsmL3XjjT698Hvs8WWDDwgkMr/gWiQ29bfRL7lCitFZy3HKc02QxSEzj+Ajbu1p jdsw== X-Gm-Message-State: ACrzQf0l7bAioK4JPKVxxTqR1zKn/IzT/ppILtrxCc1glQVcPy+C4rw5 OxhrEtcnX1ItLI9u0RhDkuEyVWfD1OY= X-Google-Smtp-Source: AMsMyM6NIz4PWojGYCbQTSoQnKFeOuXrLmr0Y99yreWPqifyKOa4mQVLyIeNRUCEXfX9Hd9F8QGPew== X-Received: by 2002:a17:90b:4a82:b0:200:a89e:6f1f with SMTP id lp2-20020a17090b4a8200b00200a89e6f1fmr18666593pjb.13.1663908174577; Thu, 22 Sep 2022 21:42:54 -0700 (PDT) Return-Path: Received: from ?IPV6:2601:600:9780:29e0:a985:7b34:4c37:1798? ([2601:600:9780:29e0:a985:7b34:4c37:1798]) by smtp.gmail.com with ESMTPSA id a67-20020a624d46000000b005465ffaa89dsm5279351pfb.184.2022.09.22.21.42.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 21:42:54 -0700 (PDT) Message-ID: <9f0d7130-d4a8-ec8f-9b54-dd757d6a5fbe@gmail.com> Date: Thu, 22 Sep 2022 21:42:53 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Edk2ToolsBuild: Fixing pipeline build due to path too long To: devel@edk2.groups.io, bob.c.feng@intel.com Cc: "Gao, Liming" , "Chen, Christine" , Sean Brogan References: <20220921204459.821-1-kuqin12@gmail.com> <20220921204459.821-2-kuqin12@gmail.com> <17172A4739518A26.13460@groups.io> From: "Kun Qin" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for the help, Bob. It seems that one of the "Reviewed-by" tags are breaking the pipeline patchcheck: https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=62531&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=9c939e41-62c2-5605-5e05-fc3554afc9f5 Would like me to send a v2 patch? Regards, Kun On 09/22/2022 04:26, Bob Feng wrote: > Create PR https://github.com/tianocore/edk2/pull/3378 for merge. > > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Bob Feng > Sent: Thursday, September 22, 2022 7:11 PM > To: Kun Qin ; devel@edk2.groups.io > Cc: Gao, Liming ; Chen, Christine ; Sean Brogan > Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Edk2ToolsBuild: Fixing pipeline build due to path too long > > Reviewed-by: Bob Feng > > -----Original Message----- > From: Kun Qin > Sent: Thursday, September 22, 2022 4:45 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming ; Chen, Christine ; Sean Brogan > Subject: [PATCH v1 1/1] BaseTools: Edk2ToolsBuild: Fixing pipeline build due to path too long > > From: Sean Brogan > > Current implementation of looking up toolchain will _insert_ the findings from vsvarsall.bat to existing path and potentially stuff the variable to exceed the length of maximal path length accepted by Windows. > > This change updated the logic to use the discovered shell varialbes to replace the existing path, which is desirable in the specific use case. > > Cc: Bob Feng > Cc: Liming Gao > Cc: Yuwei Chen > > Co-authored-by: Sean Brogan > Signed-off-by: Kun Qin > --- > BaseTools/Edk2ToolsBuild.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Edk2ToolsBuild.py b/BaseTools/Edk2ToolsBuild.py index 1ea8187de693..f862468ce275 100644 > --- a/BaseTools/Edk2ToolsBuild.py > +++ b/BaseTools/Edk2ToolsBuild.py > @@ -122,7 +122,7 @@ class Edk2ToolsBuild(BaseAbstractInvocable): > for key in vc_vars.keys(): logging.debug(f"Var - {key} = {vc_vars[key]}") if key.lower() == 'path':- shell_env.insert_path(vc_vars[key])+ shell_env.set_path(vc_vars[key]) else: shell_env.set_shell_var(key, vc_vars[key]) -- > 2.37.1.windows.1 > > > > > > > > > > >