From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR02-VE1-obe.outbound.protection.outlook.com (EUR02-VE1-obe.outbound.protection.outlook.com [40.107.2.52]) by mx.groups.io with SMTP id smtpd.web09.28221.1660738028045447841 for ; Wed, 17 Aug 2022 05:07:09 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="body hash did not verify" header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=IubggsjK; spf=pass (domain: arm.com, ip: 40.107.2.52, mailfrom: sami.mujawar@arm.com) ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=m3Pp7/6ynYk2aAObCi9F8X5nsgF8jwwUyIkfvHCzItJdYXaFlDQVr/klBpOhBqbubhg6aE5VYDrRBDqJ6+KZB0liaPnkxRBtBTrm1W3jTLqQmvzZQpVdTAV4VhTKohIw54QyVX/ewR7NhOiY1x07XPMUL+3UfMoW/sac/egCHpRR+g82ytjrE00CGyyegY7vsLXBNZ+g9O5+UI2YJ4sM+n+sr4hnSCEU9RUhrLzBry1RBPKpSUqTvX5W7nFE02y54xh3Y433FudPKBGH0qnSGComM742eP2dYhEzq96cn7KpM4F2KAzw76XfQMAv2CmTlJZI4s4NZ2wiXxd3jyAsTg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GP1d42xpU7VWkG8GiYLuGJstN++NsXvVfNJcyxf3z/M=; b=j9jTHBufELGgqOimj/bJy1E5QpaJ/BDK7YbIUr/vA1E0WHfUa4/lZH1APYX9p9xdRkSYuqJJNMnvqDnSE7+m68YZUQeUI6JaLqrtz/V0YAS+pWDkVCdQIQXoOrz1BzXPIVzeAqwGx5761N5VUXL9FCecHDEjgzofmkPbhKEnetZG6bEyW/zKOpuqc5ZehpPnhhnfReFP3meu1T9tkN702ASyi2OcNM2mzBxZ6TVlarzJcyUdmqDAtBY+1g/e6Oe5FmXeHxZnCwbtjcejVxXO5jW7vz/6af92C5dVxz6GEpsrKhz61t67DRZh1giPaTJNgglaHLCZYRTTevdCDCmMsg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GP1d42xpU7VWkG8GiYLuGJstN++NsXvVfNJcyxf3z/M=; b=IubggsjK6pcACTHV2zDGm10HA9+oEUVeC6kNpGda/LVO5hTuPHy7dEi70U8cqjembR9l5RoNyppDOKXivqeVVCbN5bgymwS4nXdb6KJMjARQTvvZfcNIBgdbqCHpnOutQOTKjw6a3jMp3C3R8PQNf2xQy+G/mJzwrHA8Wh2dImQ= Received: from DB6PR07CA0173.eurprd07.prod.outlook.com (2603:10a6:6:43::27) by PAXPR08MB7320.eurprd08.prod.outlook.com (2603:10a6:102:223::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Wed, 17 Aug 2022 12:07:03 +0000 Received: from DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com (2603:10a6:6:43:cafe::46) by DB6PR07CA0173.outlook.office365.com (2603:10a6:6:43::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.15 via Frontend Transport; Wed, 17 Aug 2022 12:07:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT033.mail.protection.outlook.com (100.127.142.251) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.15 via Frontend Transport; Wed, 17 Aug 2022 12:07:03 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Wed, 17 Aug 2022 12:07:03 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: fdf01e835efd74ca X-CR-MTA-TID: 64aa7808 Received: from 0e3916b19407.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id E3FB97E2-EE10-4D81-84C7-9EC36E82D983.1; Wed, 17 Aug 2022 12:06:56 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 0e3916b19407.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 17 Aug 2022 12:06:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iz/CbOEFg8/SPQr+c6oJRpoFth80mNyTHaHj36C4kZgVYvFRsEhwVcl3DHkYQWdCcAxKQNTAdvKaB5AwYIs9f3agLI1dD94GdDaGxecOW+uHHMhaEkzOIAF2JheWRvrok2aynMEBBFzX3ZpDCkQykurmRF117hB5/W2NphzQubaEsjFmb4fXYQaQbQefysgwvfo0i+jSLbE2ErNH/lNqLPpOv15hOX2W7io2yDI7eCbCoWu2PaDFh0bGMlg5Wul+RSEoIgj+txoY6J2115DCDedTboqdcSb/5f6WNdP2FyFWJ7BiypcQty+uG5VArjARxmDQAdrRxkA0B191Z4bffw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GP1d42xpU7VWkG8GiYLuGJstN++NsXvVfNJcyxf3z/M=; b=c4itetTPFHtiGCzHMp8/s7mVuqLQ00vnsxMGLoTSgxbwy0M3vEIpQ4mReUVZ5B+gyUckF+yIBiRmgNbq1+NVziJFq3mQS7qrNv3M/7gY2CgmnNANlanm7+Wy73fKsIcEIENMsfaea1/fnpdEgVs3jWmEkHoAg44aH9TJIdO+HtpJ4Q0PCYipI2KsIQng7QXM+Zyu6qdxmYKguwugplRO5bZWbIuEp9xhaUyYLoPYZKYz0VUSDGJkqc8fJnggM4SPC5SUPlVBR7SfHJ+19cKpahhDY3HnAkCBA0qeUbrxhrT6Ma9euYLAyIZJEfvnSf1T2VMjBmJ0e37KZ8wu4nUOqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GP1d42xpU7VWkG8GiYLuGJstN++NsXvVfNJcyxf3z/M=; b=IubggsjK6pcACTHV2zDGm10HA9+oEUVeC6kNpGda/LVO5hTuPHy7dEi70U8cqjembR9l5RoNyppDOKXivqeVVCbN5bgymwS4nXdb6KJMjARQTvvZfcNIBgdbqCHpnOutQOTKjw6a3jMp3C3R8PQNf2xQy+G/mJzwrHA8Wh2dImQ= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by AM6PR08MB3592.eurprd08.prod.outlook.com (2603:10a6:20b:4b::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.17; Wed, 17 Aug 2022 12:06:48 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::d562:5a52:f638:7fe9%6]) with mapi id 15.20.5504.027; Wed, 17 Aug 2022 12:06:48 +0000 Message-ID: <9f3071b7-c200-1bfb-af1a-7abbb2f72f6a@arm.com> Date: Wed, 17 Aug 2022 13:06:47 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v4 6/6] DynamicTablesPkg: AcpiSsdtPcieLibArm: Added case handling for PCI config To: Pierre Gondois , Kun Qin , devel@edk2.groups.io CC: Alexei Fedorov , Joe Lopez , "nd@arm.com" References: <20220810222853.1916-1-kuqin12@gmail.com> <20220810222853.1916-7-kuqin12@gmail.com> <46f86936-9ec3-58a4-a0f6-47e5bedbf630@arm.com> From: "Sami Mujawar" In-Reply-To: <46f86936-9ec3-58a4-a0f6-47e5bedbf630@arm.com> X-ClientProxiedBy: LO2P265CA0074.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:8::14) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: e83315cc-df10-4aec-7f1f-08da8048ff67 X-MS-TrafficTypeDiagnostic: AM6PR08MB3592:EE_|DBAEUR03FT033:EE_|PAXPR08MB7320:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: =?utf-8?B?S0ZlbHY4NDJSYUJVQW9KOWNXL0x6TEtqRFRaVkJsZUpGSVM3Y0xRVllmWS8r?= =?utf-8?B?SmJIWndPZGJ4OFlUaGlNRWUwZUNQcG1zZ2NSYUtpUUNQSlJvSEc2U2x0V0x2?= =?utf-8?B?azhTSWtTYytnSmJwUjZiWUJXNzFKbW80VWtZODdOQVVoZ0V3c3MrcExlQTF6?= =?utf-8?B?QVZrZytUNGNRaG5peGFDU3VVZUZxa0ZlR3VWZXlkUS8vcXBwNEx6MjJkTVVV?= =?utf-8?B?U3B6dU1ZVVJhVG8yQjZ6bElwTVRKWEt3bkVVcmVRRlpMaXRQMFV5V3hDTHMr?= =?utf-8?B?WVRobUNhMXVhdXNLLzFSQ1c3VlZ6aTcxdmY0ZkhId1RLRis2Wkx0MFlxUFNu?= =?utf-8?B?L0lkRTljQWpGcE95OUxBTTB5eXJaK1E2eFJPd0MrS014QTkzazNlUTU3RFMz?= =?utf-8?B?T1IrZHB4YWF4RDl0clVHRGJhZ3ZyWTlRYVN5Mi9TNS9kOEJlRVljVUNveTJX?= =?utf-8?B?blBMY3FEaHowWVB0Q3dDMVdTSkFrTnZQMmlnSU1GZStDRkFJYVM1YzNadUFm?= =?utf-8?B?ODNnV2FpODlBTnZNa0VacU1vRG1qbmZqei9pZENDWHFvRXVSNmZVWnZ2d3Vy?= =?utf-8?B?eXhiZFF0S1NxL2hibG50cjE1RU5NYmVCVGlvdEpNM2JPZzhXOXFITExiZEw0?= =?utf-8?B?MGsrL2oxN1pFZVl3SGxmNGhYWVBqMTNTSVBKM0dIRXhDb2xXalk1bmd5L1ZH?= =?utf-8?B?OU5KYjV2REZwN0s0ZStXdlpGb1pXSlFwNW9uSU9GcU1hTWRpMWp1VDZBb3BP?= =?utf-8?B?eU9ZRjh4a29lbi9KKy9ncHFyeU5JaGNoeVJLcTh4WjI3K3l0OFNtZXp2QktQ?= =?utf-8?B?VnNVL3drY0FPK3hLWm5KOVVOVEIzbVZnTmY5WVlyWUNwZHdzTGJwdnhxY0Nz?= =?utf-8?B?Z2xwNTJzRWxVVkl1ZGxQOVZMcm1WT2lEbkJJa1k2b200MWhJRTlidmI3d0o2?= =?utf-8?B?N25nZzJTb2FHV1lIcXl0dVhJZENOeWhsaysycUZiYzV3TUlWTXVHb1BlMnZD?= =?utf-8?B?MGlPUGhVdGVUamFUSXBhTmh2YUVqYW9BelVKRzVoUzdhaS9MZjJJTS9JNkFK?= =?utf-8?B?cGxwZVBXZktVS1lDZjBiaFVuYjBLZlZpUnp4ZlZmNnFZNkFTUDg3ZEtIUVVG?= =?utf-8?B?L3pwUUFWYmQzelo2eHZFQXZuaXg3KzBuLzQ3K0hiNmZUUU5RUzlxeVpiQ24v?= =?utf-8?B?SGNuNjNLSkJWRlF1UjVUak9rVEdCcmFVZi8vaDB6bDZlNFhRd3cyTmpXWGpn?= =?utf-8?Q?tjo1lNcLtr9OyCc?= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39860400002)(346002)(136003)(366004)(396003)(376002)(316002)(110136005)(54906003)(26005)(41300700001)(478600001)(6512007)(6506007)(6486002)(966005)(45080400002)(2906002)(66476007)(66556008)(66946007)(4326008)(8676002)(44832011)(8936002)(5660300002)(38100700002)(31696002)(86362001)(36756003)(31686004)(83380400001)(2616005)(53546011)(186003)(213903007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3592 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 99c35baf-dbdf-4373-cae6-08da8048f652 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1CbevfKG+w/U83TUPEyR1EFr2jCFQDzwU52pstsqrRCHewBawusiM2CFTO4RD9mKpzFMRe/HETOb8r259xrToxyAQVfsNbZtWK4VrOtdIrze26YkcWxV8LFNu5+16c1mSCPz9tZpVjPbvB2GtukbU4PBtsGO2hoAWatjS1BEBlFmjrnxCEt5Mjgntt7aZld0YB0yKlkJYOpmkkeB7Eq/hIn5cNQwVSWUyex+XacVT3e6HJLSmKZ5dk3AGiKabo4HDa3hVr++xkV1MdvQ0uy3SqBnp+F0TgLRC3Sx78JDTpCMHK65Mwdp67JwxJDKZyEFvAwA/QjZuhHXRQcEC1Td/junsTyOAbGz2USHNAvMhDMe1fBN3XR6viOgUoOlgmtNCU2HJzHg7clvYsUR2DpF0HKORO0HpSWAftrQnnkqst0uoJe7lO1afxqGIQ/kWS9egppolZx3BDH9z10LMjDH0TcOPSV3EpLnPdJ2XQtPQ+uTl/yC/cEnSajNrWYfwxhuTUR8Rnhj12VQubAZFYEc2QB6fjzhIWIJ9AMOS2DxCkhN8f3qUIcCLW5LPbPwOEr3eRDFtlCSzpn6IUprrXyEkVR9ABkdzC4QZU+SE9fEFNBczsxr0cmqs4RTEpJChx2aSFjErFpdV7H3XCJN7Ip6pDtceEmUqAu4N0rpsaagZCbzSvGblQmdC5/gKm8UAf8+Inz0H4ohu+HzCj2b16UbK2YfKyfR3CjYfdRJ/gXlEwTRr2O3rHCFQaY5IcktdLMDorYL64bOzC7PPu+nFlIiOcLksIaE9mD9K/fxjbgTfTojAsg89fqLX/gqCo8gAlYgxZAbdj74Kxm5gBRvPCuJoFKm+KtGel7k+BNSgcxQFcDxAo4Ke9gJTiHgQ12Kvyau+85hz/HIMubOemAGKdLaCH0gm70WQHMIQf1tubbSySrfWwMk7DounXRX2DwqW6sW X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230016)(4636009)(376002)(346002)(396003)(136003)(39860400002)(40470700004)(46966006)(36840700001)(53546011)(44832011)(6512007)(2616005)(6506007)(8936002)(5660300002)(2906002)(82310400005)(41300700001)(36860700001)(478600001)(356005)(26005)(40480700001)(82740400003)(83380400001)(40460700003)(81166007)(86362001)(47076005)(31696002)(186003)(54906003)(110136005)(31686004)(316002)(70206006)(4326008)(70586007)(45080400002)(6486002)(8676002)(336012)(36756003)(966005)(213903007)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2022 12:07:03.7163 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e83315cc-df10-4aec-7f1f-08da8048ff67 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT033.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB7320 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Kun, I plan to get this series merged when the merge window opens. If you agree, I will drop this patch before merging. Please let me know=20 if that is ok. Regards, Sami Mujawar On 17/08/2022 09:53 am, Pierre Gondois wrote: > > > On 8/17/22 02:17, Kun Qin wrote: >> Hi Pierre, >> >> You are correct that if CM_ARM_PCI_ADDRESS_MAP_INFO.PCI_SS_CONFIG >> is no longer being used, this patch is not needed. Thanks for=20 >> catching this. >> >> On the other hand, just for my learning purpose, could you please let=20 >> me know >> what the use case for "PCI_SS_CONFIG" is? It does not seem to be used=20 >> at all. > > I haven't seen any usecase neither so far, but it is to be used to=20 > reference a > PCI bus/device/function/register location to identify/configure a device > from what I understood. > >> >> Thanks again for testing these patches! >> >> Regards, >> Kun >> >> On 8/16/2022 8:33 AM, Pierre Gondois wrote: >>> Hello Kun, >>> >>> Is this patch still required ? >>> Cf: https://edk2.groups.io/g/devel/message/92204 >>> >>> The CM_ARM_PCI_CONFIG_SPACE_INFO struct should be enough to describe >>> the PCI ECAM, so CM_ARM_PCI_ADDRESS_MAP_INFO.SpaceCode being set to >>> PCI_SS_CONFIG should be an invalid case. >>> If not I don't think a v5 should be necessary. >>> >>> Also I ran the patchset on KvmTool and everything was working. >>> >>> Regards, >>> Pierre >>> >>> On 8/11/22 00:28, Kun Qin wrote: >>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3998 >>>> >>>> This change added a switch case handling for PCI_SS_CONFIG during SSDT >>>> generation. This will allow PCI config case return EFI_SUCCESS=20 >>>> instead of >>>> EFI_INVALID_PARAMETER. >>>> >>>> Cc: Sami Mujawar >>>> Cc: Alexei Fedorov >>>> >>>> Co-authored-by: Joe Lopez >>>> Signed-off-by: Kun Qin >>>> Reviewed-by: Pierre Gondois >>>> Reviewed-by: Sami Mujawar >>>> --- >>>> >>>> Notes: >>>> =C2=A0=C2=A0=C2=A0=C2=A0 v2: >>>> =C2=A0=C2=A0=C2=A0=C2=A0 - Added Reviewed-by tag [Pierre] >>>> =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 v3: >>>> =C2=A0=C2=A0=C2=A0=C2=A0 - No change >>>> =C2=A0=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0 v4: >>>> =C2=A0=C2=A0=C2=A0=C2=A0 - Added Reviewed-by tag [Sami] >>>> >>>> DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerator= .c=20 >>>> | 5 +++++ >>>> =C2=A0 1 file changed, 5 insertions(+) >>>> >>>> diff --git=20 >>>> a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerat= or.c=20 >>>> b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerat= or.c=20 >>>> >>>> index dd75fc27e60e..c6fbd09c43f8 100644 >>>> ---=20 >>>> a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerat= or.c >>>> +++=20 >>>> b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenerat= or.c >>>> @@ -606,6 +606,11 @@ GeneratePciCrs ( >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ); >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 break; >>>> =C2=A0 +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 case PCI_SS_CONFIG: >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 // Do nothing >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Status =3D EFI_SUCCESS; >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 break; >>>> + >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 default: >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Status =3D EFI_= INVALID_PARAMETER; >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } // switch