From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.109]) by mx.groups.io with SMTP id smtpd.web10.21449.1662353220654608434 for ; Sun, 04 Sep 2022 21:47:01 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@amperemail.onmicrosoft.com header.s=selector1-amperemail-onmicrosoft-com header.b=ATIug1bt; spf=pass (domain: os.amperecomputing.com, ip: 40.107.92.109, mailfrom: nhi@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZXpqRmxQCpvBM6G1hIRDyJJtE1+qvadwzzLMduY7PyiQx7aICwQ0HD+SC2zieyUD3+k1uaCjhsW+IFuJf03Xxr6geVFmZKjmIZscYqObiel90yo3JWmJz/g1TEjC+ovoabENjbMQpPzy6M5/TAXIt7zogbTEhWhfK1ZYBmM8sDLLaweC7axnQ8In/4CpVFQLC5EP9Fj58rPxQXzfIrXKMumDufTNr83+vwkpl+Mqn+LDxc165Gmw5HW2u+2C5o7Lz2tvREmIafl3790uzsPxZ+LAZKKm5jIdqit3H3DQuO0gg4CnJb0ZQVEjJv7FI5Uqr6qmsPfJIorSuRmMwMnhlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gx6fMKM4JFWgb3l+rQQM2tfo8Izjfa9ehUIqA2PRDzY=; b=G+h9MPst+JaAdirRPdHB1xR3uPQ4bxf+vKrQo+B2G4V47jCrC9Hy9/oqsNwRYIFEMN+cXUgndQxOOPBN71o/VBB2GYfxGnFbENsLmroDKVJ5AL5lcpP4GT1tkmV+5nf7Iavjbl/Z/pDhLRSRNMhOiq8S7XiCWL8p7Q67eoITZfUZiYdBpNxrWr5TAdsbNcrqofw3XIvMa/uYeNYyo+WyAsp65gPZD+3hlyrtJrlcS5Y3zqxqAZmZs+kRwXtJTYwUNo3h3x+HMjfQt2VuFLAS/48VoZAFFvTVoUw6eujt7uktwvMiIMmX/ixABIvUNOMHBF5iuxV1opuwrYhV5d+hgg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-amperemail-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gx6fMKM4JFWgb3l+rQQM2tfo8Izjfa9ehUIqA2PRDzY=; b=ATIug1btRtFyBBUU8nQIGsCtpeu0riahBkY6PMB7EPRcT60fxvt5/OrOhJJYkS/eGRHI5bTWmmTUiDKNOAfUvcmcvM4M/287ETMOTBr7csEwvcAT1DwSVVpYnB8g6SymxLauuZpgn7rKwCyNs0mnDlqxJw0YArUVvUeCLk4goVw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amperemail.onmicrosoft.com; Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by DM5PR0102MB3334.prod.exchangelabs.com (2603:10b6:4:9e::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.16; Mon, 5 Sep 2022 04:46:51 +0000 Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::fc6b:4f56:8f32:dfa5]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::fc6b:4f56:8f32:dfa5%4]) with mapi id 15.20.5588.017; Mon, 5 Sep 2022 04:46:51 +0000 Message-ID: <9f453094-7540-03f0-bdb5-af189a3d160a@amperemail.onmicrosoft.com> Date: Mon, 5 Sep 2022 11:46:11 +0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [edk2-devel] [PATCH v2 1/6] ArmPkg/ProcessorSubClassDxe: Get processor version from OemMiscLib To: Sami Mujawar , Nhi Pham , devel@edk2.groups.io References: <20220824165032.1784305-2-nhi@os.amperecomputing.com> <19556.1662029332828174055@groups.io> From: "Nhi Pham" In-Reply-To: <19556.1662029332828174055@groups.io> X-ClientProxiedBy: SI2PR04CA0008.apcprd04.prod.outlook.com (2603:1096:4:197::20) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) Return-Path: nhi@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5e1f0ecc-50c1-462c-fe3e-08da8ef9a5a7 X-MS-TrafficTypeDiagnostic: DM5PR0102MB3334:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yBjp/1oTLdmKaPwkoBPjkbUk8QJ28wOHJ+YVnEDrdkRUtWLYiiX0prNscvyfrUEorh7rh8vNH4Wn/RIgbivQJLl56hUYRo693hJmVQ7P9CNaP62lWcLVC3AF/61xvnVke9TLvWMW/YFCVzooY3dnXRYg4Z18PJxRa+B8czR/HO0wI0JL8mz5tXciuTPKLzPiSi68KFflqGkw5BWvhDY32xmp/bDtlsvpZTOBp4xUkyhyvgdXpBQzynLef2yPZVyziyksS7qW3GOp3NZx7zXUHLMTTK1TuMDfgPQpVaDpJxe7x3Pp+MxuInAcg+Dksa7k29m2Cb1hcVM1ngc4FXtE7UP0S4aA8Vm6mp1BXo0f4APmIVJ1Zs08Yz611MHFONNkIvGxe25soqbBS3/0SjGPlyE77OF32h+UETl9wbWcMqyBHbdvPw5uFlL3ND12tk4HPov6MGXg9rceDYNwLZqSbu/ahbh/UW3JBDAVDK7qKZb1t+jAH6B2niF4mBWdgOtYDxsZ2jS2/roa0bs0gPzPYDF9tho8lOeN0ndE7V9+ooAWi84RCYfeX+Oa40GMDmopUc1Jgt0zsMmtuemW+bq8AaUllsBSScbpjZZMnoTur9om0H45G/xfmPBfTX16iNY+PNkTK6YPmyOsE7Ob+xfYR+H8QY7weScDjax2OaK/ojp4YEySneT8n3toIxthrRFmqIQXs5dR0aV4Hz+6X+aI1DWdQtIegzK5fXwYTmAj67wUcENoD9H1rqhWK1AJ8GCL2WeAwa2q8lYWCbm/n47IeKRNDct9Eo6YHg/BPOnx8CU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR01MB7287.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(376002)(396003)(136003)(346002)(366004)(39840400004)(5660300002)(558084003)(41300700001)(478600001)(2906002)(6512007)(31696002)(52116002)(6666004)(6506007)(53546011)(8936002)(26005)(38100700002)(38350700002)(42882007)(2616005)(186003)(83170400001)(83380400001)(66556008)(66476007)(66946007)(31686004)(8676002)(6486002)(110136005)(316002)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZEcza290cXpFUm9JQVpkdVUrY2JGakxTZGFnMVVKV1ZSekc3MFozOFNxRE9M?= =?utf-8?B?d3I1SDgzOGFEaE9JOVRYakJ3YXZqSFlPMFdzNmF2UEVpQUZPbVZkbGR3dTVa?= =?utf-8?B?UFBJWTJSSzNtM0dJTGhmeHpkMUUvVnBvSGxpek5GSkRrdjlxZEVsTVRHbWZS?= =?utf-8?B?QjFSQmlFVVQvZS9MMlg0c2dtSUFhL2RtOTc0c2dLdklHekdXcjJOMlhWRk9S?= =?utf-8?B?eDl4bE16akRLQTJ5ZmJvV0ZrWFZNVXlkdHVWcDB6Y3QwYUlMWEJxTGYxWm1l?= =?utf-8?B?bUFzckJhSTFjRW50Wkt5amV3Zk5vb3lpbW0wekM4dkRtaFlwM0hxRmFIVnhk?= =?utf-8?B?MWtCNEl4UE96Zm9vQ29VMVJaaU5zSVYyL3p1a0JMRzFUcVJ6ODVUYkVVNUFo?= =?utf-8?B?S0ZIZTRaakViUVgybXcwdkQ3ZEV5YkZMQzlOaGcrRlM4a1U1QmtCN21EWVZT?= =?utf-8?B?MlF5ckNFelJKUGgrOHFBWithOThmTEhvZEFxd2RUa2V1MkY1OWQ4VTkxdHRk?= =?utf-8?B?MEd5ZkRPVG9XN2dWczF5R05JR0hIOXpJZXdFSnJzRFg1M0ZwdGN2VmNEa00y?= =?utf-8?B?Qlg5MDlicVozNDN6Smpxdm1jZ2ZaUi9NRFYrczRvOTY3Y2s2WGkzbElpOUdw?= =?utf-8?B?S2Z0Ry9YdENZdTNRdUdZYTRrN2lPcGdSUVFHS2plaGJzazZ6aE9JRFRxeDBT?= =?utf-8?B?YlVURStJZkNOUzlLNU1Dcy9sZXh5Mk92ZDZzYjlKc2pKSEdzTllucGw1TVJB?= =?utf-8?B?WDVPem13cjFOREx2L3ZGakZUd3I5eTB1Z1VjTjFJT1F2ZDRlblJyZlJPUXRo?= =?utf-8?B?ZTB2SFJwNHhaSC8wVUpaQk50VTNGbVBxZXlQOGlBQnMyT1AybldoMGdwL1Ry?= =?utf-8?B?ekc0WERkVWNTTEtjQnNoazUwTml4cFpGL2FaZVVYZE5KMjhGYnV2bUVtdWoy?= =?utf-8?B?Wis4Y0t0Z2ZOZDZENXJwQVdBTFVrWlRtZWE3bWYwMkluN3B4V2lseGdkT3RO?= =?utf-8?B?Y3kwYmQ4QVZNZ3Jqc0lSa2RkMGtXSHNKMklkTVJlNVVPNGcwdVhpcnRDU3dK?= =?utf-8?B?U2NRakY3OWVPcEE4R1JnWnFCd2VVc3FzMVJNVmJXaUFENHdDaThwTkZRNjZK?= =?utf-8?B?RWNvZ1lJWXJIUEpVTmhuSVUxNEh6R1pvNnJjZTZsRWFhRmhjbFo5ditlMEZ5?= =?utf-8?B?dTVxRHdnaUFXQk1VeFdiLzk5c21kRHFIdExzMkZYS2lGWjVldXlvTTcwcXUz?= =?utf-8?B?QXZ2bE1LSENRNThpUXVEeWNpMzhGZW1ZQ3dsa0U3dFgxVG5FN25KRUI3RUxF?= =?utf-8?B?REExQ0FVSlpOUmtHY09OMUxWRjRrTnZVYWpmajhwT21DenYwZEhISjNFR3hm?= =?utf-8?B?ckRUMlk5NmxISWlBaGM4Zk9VTUZTVHYvaEZZRUhBNjZYcGxDdHpGdHZJcldR?= =?utf-8?B?RnpwVW5VTzc5WjdlZUYrN3FpT3c5N3VSZ3RLVjhtaDZKRm00N0dVQjRReTgx?= =?utf-8?B?MDZWMDFNbU0wdHNOUWNjM3pBRGp2RWh3MmRqNVhVYWN6aXgyc3MrQzRlVjZx?= =?utf-8?B?ZjlWc2RyQUkzUUIxMVNZQnZIM2trWnk2ZlhJbnJhdGR5Y2xVL2pvZTUxblNV?= =?utf-8?B?NjdQK2F0R3ZxRVNFQy83a0tTa1kvNE1GWnNEQ1lCMjhNa3BpQnBrVDNEMmVj?= =?utf-8?B?aFhINGlYbkpFV2dacURXSWlkeFNZbWx6dzk5VytLVVNJM0gzT2FKWFhHY2li?= =?utf-8?B?VVdyZFVrbk92Wno3aDVoUzJIZ1FxTWRGNHRwVXd1ZzFiZnYyUmtzUWZUNk9C?= =?utf-8?B?SlArRFZkMk1rb3Q1Yk53QTZYb1hOdkhqb2pwbkhkVnAxR214NlN6bjJGRTJs?= =?utf-8?B?RUlldkRZTjAzWmZkZjBKKzFqL0pldE52UWRGQ2JZRXYrWi80cDVzVll5YW82?= =?utf-8?B?dDNnbTlHVHJyc1RDdHVZdlNtWnVxY0dyZWxXOWp2TitteUhtb2RqS3dLMUNp?= =?utf-8?B?dEpUcEZWOTZKR2Y1d2wzMXp2emhhN1Y4ckJFRkRZbXBmY081YjN4Mko3cVlh?= =?utf-8?B?ek84R0pobEVNYXNNMnh1Q3JSRWp0SXo5R3k1NVRYMmNHV3o1ZHJUSCtqWDl0?= =?utf-8?B?Z2VrYm1ISnNvU0N2SEZHU2JoQnpRdmhBYlZEN0xIQ0tjUmRzbklJdGJRL2hD?= =?utf-8?Q?L4gigxLFqp5S+BsfmVWV8fo=3D?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e1f0ecc-50c1-462c-fe3e-08da8ef9a5a7 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Sep 2022 04:46:50.9064 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0Btglrbomv8JgfFTkN/Z3WpCBmiaJoS2+g0j/dYW14zo0pZBLeOB6a8INVbuJrHIONQZpjm/8zI1bYQlnBGkgpThSP4lfqLg9S1fliagPIE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR0102MB3334 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Sami, Thanks a lot for your review. Please help merge this series to edk2. -Nhi On 9/1/2022 5:48 PM, Sami Mujawar wrote: > Hi Nhi, > > Thank you for the updated patch. These changes look good to me. > > Reviewed-by: Sami Mujawar > > Regards, > > Sami Mujawar