From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web08.1183.1608230663087763111 for ; Thu, 17 Dec 2020 10:44:23 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=FUPzPRM5; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1608230662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YgHuC53ugphGcdarmnkpV4XEo6A1icvOWa7b7cMnrF8=; b=FUPzPRM5ONiE3WrtrhtoHwQGH4yxpc5miT2uR0g3ftKCWuzgWpOOO7QK/D3VcgN8/4b2yJ tko3ziI02U0y5i/+R9nEuDUuC0xXgcxIpqJD+q0gkQLL/B7sapxicQXgPwBFPhdfQegMax JaBrPwgxN+jouN93GF++2cvWMiOyg9I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-362-IutBII8qOHSJW-ew7RWHuw-1; Thu, 17 Dec 2020 13:44:17 -0500 X-MC-Unique: IutBII8qOHSJW-ew7RWHuw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4F359C7461; Thu, 17 Dec 2020 18:43:50 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-17.ams2.redhat.com [10.36.112.17]) by smtp.corp.redhat.com (Postfix) with ESMTP id AC7267771A; Thu, 17 Dec 2020 18:43:46 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 0/2] Update SevSecret API to work for TDX To: devel@edk2.groups.io, jejb@linux.ibm.com Cc: dovmurik@linux.vnet.ibm.com, Dov.Murik1@il.ibm.com, ashish.kalra@amd.com, brijesh.singh@amd.com, tobin@ibm.com, david.kaplan@amd.com, jon.grimm@amd.com, thomas.lendacky@amd.com, frankeh@us.ibm.com, "Dr . David Alan Gilbert" , Jordan Justen , Ard Biesheuvel , "Yao, Jiewen" , Michael Kinney References: <20201216014146.2229-1-jejb@linux.ibm.com> From: "Laszlo Ersek" Message-ID: <9f490145-b7a2-f568-f8e8-7f2b115708ea@redhat.com> Date: Thu, 17 Dec 2020 19:43:45 +0100 MIME-Version: 1.0 In-Reply-To: <20201216014146.2229-1-jejb@linux.ibm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit +Mike On 12/16/20 02:41, James Bottomley wrote: > This patch series changes the EFI configuration table information > which is queried by the bootloader to make it more compatible with > Intel TDX. The first patch changes the ABI to make the table contain > two 64 bit integers instead of two 32 bit ones. The second patch is a > cosmetic one to change the names of the GUIDs and tables to have a > confidential computing prefix instead of a SEV Launch one. > > The first patch *must* be applied before the next stable tag to avoid > ABI breakage. The second is purely cosmetic and doesn't change the > code output. > > Ultimately there will still need to be a TDX collector for the secret, > which would feed the value into the SecretDxe, but these changes > should ensure that no further changes would be required by the secret > consumers. > > James > > --- > > James Bottomley (2): > OvmfPkg: Change SEV Launch Secret API to be UINT64 for base and size > OvmfPkg/AmdSev/SecretDxe: make secret location naming generic > > OvmfPkg/OvmfPkg.dec | 2 +- > OvmfPkg/AmdSev/SecretDxe/SecretDxe.inf | 2 +- > ...aunchSecret.h => ConfidentialComputingSecret.h} | 14 +++++++------- > OvmfPkg/AmdSev/SecretDxe/SecretDxe.c | 6 +++--- > 4 files changed, 12 insertions(+), 12 deletions(-) > rename OvmfPkg/Include/Guid/{SevLaunchSecret.h => ConfidentialComputingSecret.h} (65%) > series Reviewed-by: Laszlo Ersek I tried merging this: https://github.com/tianocore/edk2/pull/1235 but the Ubuntu builds all failed. I've checked two logs: https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=16967&view=logs&j=cf2d8b26-a21c-5c68-abf4-b944c123e462&t=5ffbbe5c-1d3a-55f5-5ef3-8a0ef80d76a1&l=184 https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=16968&view=logs&j=47cf355a-6eb4-51a8-46a8-ff4028bfcac0&t=beedef5d-00d0-5a8c-fa35-57d7319988c2&l=182 They say, INFO - /bin/sh: 1: qemu-system-aarch64: not found INFO - /bin/sh: 1: qemu-system-x86_64: not found I guess I won't be merging the three patch sets that I had planned for this evening... Laszlo