* [PATCH v2 1/4] MdeModulePkg DxeCore: Fix typo in function name
2019-10-16 13:25 [PATCH v2 0/4] trivial: Fix typos in "processing/processed" Philippe Mathieu-Daudé
@ 2019-10-16 13:25 ` Philippe Mathieu-Daudé
2019-10-16 13:25 ` [PATCH v2 2/4] MdeModulePkg/PiSmmCore: " Philippe Mathieu-Daudé
` (3 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-10-16 13:25 UTC (permalink / raw)
To: devel
Cc: Supreeth Venkatesh, Eric Dong, Liming Gao, Achin Gupta, Dandan Bi,
Jiaxin Wu, Hao A Wu, Ray Ni, Siyuan Fu, Jiewen Yao, Jian J Wang,
Laszlo Ersek, Philippe Mathieu-Daude
An extra 's' slipped into the FvIsBeingProcessed function
name. Drop it to fix the typo.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c b/MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c
index c310b40b5298..fed60c48825d 100644
--- a/MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c
+++ b/MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c
@@ -696,7 +696,7 @@ FvHasBeenProcessed (
**/
KNOWN_HANDLE *
-FvIsBeingProcesssed (
+FvIsBeingProcessed (
IN EFI_HANDLE FvHandle
)
{
@@ -1253,7 +1253,7 @@ CoreFwVolEventProtocolNotify (
//
// Since we are about to process this Fv mark it as processed.
//
- KnownHandle = FvIsBeingProcesssed (FvHandle);
+ KnownHandle = FvIsBeingProcessed (FvHandle);
if (KnownHandle == NULL) {
//
// The FV with the same FV name guid has already been processed.
--
2.21.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 2/4] MdeModulePkg/PiSmmCore: Fix typo in function name
2019-10-16 13:25 [PATCH v2 0/4] trivial: Fix typos in "processing/processed" Philippe Mathieu-Daudé
2019-10-16 13:25 ` [PATCH v2 1/4] MdeModulePkg DxeCore: Fix typo in function name Philippe Mathieu-Daudé
@ 2019-10-16 13:25 ` Philippe Mathieu-Daudé
2019-10-16 13:25 ` [PATCH v2 3/4] StandaloneMmPkg/Core: " Philippe Mathieu-Daudé
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-10-16 13:25 UTC (permalink / raw)
To: devel
Cc: Supreeth Venkatesh, Eric Dong, Liming Gao, Achin Gupta, Dandan Bi,
Jiaxin Wu, Hao A Wu, Ray Ni, Siyuan Fu, Jiewen Yao, Jian J Wang,
Laszlo Ersek, Philippe Mathieu-Daude
An extra 's' slipped into the FvIsBeingProcessed function
name. Drop it to fix the typo.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Hao A Wu <hao.a.wu@intel.com>
Reviewed-by: Liming Gao <liming.gao@intel.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
MdeModulePkg/Core/PiSmmCore/Dispatcher.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Core/PiSmmCore/Dispatcher.c b/MdeModulePkg/Core/PiSmmCore/Dispatcher.c
index 1c88c8fb17c5..e5a160ed0b92 100644
--- a/MdeModulePkg/Core/PiSmmCore/Dispatcher.c
+++ b/MdeModulePkg/Core/PiSmmCore/Dispatcher.c
@@ -1101,7 +1101,7 @@ FvHasBeenProcessed (
**/
VOID
-FvIsBeingProcesssed (
+FvIsBeingProcessed (
IN EFI_HANDLE FvHandle
)
{
@@ -1294,7 +1294,7 @@ SmmDriverDispatchHandler (
//
// Since we are about to process this Fv mark it as processed.
//
- FvIsBeingProcesssed (FvHandle);
+ FvIsBeingProcessed (FvHandle);
Status = gBS->HandleProtocol (FvHandle, &gEfiFirmwareVolume2ProtocolGuid, (VOID **)&Fv);
if (EFI_ERROR (Status)) {
--
2.21.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v2 3/4] StandaloneMmPkg/Core: Fix typo in function name
2019-10-16 13:25 [PATCH v2 0/4] trivial: Fix typos in "processing/processed" Philippe Mathieu-Daudé
2019-10-16 13:25 ` [PATCH v2 1/4] MdeModulePkg DxeCore: Fix typo in function name Philippe Mathieu-Daudé
2019-10-16 13:25 ` [PATCH v2 2/4] MdeModulePkg/PiSmmCore: " Philippe Mathieu-Daudé
@ 2019-10-16 13:25 ` Philippe Mathieu-Daudé
2019-10-16 13:43 ` Yao, Jiewen
2019-10-16 13:25 ` [PATCH v2 4/4] NetworkPkg/Ip6Dxe: Fix typo in comment Philippe Mathieu-Daudé
2019-10-16 13:32 ` [PATCH v2 0/4] trivial: Fix typos in "processing/processed" Laszlo Ersek
4 siblings, 1 reply; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-10-16 13:25 UTC (permalink / raw)
To: devel
Cc: Supreeth Venkatesh, Eric Dong, Liming Gao, Achin Gupta, Dandan Bi,
Jiaxin Wu, Hao A Wu, Ray Ni, Siyuan Fu, Jiewen Yao, Jian J Wang,
Laszlo Ersek, Philippe Mathieu-Daude
An extra 's' slipped into the FvIsBeingProcessed function
name. Drop it to fix the typo.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
StandaloneMmPkg/Core/Dispatcher.c | 4 ++--
StandaloneMmPkg/Core/FwVol.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/StandaloneMmPkg/Core/Dispatcher.c b/StandaloneMmPkg/Core/Dispatcher.c
index 9853445a64a1..fe10e65c4bf0 100644
--- a/StandaloneMmPkg/Core/Dispatcher.c
+++ b/StandaloneMmPkg/Core/Dispatcher.c
@@ -810,13 +810,13 @@ FvHasBeenProcessed (
**/
VOID
-FvIsBeingProcesssed (
+FvIsBeingProcessed (
IN EFI_FIRMWARE_VOLUME_HEADER *FwVolHeader
)
{
KNOWN_FWVOL *KnownFwVol;
- DEBUG ((DEBUG_INFO, "FvIsBeingProcesssed - 0x%08x\n", KnownFwVol));
+ DEBUG ((DEBUG_INFO, "FvIsBeingProcessed - 0x%08x\n", KnownFwVol));
KnownFwVol = AllocatePool (sizeof (KNOWN_FWVOL));
ASSERT (KnownFwVol != NULL);
diff --git a/StandaloneMmPkg/Core/FwVol.c b/StandaloneMmPkg/Core/FwVol.c
index 99ecf4af4714..314329ea065a 100644
--- a/StandaloneMmPkg/Core/FwVol.c
+++ b/StandaloneMmPkg/Core/FwVol.c
@@ -38,7 +38,7 @@ FvHasBeenProcessed (
);
VOID
-FvIsBeingProcesssed (
+FvIsBeingProcessed (
IN EFI_FIRMWARE_VOLUME_HEADER *FwVolHeader
);
@@ -86,7 +86,7 @@ Returns:
return EFI_SUCCESS;
}
- FvIsBeingProcesssed (FwVolHeader);
+ FvIsBeingProcessed (FwVolHeader);
//
// First check for encapsulated compressed firmware volumes
--
2.21.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 3/4] StandaloneMmPkg/Core: Fix typo in function name
2019-10-16 13:25 ` [PATCH v2 3/4] StandaloneMmPkg/Core: " Philippe Mathieu-Daudé
@ 2019-10-16 13:43 ` Yao, Jiewen
0 siblings, 0 replies; 8+ messages in thread
From: Yao, Jiewen @ 2019-10-16 13:43 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel@edk2.groups.io
Cc: Supreeth Venkatesh, Dong, Eric, Gao, Liming, Achin Gupta,
Bi, Dandan, Wu, Jiaxin, Wu, Hao A, Ni, Ray, Fu, Siyuan,
Wang, Jian J, Laszlo Ersek
Reviewed-by: jiewen.yao@intel.com
> -----Original Message-----
> From: Philippe Mathieu-Daude <philmd@redhat.com>
> Sent: Wednesday, October 16, 2019 9:26 PM
> To: devel@edk2.groups.io
> Cc: Supreeth Venkatesh <supreeth.venkatesh@arm.com>; Dong, Eric
> <eric.dong@intel.com>; Gao, Liming <liming.gao@intel.com>; Achin Gupta
> <achin.gupta@arm.com>; Bi, Dandan <dandan.bi@intel.com>; Wu, Jiaxin
> <jiaxin.wu@intel.com>; Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray
> <ray.ni@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Laszlo Ersek
> <lersek@redhat.com>; Philippe Mathieu-Daude <philmd@redhat.com>
> Subject: [PATCH v2 3/4] StandaloneMmPkg/Core: Fix typo in function name
>
> An extra 's' slipped into the FvIsBeingProcessed function
> name. Drop it to fix the typo.
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
> ---
> StandaloneMmPkg/Core/Dispatcher.c | 4 ++--
> StandaloneMmPkg/Core/FwVol.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/StandaloneMmPkg/Core/Dispatcher.c
> b/StandaloneMmPkg/Core/Dispatcher.c
> index 9853445a64a1..fe10e65c4bf0 100644
> --- a/StandaloneMmPkg/Core/Dispatcher.c
> +++ b/StandaloneMmPkg/Core/Dispatcher.c
> @@ -810,13 +810,13 @@ FvHasBeenProcessed (
>
> **/
> VOID
> -FvIsBeingProcesssed (
> +FvIsBeingProcessed (
> IN EFI_FIRMWARE_VOLUME_HEADER *FwVolHeader
> )
> {
> KNOWN_FWVOL *KnownFwVol;
>
> - DEBUG ((DEBUG_INFO, "FvIsBeingProcesssed - 0x%08x\n", KnownFwVol));
> + DEBUG ((DEBUG_INFO, "FvIsBeingProcessed - 0x%08x\n", KnownFwVol));
>
> KnownFwVol = AllocatePool (sizeof (KNOWN_FWVOL));
> ASSERT (KnownFwVol != NULL);
> diff --git a/StandaloneMmPkg/Core/FwVol.c b/StandaloneMmPkg/Core/FwVol.c
> index 99ecf4af4714..314329ea065a 100644
> --- a/StandaloneMmPkg/Core/FwVol.c
> +++ b/StandaloneMmPkg/Core/FwVol.c
> @@ -38,7 +38,7 @@ FvHasBeenProcessed (
> );
>
> VOID
> -FvIsBeingProcesssed (
> +FvIsBeingProcessed (
> IN EFI_FIRMWARE_VOLUME_HEADER *FwVolHeader
> );
>
> @@ -86,7 +86,7 @@ Returns:
> return EFI_SUCCESS;
> }
>
> - FvIsBeingProcesssed (FwVolHeader);
> + FvIsBeingProcessed (FwVolHeader);
>
> //
> // First check for encapsulated compressed firmware volumes
> --
> 2.21.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 4/4] NetworkPkg/Ip6Dxe: Fix typo in comment
2019-10-16 13:25 [PATCH v2 0/4] trivial: Fix typos in "processing/processed" Philippe Mathieu-Daudé
` (2 preceding siblings ...)
2019-10-16 13:25 ` [PATCH v2 3/4] StandaloneMmPkg/Core: " Philippe Mathieu-Daudé
@ 2019-10-16 13:25 ` Philippe Mathieu-Daudé
2019-10-16 13:32 ` [PATCH v2 0/4] trivial: Fix typos in "processing/processed" Laszlo Ersek
4 siblings, 0 replies; 8+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-10-16 13:25 UTC (permalink / raw)
To: devel
Cc: Supreeth Venkatesh, Eric Dong, Liming Gao, Achin Gupta, Dandan Bi,
Jiaxin Wu, Hao A Wu, Ray Ni, Siyuan Fu, Jiewen Yao, Jian J Wang,
Laszlo Ersek, Philippe Mathieu-Daude
An extra 's' slipped into the 'processing' word.
Drop it to fix the typo.
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Siyuan Fu <siyuan.fu@intel.com>
Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
---
NetworkPkg/Ip6Dxe/Ip6Option.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/NetworkPkg/Ip6Dxe/Ip6Option.c b/NetworkPkg/Ip6Dxe/Ip6Option.c
index 88111e3c24f5..4d92a852dc86 100644
--- a/NetworkPkg/Ip6Dxe/Ip6Option.c
+++ b/NetworkPkg/Ip6Dxe/Ip6Option.c
@@ -158,7 +158,7 @@ Ip6IsNDOptionValid (
//
// Check the length of Ip6OptionEtherSource, Ip6OptionEtherTarget, and
// Ip6OptionRedirected here. For unrecognized options, silently ignore
- // and continue processsing the message.
+ // and continue processing the message.
//
if (Length == 0) {
return FALSE;
--
2.21.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 0/4] trivial: Fix typos in "processing/processed"
2019-10-16 13:25 [PATCH v2 0/4] trivial: Fix typos in "processing/processed" Philippe Mathieu-Daudé
` (3 preceding siblings ...)
2019-10-16 13:25 ` [PATCH v2 4/4] NetworkPkg/Ip6Dxe: Fix typo in comment Philippe Mathieu-Daudé
@ 2019-10-16 13:32 ` Laszlo Ersek
2019-10-17 1:10 ` [edk2-devel] " Wu, Hao A
4 siblings, 1 reply; 8+ messages in thread
From: Laszlo Ersek @ 2019-10-16 13:32 UTC (permalink / raw)
To: Philippe Mathieu-Daude, devel
Cc: Supreeth Venkatesh, Eric Dong, Liming Gao, Achin Gupta, Dandan Bi,
Jiaxin Wu, Hao A Wu, Ray Ni, Siyuan Fu, Jiewen Yao, Jian J Wang
On 10/16/19 15:25, Philippe Mathieu-Daude wrote:
> Some "processing/processed" words are written with an extra 's'.
> Properly write them.
>
> v2: Rebased
>
> Philippe Mathieu-Daudé (4):
> MdeModulePkg DxeCore: Fix typo in function name
> MdeModulePkg/PiSmmCore: Fix typo in function name
> StandaloneMmPkg/Core: Fix typo in function name
> NetworkPkg/Ip6Dxe: Fix typo in comment
>
> MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c | 4 ++--
> MdeModulePkg/Core/PiSmmCore/Dispatcher.c | 4 ++--
> NetworkPkg/Ip6Dxe/Ip6Option.c | 2 +-
> StandaloneMmPkg/Core/Dispatcher.c | 4 ++--
> StandaloneMmPkg/Core/FwVol.c | 4 ++--
> 5 files changed, 9 insertions(+), 9 deletions(-)
>
Patch#3 still needs an A-b or an R-b from the StandaloneMmPkg
maintainers (Achin or Jiewen).
Afterwards: Hao, given that 2 out of 4 patches are for MdeModulePkg, can
you please push this series?
Thanks
Laszlo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [edk2-devel] [PATCH v2 0/4] trivial: Fix typos in "processing/processed"
2019-10-16 13:32 ` [PATCH v2 0/4] trivial: Fix typos in "processing/processed" Laszlo Ersek
@ 2019-10-17 1:10 ` Wu, Hao A
0 siblings, 0 replies; 8+ messages in thread
From: Wu, Hao A @ 2019-10-17 1:10 UTC (permalink / raw)
To: devel@edk2.groups.io, lersek@redhat.com, Philippe Mathieu-Daude
Cc: Supreeth Venkatesh, Dong, Eric, Gao, Liming, Achin Gupta,
Bi, Dandan, Wu, Jiaxin, Ni, Ray, Fu, Siyuan, Yao, Jiewen,
Wang, Jian J
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Wednesday, October 16, 2019 9:32 PM
> To: Philippe Mathieu-Daude; devel@edk2.groups.io
> Cc: Supreeth Venkatesh; Dong, Eric; Gao, Liming; Achin Gupta; Bi, Dandan;
> Wu, Jiaxin; Wu, Hao A; Ni, Ray; Fu, Siyuan; Yao, Jiewen; Wang, Jian J
> Subject: Re: [edk2-devel] [PATCH v2 0/4] trivial: Fix typos in
> "processing/processed"
>
> On 10/16/19 15:25, Philippe Mathieu-Daude wrote:
> > Some "processing/processed" words are written with an extra 's'.
> > Properly write them.
> >
> > v2: Rebased
> >
> > Philippe Mathieu-Daudé (4):
> > MdeModulePkg DxeCore: Fix typo in function name
> > MdeModulePkg/PiSmmCore: Fix typo in function name
> > StandaloneMmPkg/Core: Fix typo in function name
> > NetworkPkg/Ip6Dxe: Fix typo in comment
> >
> > MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c | 4 ++--
> > MdeModulePkg/Core/PiSmmCore/Dispatcher.c | 4 ++--
> > NetworkPkg/Ip6Dxe/Ip6Option.c | 2 +-
> > StandaloneMmPkg/Core/Dispatcher.c | 4 ++--
> > StandaloneMmPkg/Core/FwVol.c | 4 ++--
> > 5 files changed, 9 insertions(+), 9 deletions(-)
> >
>
> Patch#3 still needs an A-b or an R-b from the StandaloneMmPkg
> maintainers (Achin or Jiewen).
>
> Afterwards: Hao, given that 2 out of 4 patches are for MdeModulePkg, can
> you please push this series?
Hello,
The series has been pushed via commits 23ab8df01a..b8fc5c03e5.
Best Regards,
Hao Wu
>
> Thanks
> Laszlo
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread