From: "Rebecca Cran via groups.io" <rebecca=os.amperecomputing.com@groups.io>
To: devel@edk2.groups.io, prabin.ca@arm.com
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
Leif Lindholm <quic_llindhol@quicinc.com>,
Sami Mujawar <sami.mujawar@arm.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 2/7] Platform/Sgi: add no-stack-protector flag for StMM builds
Date: Thu, 4 Jan 2024 11:53:30 -0700 [thread overview]
Message-ID: <9f849873-5615-47ca-af37-9427af5a0720@os.amperecomputing.com> (raw)
In-Reply-To: <20240104184935.3028480-3-prabin.ca@arm.com>
Wouldn't it be better to add the Stack Protector library
(MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf) instead of
disabling it?
--
Rebecca Cran
On 1/4/2024 11:49 AM, Prabin CA via groups.io wrote:
> Add the no-stack-protector compiler flag to allow StandaloneMM builds
> on both AArch64 and x86 host. Without this flag, the link stage fails
> with the following errors on multiple files when built with gcc
> (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0:
>
> undefined reference to `__stack_chk_guard'
> undefined reference to `__stack_chk_fail'
>
> Signed-off-by: Vijayenthiran Subramaniam <vijayenthiran.subramaniam@arm.com>
> Signed-off-by: Prabin CA <prabin.ca@arm.com>
> ---
> Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc
> index ab54b3b25f4c..2a8c678c0816 100644
> --- a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc
> +++ b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc
> @@ -145,5 +145,5 @@ [Components.AARCH64]
> #
> ###################################################################################################
> [BuildOptions.AARCH64]
> - GCC:*_*_*_CC_FLAGS = -mstrict-align -march=armv8-a -D DISABLE_NEW_DEPRECATED_INTERFACES
> + GCC:*_*_*_CC_FLAGS = -mstrict-align -march=armv8-a -fno-stack-protector -D DISABLE_NEW_DEPRECATED_INTERFACES
> GCC:*_*_*_DLINK_FLAGS = -z common-page-size=0x1000
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113199): https://edk2.groups.io/g/devel/message/113199
Mute This Topic: https://groups.io/mt/103528421/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-01-04 18:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-04 18:49 [edk2-devel] [edk2-platforms][PATCH v1 0/7] Platform/Sgi: Add support for RD-N2-Cfg3 and RD-V2 platform Prabin CA
2024-01-04 18:49 ` [edk2-devel] [edk2-platforms][PATCH v1 1/7] Platform/Sgi: remove +nofp gcc option flag Prabin CA
2024-01-04 18:49 ` [edk2-devel] [edk2-platforms][PATCH v1 2/7] Platform/Sgi: add no-stack-protector flag for StMM builds Prabin CA
2024-01-04 18:53 ` Rebecca Cran via groups.io [this message]
2024-01-04 18:49 ` [edk2-devel] [edk2-platforms][PATCH v1 3/7] Platform/Sgi: Add VariableFlashInfoLib to fix missing dependency Prabin CA
2024-01-04 18:49 ` [edk2-devel] [edk2-platforms][PATCH v1 4/7] Platform/Sgi: Add a PCD to specify platform variant Prabin CA
2024-01-04 18:49 ` [edk2-devel] [edk2-platforms][PATCH v1 4/7] Platform/Sgi: Define RD-V2 platform id values Prabin CA
2024-01-04 18:49 ` [edk2-devel] [edk2-platforms][PATCH v1 5/7] Platform/Sgi: Add support for RD-N2-Cfg3 platform Prabin CA
2024-01-04 18:49 ` [edk2-devel] [edk2-platforms][PATCH v1 5/7] Platform/Sgi: Extend SMBIOS support for RD-V2 platform Prabin CA
2024-01-04 18:49 ` [edk2-devel] [edk2-platforms][PATCH v1 6/7] Platform/Sgi: Add a PCD to specify platform variant Prabin CA
2024-01-04 18:49 ` [edk2-devel] [edk2-platforms][PATCH v1 6/7] Platform/Sgi: Define RD-V2 platform id values Prabin CA
2024-01-04 18:49 ` [edk2-devel] [edk2-platforms][PATCH v1 7/7] Platform/Sgi: Add support for RD-N2-Cfg3 platform Prabin CA
2024-01-04 18:49 ` [edk2-devel] [edk2-platforms][PATCH v1 7/7] Platform/Sgi: Extend SMBIOS support for RD-V2 platform Prabin CA
2024-01-05 8:58 ` [edk2-devel] [edk2-platforms][PATCH v1 0/7] Platform/Sgi: Add support for RD-N2-Cfg3 and " Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9f849873-5615-47ca-af37-9427af5a0720@os.amperecomputing.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox