From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 39788740038 for ; Thu, 4 Jan 2024 18:53:42 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=PCyWRLh5LzfFtNWzO1Z4haO6jWF8AgW7HB26wJD9HTY=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Message-ID:Date:User-Agent:Subject:To:Cc:References:From:In-Reply-To:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1704394420; v=1; b=tUKwWSc6sIW/n78HMNhx5IF8gb4aJviNBmYJiJs5iaIWLYd9qOi8ZDimiQoNa9iMN058+L0s MsOYg+M+VnLxCbv1llMDXaBvCwjGJ1Y+1zMsgl7c4qY83IBd6+gpvuuOVVVanSjajm0MhEEXEZp eDOJoVLv78lnX+xncYkjjLiU= X-Received: by 127.0.0.2 with SMTP id skXIYY7687511xQx9jDxLP8r; Thu, 04 Jan 2024 10:53:40 -0800 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (NAM12-MW2-obe.outbound.protection.outlook.com [40.107.244.129]) by mx.groups.io with SMTP id smtpd.web10.2121.1704394420073897842 for ; Thu, 04 Jan 2024 10:53:40 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nXv+5Y+uQym991lpuK99Eh4VIbZC+Ay57iBO8uxTUjIBYwx+WFqeubKZlgTM9y90MWRXR/OHwuMC53r+JoTL08vsbMUzCGLsvf86fxmAOaok3sm7FDdl2x84ryMiHO869YnGegOnf5bJu49kZwJ3ChgdKcZjXWdQvFmkksFcynhaOJh9R4Wksem2CsfaOCtGUopEP9FISW/suLCJjSkb7t7NcvekKy4aGFbPdwe5nZEXvDn83WAm3DVkCB34LYtu5qo1Dvhe7B9TViuNVaj1+Z288NdEeTBBOpLjCB+uw93E2IDXNCua0dH0PO9t5nrnFSNGsFoHGFeUmm+NHW/GuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wcMVeV9xMMZ3Ph0boGXcPh7CB87AibI4f6NZfO6+P7M=; b=FqNUmGtJJ8JQoxXTdU3fHnkCyryyRmu0eQe+Sqe2o+icj12BTqfvnV4piHTZspncGu+MaaYh8QonbvdfRJHyicL38lO7VBOvmANrxJlcOab97Nd6C75MSQDTnwWwbYy2z7rUWDF0a0VcTMcjFHqkUNXiVg9I8twi709x+DXMaCHsjRGpD7iPazBrVP90iw4V1YLx9mZtqhgXBMZ+3Q+QRJlqvDcvcTJQDkAWRiiOsCpbr51MTCmtfPjvT5Ki5oh62df8/+kMZFGBTmJqoh17k3M7LyFZ1nKm8ZjA8yPjEubip5KoArhoDOBCYQJ09B8E0zJ7KjpKlF2OVJjEjClvOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) by SJ0PR01MB6158.prod.exchangelabs.com (2603:10b6:a03:2a0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.14; Thu, 4 Jan 2024 18:53:35 +0000 X-Received: from LV3PR01MB8464.prod.exchangelabs.com ([fe80::7748:d4a3:bcd9:14c1]) by LV3PR01MB8464.prod.exchangelabs.com ([fe80::7748:d4a3:bcd9:14c1%6]) with mapi id 15.20.7159.013; Thu, 4 Jan 2024 18:53:35 +0000 Message-ID: <9f849873-5615-47ca-af37-9427af5a0720@os.amperecomputing.com> Date: Thu, 4 Jan 2024 11:53:30 -0700 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 2/7] Platform/Sgi: add no-stack-protector flag for StMM builds To: devel@edk2.groups.io, prabin.ca@arm.com Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar References: <20240104184935.3028480-1-prabin.ca@arm.com> <20240104184935.3028480-3-prabin.ca@arm.com> From: "Rebecca Cran via groups.io" In-Reply-To: <20240104184935.3028480-3-prabin.ca@arm.com> X-ClientProxiedBy: CH2PR10CA0012.namprd10.prod.outlook.com (2603:10b6:610:4c::22) To LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR01MB8464:EE_|SJ0PR01MB6158:EE_ X-MS-Office365-Filtering-Correlation-Id: e9ffbd1e-398e-4295-46cf-08dc0d567467 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: iFK3bvMtYSFieV6DmNWNZMA4C1n2ONqk5GoJi1g9mjHXPX2lLaSnYSdtknO8+r3GdZjYGvxbODq0KPoxwiCfq4BbKxU13Ey0oNLt6cce4pw2Hbmrvb9WdIoA3kD4+Xmk3LZu+/ODp3te5jmBmmAcVjuUfK13o0eLMmYYFIwQJK1guuRMph8JB6/+8FVAe54LglA4oE0mUWPl2SnuYS8xeemKD8QBSQWfynte4D+OmovXHHsBMcv3ljniOxaYCwSjoeg3bdTqB5kJcThoYQHjHy/mnUpUe1FIo1wOh1diAJZO6/I2EPE7uI2RIYtl09xByrOWQ7KZfO6NM63+758on5sIQwezIoF1sOtumicOFCtFlf4WQz681xB5IyFB2gQVY1sybVsGoFnB0fYllnh9i7/Obx2Hj0IRsHwVyHtpRJPxwzK2PX6siE1agfCWEDdVSD5xADE0t/adnnU6qTgXxI8HjZxq+uRbskOrTiH3fc/B1POkEXSeFD+YYuFh+RA/0vDskeowabV3wE2TBn4Qg37KS+HNuQ37RH1hriYluIcEUcaxqobcrKmiB8/nZoAfoPRu9j41Hk8QGyQ6MkD9FK8EenW+mi/schiIzD3DSetY+KFEsRcjPQ9X71m8Xci9 X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eEVrTU94Q3JmRFFVYU51NkI0dUQ0Yk9leDdJb1ptTEtkYUZmblRtUkZkYnRr?= =?utf-8?B?YW5ER2NSV0dkd2RkNXZhWlFKRXFIWVhjajJLa0gwdXozbnBoQVpObzZqMkYx?= =?utf-8?B?M05zRHRYd2NBRzFnRmZFVkJ5ZW5RWTBUdDVrRi9iM1l4WHJVc1lZR3BralZ2?= =?utf-8?B?STJHUzlUb29PMWN1UHdJTlphVVR0UHZiN1cvV0NBaDlqKzlRNG1nQjN5Lzda?= =?utf-8?B?eTVTMXNFU1Z6SWZ0ZncyMzBEN3VFS2Z1TzRxVEJBUGw0REdWdDY3RmxCSm9W?= =?utf-8?B?ZG5LUmVlYUxVQXlmdjVNVXAvWUJhZzVvTTZKcDBxTmtqWlFOWWxtTEdzTjNE?= =?utf-8?B?V0JuNzk3TG02NVdaNlFudWxmaUtrSjBYK2FrWlhyRXg5c0NKeEZNdUpibUNX?= =?utf-8?B?NFo5emU5dzFLSzFVM3RMR0Y3WVQrK1hRQ09VdVBNV3BtTzN3U1ZNNWIrQ2p6?= =?utf-8?B?QkxtQjFOQkRlN1I3WFA1N3VUK015VFI0VkFFeE1JT3JSNGhGRkE3eVpYdE50?= =?utf-8?B?cDZEMnRGK29ZMGE4MzNzWnRFZjF1SW8zNmhlbHVxTmVjT1E2UytSVWpYa1dC?= =?utf-8?B?enYyMnZ3RkphMnozNTFCYVJObFNiTUNzalF2ZldvdHBDY0NldjFUZEt1cWpo?= =?utf-8?B?RS9qMEJ6L1FGWmhOQlhnNDAzdkViT2dBSWJsaG9RbkwxZC91NUF4ajhSVzZL?= =?utf-8?B?cnBtMzVyMXp4RDFFM044b0xGaEZxLzlqS1hWWjlsUmxvaVpmNXlsWFRlL3pV?= =?utf-8?B?WVRKaGZjUTdDT3RkYnhzY1NtMGJhNXhOaWxvV2R0cWtTSFFBOGVNWU9kbE90?= =?utf-8?B?d0thSHJ3WHVIdU5yTXhNMmp2alJ2V3JidFBoWVArM3JCMnJEbXJnV3haNm15?= =?utf-8?B?dUdwdUcyVm1VZmk1T1BHTWZwNU5hcGtNOSs0VkZVQnVjcFRqLzBSakxqbzF5?= =?utf-8?B?Rlk2Tm84THpvaTlzd0Z0ajRrZnlNa0JrV09mTFZRRHlUenRaUWtzemY4b25V?= =?utf-8?B?a3hPeFFZNjlsTjl0bkQzNlluNnBhU0oxUFdRMDlQaVZFc2hVbW1EVDNLa21n?= =?utf-8?B?Z3FIb0ExOFZSdXZUZzdmdTN5OW4rZzRFR25vVXh0cWVSVkd5NlFjU24zSzlv?= =?utf-8?B?ZGhoYkY2UG9BV2E3Q25hb1JseVRuZGZPRkE1d2JJM2RFSmFzRVM4b3EreVVY?= =?utf-8?B?Mzl2elRyMjcwN24wNzl0Ni83K1B3THByUDNSMnBzbCtDZFBsa1UwTDFMVTRZ?= =?utf-8?B?UnRKUFZUNDFrMWh3L1VBZWNlSWV4bjZOVjZoc2FhTmc0YnhpRGdJMjhkRUp6?= =?utf-8?B?ZlNwb3ArcFowU0VlZzJQT2cvOVhma1NpRzJvbjBkazVsSmNpTjQvcEU2K0N5?= =?utf-8?B?UEk2ZkdaUHoyOWhXUUJwWFFpd0lobDZIWFJkWGRPZEd2bSt1UnF1bmdEaTBR?= =?utf-8?B?KzVsTHhZZ2NucnNCMmJuSUt1N0VOM1Z1MU93c0RMY1k0dU9MUVAvbklzU0ov?= =?utf-8?B?WHRDVW4rOG1OVHJMRmN2eFF0VjRYZ2psK1RVcU9zRUhvOXhSZVdQcUlJRHll?= =?utf-8?B?Z0xoYjQyUC9tYlpldTFJMktJUXhYNTY3M3dYdW5XRHhYcC9xamdpSGt5aDEv?= =?utf-8?B?clgyc25yRmJEM3RoWU5WSEF4MElDVit4cnA3OEF3MnZVVzUxalZvUGZPUCtH?= =?utf-8?B?TkdXV0FTbXJUdGRXZ3BSb3JVMHNhYjBXNExWZzBvOHZvUEZiaUVEVU45dC9q?= =?utf-8?B?R2xzdnlhbXZBdGJBdXR0MDlpSFRuRU53TU95UHVBbTV1aGloSVpPb2V2Q2JH?= =?utf-8?B?MWF4K3RqSkJnR3BuL0tTUjhkWWp4YlppNlR6cHRkZFpMdXplRXVnY3BRYWVU?= =?utf-8?B?TjRuOFBiVW9XUEhGaTRBOU9lUWZnVE5KNlRSK2IwanUxM3hCdDZYdEQ5K1Jm?= =?utf-8?B?Mzc5YlZLcXdkS052aE1aUGQyVzRqWGp3ckNUTjNaTzd0SndHS1ptYzN2TWRu?= =?utf-8?B?NjhNcEZvOS9IY015UG1SZ29UVFN6N1lLTkE4YmpSS2xMa0c3b2dobkYzc2JI?= =?utf-8?B?WGhqZ1VqQ0xGQ1oxZFUxTjhtWURGR0Jtb09nN09rbXdrU1FsNllBQUVTQzM1?= =?utf-8?B?RHVtQitibkNiT05pc212OE5NWTl0UGpuZlJ2SU1TSHVpVXU5VWN5c3VydFZZ?= =?utf-8?Q?+y6I33hO1dE6oFD7gIviFmU=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9ffbd1e-398e-4295-46cf-08dc0d567467 X-MS-Exchange-CrossTenant-AuthSource: LV3PR01MB8464.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jan 2024 18:53:35.2479 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: d4whnvFaF/9VlQvrihWzwnoQ7mjRD0wTrSeBrPTtPCnFrl9DG+bj1k5cqWvDIke1P6cXzhw6tZEwZvqLk7imbJHkyfPcHAAoEUbtW81aMmpBgTtWe7MshGOpCXT8wL0w X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR01MB6158 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: rJIkns5DjBzqZ33eqkkSOacZx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=tUKwWSc6; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Wouldn't it be better to add the Stack Protector library=20 (MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf) instead of=20 disabling it? --=20 Rebecca Cran On 1/4/2024 11:49 AM, Prabin CA via groups.io wrote: > Add the no-stack-protector compiler flag to allow StandaloneMM builds > on both AArch64 and x86 host. Without this flag, the link stage fails > with the following errors on multiple files when built with gcc > (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0: >=20 > undefined reference to `__stack_chk_guard' > undefined reference to `__stack_chk_fail' >=20 > Signed-off-by: Vijayenthiran Subramaniam > Signed-off-by: Prabin CA > --- > Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc b/Platform/ARM/Sgi= Pkg/SgiPlatformMm.dsc.inc > index ab54b3b25f4c..2a8c678c0816 100644 > --- a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc > +++ b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc > @@ -145,5 +145,5 @@ [Components.AARCH64] > # > #######################################################################= ############################ > [BuildOptions.AARCH64] > - GCC:*_*_*_CC_FLAGS =3D -mstrict-align -march=3Darmv8-a -D DISABLE_NEW_= DEPRECATED_INTERFACES > + GCC:*_*_*_CC_FLAGS =3D -mstrict-align -march=3Darmv8-a -fno-stack-prot= ector -D DISABLE_NEW_DEPRECATED_INTERFACES > GCC:*_*_*_DLINK_FLAGS =3D -z common-page-size=3D0x1000 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113199): https://edk2.groups.io/g/devel/message/113199 Mute This Topic: https://groups.io/mt/103528421/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-