From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7217881CE7 for ; Mon, 21 Nov 2016 12:07:29 -0800 (PST) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 80F0383F45; Mon, 21 Nov 2016 20:07:28 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-154.phx2.redhat.com [10.3.116.154]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uALK7Qjb018821; Mon, 21 Nov 2016 15:07:27 -0500 To: Konrad Rzeszutek Wilk References: <20161121155651.4781-1-konrad@kernel.org> <20161121155651.4781-2-konrad@kernel.org> Cc: Ard Biesheuvel , xen-devel@lists.xenproject.org, edk2-devel-01 , "Jordan Justen (Intel address)" , Olaf Hering From: Laszlo Ersek Message-ID: <9faa1698-7471-3f47-e552-8da23c0f0195@redhat.com> Date: Mon, 21 Nov 2016 21:07:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 21 Nov 2016 20:07:28 +0000 (UTC) Subject: Re: [PATCH RESEND] OvmfPkg/build.sh: Use GCC49 toolchain with GCC 6.* X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Nov 2016 20:07:29 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 11/21/16 17:20, Ard Biesheuvel wrote: > On 21 November 2016 at 15:56, Konrad Rzeszutek Wilk wrote: >> Without this I cannot build it under Fedora Core 25. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Konrad Rzeszutek Wilk >> --- >> OvmfPkg/build.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh >> index eb5eb73..759ade3 100755 >> --- a/OvmfPkg/build.sh >> +++ b/OvmfPkg/build.sh >> @@ -95,7 +95,7 @@ case `uname` in >> 4.8.*) >> TARGET_TOOLS=GCC48 >> ;; >> - 4.9.*|4.1[0-9].*|5.*.*) >> + 4.9.*|4.1[0-9].*|5.*.*|6.*.*) >> TARGET_TOOLS=GCC49 >> ;; >> *) > > I think it may be time to start using GCC5 for 5.x and later I agree. We have an open BZ for this: https://bugzilla.tianocore.org/show_bug.cgi?id=62 Olaf Hering submitted a patch around June, but the formalities on those patches weren't right, and Olaf decided not to submit further versions of the patch. Here's the idea: - change the catch-all (*) to GCC5, from GCC44 - remove the (5.*.*) pattern from GCC49 - add a branch (with multiple patterns if necessary) for gcc-4.3 and earlier to exit with an error message / failure (those compiler versions are unsupported) Konrad, can you please submit a v2 with this? If so, please add the tag Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=62 as well, just before the "Contributed-under:" tag. (Side note: we haven't been ignoring BZ#62. It's just that after reviewing Olaf's original patch, implementing the change -- which is very simple and cannot really be done in different ways -- in his stead would have practically consisted of replacing Olaf's signoff with someone elses, and we couldn't do that.) Thank you, Laszlo