From: "Laszlo Ersek" <lersek@redhat.com>
To: Gary Lin <glin@suse.com>, devel@edk2.groups.io
Cc: Jordan Justen <jordan.l.justen@intel.com>,
Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: Re: [PATCH 04/11] OvmfPkg/LsiScsiDxe: Probe PCI devices and look for LsiScsi
Date: Tue, 7 Jul 2020 10:16:34 +0200 [thread overview]
Message-ID: <9fbaef5a-2c17-76a3-9bce-38f7cc467e96@redhat.com> (raw)
In-Reply-To: <70bbf8ce-4f34-192e-8115-53d53864f773@redhat.com>
On 07/07/20 10:15, Laszlo Ersek wrote:
> On 07/01/20 06:04, Gary Lin wrote:
>> Implement LsiScsiControllerSupported() to probe the PCI ID and look for
>> LSI 53C895A.
>>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
>> Signed-off-by: Gary Lin <glin@suse.com>
>> ---
>> OvmfPkg/Include/IndustryStandard/LsiScsi.h | 20 +++++++++
>> OvmfPkg/LsiScsiDxe/LsiScsi.c | 48 +++++++++++++++++++++-
>> OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf | 6 +++
>> 3 files changed, 73 insertions(+), 1 deletion(-)
>> create mode 100644 OvmfPkg/Include/IndustryStandard/LsiScsi.h
>>
>> diff --git a/OvmfPkg/Include/IndustryStandard/LsiScsi.h b/OvmfPkg/Include/IndustryStandard/LsiScsi.h
>> new file mode 100644
>> index 000000000000..c09e864a1f39
>> --- /dev/null
>> +++ b/OvmfPkg/Include/IndustryStandard/LsiScsi.h
>> @@ -0,0 +1,20 @@
>> +/** @file
>> +
>> + Macros and type definitions for LSI 53C895A SCSI devices.
>> +
>> + Copyright (C) 2020, SUSE LLC.
>> +
>> + SPDX-License-Identifier: BSD-2-Clause-Patent
>> +
>> +**/
>> +
>> +#ifndef _LSI_SCSI_H_
>> +#define _LSI_SCSI_H_
>> +
>> +//
>> +// Device ID
>> +//
>> +#define LSI_LOGIC_PCI_VENDOR_ID 0x1000
>> +#define LSI_53C895A_PCI_DEVICE_ID 0x0012
>> +
>> +#endif // _LSI_SCSI_H_
>> diff --git a/OvmfPkg/LsiScsiDxe/LsiScsi.c b/OvmfPkg/LsiScsiDxe/LsiScsi.c
>> index 62daa3ab99bf..5bca85bd75eb 100644
>> --- a/OvmfPkg/LsiScsiDxe/LsiScsi.c
>> +++ b/OvmfPkg/LsiScsiDxe/LsiScsi.c
>> @@ -9,7 +9,12 @@
>>
>> **/
>>
>> +#include <IndustryStandard/LsiScsi.h>
>> +#include <IndustryStandard/Pci.h>
>> +#include <Library/UefiBootServicesTableLib.h>
>> #include <Library/UefiLib.h>
>> +#include <Protocol/PciIo.h>
>> +#include <Protocol/PciRootBridgeIo.h>
>> #include <Uefi/UefiSpec.h>
>>
>> #include "LsiScsi.h"
>> @@ -31,7 +36,48 @@ LsiScsiControllerSupported (
>> IN EFI_DEVICE_PATH_PROTOCOL *RemainingDevicePath OPTIONAL
>> )
>> {
>> - return EFI_UNSUPPORTED;
>> + EFI_STATUS Status;
>> + EFI_PCI_IO_PROTOCOL *PciIo;
>> + PCI_TYPE00 Pci;
>> +
>> + Status = gBS->OpenProtocol (
>> + ControllerHandle,
>> + &gEfiPciIoProtocolGuid,
>> + (VOID **)&PciIo,
>> + This->DriverBindingHandle,
>> + ControllerHandle,
>> + EFI_OPEN_PROTOCOL_BY_DRIVER
>> + );
>> + if (EFI_ERROR (Status)) {
>> + return Status;
>> + }
>> +
>> + Status = PciIo->Pci.Read (
>> + PciIo,
>> + EfiPciIoWidthUint32,
>> + 0,
>> + sizeof (Pci) / sizeof (UINT32),
>> + &Pci
>> + );
>> + if (EFI_ERROR (Status)) {
>> + goto Done;
>> + }
>> +
>> + if (Pci.Hdr.VendorId == LSI_LOGIC_PCI_VENDOR_ID &&
>> + Pci.Hdr.DeviceId == LSI_53C895A_PCI_DEVICE_ID) {
>> + Status = EFI_SUCCESS;
>> + } else {
>> + Status = EFI_UNSUPPORTED;
>> + }
>> +
>> +Done:
>> + gBS->CloseProtocol (
>> + ControllerHandle,
>> + &gEfiPciIoProtocolGuid,
>> + This->DriverBindingHandle,
>> + ControllerHandle
>> + );
>> + return Status;
>> }
>>
>> EFI_STATUS
>> diff --git a/OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf b/OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf
>> index 444ceb78e9ca..e86c626a61aa 100644
>> --- a/OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf
>> +++ b/OvmfPkg/LsiScsiDxe/LsiScsiDxe.inf
>> @@ -22,7 +22,13 @@ [Sources]
>>
>> [Packages]
>> MdePkg/MdePkg.dec
>> + OvmfPkg/OvmfPkg.dec
>>
>> [LibraryClasses]
>> + BaseLib
>> + UefiBootServicesTableLib
>> UefiDriverEntryPoint
>> UefiLib
>> +
>> +[Protocols]
>> + gEfiPciIoProtocolGuid ## TO_START
>>
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
(I've checked PCI_VENDOR_ID_LSI_LOGIC in QEMU's
"include/hw/pci/pci_ids.h" and "hw/scsi/lsi53c895a.c". Also checked
PCI_DEVICE_ID_LSI_53C895A in the QEMU source.)
next prev parent reply other threads:[~2020-07-07 8:16 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 4:04 [PATCH 00/11] Introduce LsiScsi driver to OvmfPkg Gary Lin
2020-07-01 4:04 ` [PATCH 01/11] OvmfPkg/LsiScsiDxe: Create the empty driver Gary Lin
2020-07-07 7:59 ` Laszlo Ersek
2020-07-07 8:24 ` Gary Lin
2020-07-01 4:04 ` [PATCH 02/11] OvmfPkg/LsiScsiDxe: Install the skeleton of driver binding Gary Lin
2020-07-07 8:06 ` Laszlo Ersek
2020-07-07 8:34 ` Gary Lin
2020-07-01 4:04 ` [PATCH 03/11] OvmfPkg/LsiScsiDxe: Report the name of the driver Gary Lin
2020-07-07 8:09 ` Laszlo Ersek
2020-07-01 4:04 ` [PATCH 04/11] OvmfPkg/LsiScsiDxe: Probe PCI devices and look for LsiScsi Gary Lin
2020-07-07 8:15 ` Laszlo Ersek
2020-07-07 8:16 ` Laszlo Ersek [this message]
2020-07-01 4:04 ` [PATCH 05/11] OvmfPkg/LsiScsiDxe: Install stubbed EXT_SCSI_PASS_THRU Gary Lin
2020-07-07 8:28 ` Laszlo Ersek
2020-07-01 4:04 ` [PATCH 06/11] OvmfPkg/LsiScsiDxe: Report Targets and LUNs Gary Lin
2020-07-07 9:04 ` Laszlo Ersek
2020-07-08 2:34 ` Gary Lin
2020-07-08 15:26 ` Laszlo Ersek
2020-07-01 4:04 ` [PATCH 07/11] OvmfPkg/LsiScsiDxe: Open PciIo protocol and initialize the device Gary Lin
2020-07-07 9:46 ` Laszlo Ersek
2020-07-08 2:37 ` Gary Lin
2020-07-01 4:04 ` [PATCH 08/11] OvmfPkg/LsiScsiDxe: Map DMA buffer Gary Lin
2020-07-07 9:59 ` Laszlo Ersek
2020-07-08 2:41 ` Gary Lin
2020-07-01 4:04 ` [PATCH 09/11] OvmfPkg/LsiScsiDxe: Examine the incoming SCSI Request Packet Gary Lin
2020-07-07 10:17 ` Laszlo Ersek
2020-07-08 2:43 ` Gary Lin
2020-07-01 4:04 ` [PATCH 10/11] OvmfPkg/LsiScsiDxe: Process the " Gary Lin
2020-07-07 12:46 ` Laszlo Ersek
2020-07-08 6:02 ` Gary Lin
[not found] ` <161FB1B03BD2D339.11266@groups.io>
2020-07-14 8:19 ` [edk2-devel] " Gary Lin
2020-07-01 4:04 ` [PATCH 11/11] Maintainers.txt: Add myself as the reviewer for LsiScsi driver Gary Lin
2020-07-07 12:49 ` Laszlo Ersek
2020-07-08 6:03 ` Gary Lin
2020-07-03 14:08 ` [edk2-devel] [PATCH 00/11] Introduce LsiScsi driver to OvmfPkg Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fbaef5a-2c17-76a3-9bce-38f7cc467e96@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox