From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web10.8348.1579511684120191802 for ; Mon, 20 Jan 2020 01:14:44 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=WztRfBgp; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579511683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cpas0qq01R2q/oS45cX5NbrLwhHvAtKAXglZTKfe2LU=; b=WztRfBgpjWIYqDwIfPjmhVwk34ShbZojxyatsqKjkjCFuJWk92doGmGN705ZruRPKEZ+AI +5u73mYsWq92byn17+xM8rcCmFl4TJf5hUjTK3lBObMRHRp632CPTTI+WuVeBVlOdiHtLx Vgrk8pHamiSkrALoiSWzhzJDpI0CLRY= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-203-B2Z0hcpeO8GcOgZEtwrJ9w-1; Mon, 20 Jan 2020 04:14:42 -0500 Received: by mail-wr1-f70.google.com with SMTP id b13so13819619wrx.22 for ; Mon, 20 Jan 2020 01:14:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cpas0qq01R2q/oS45cX5NbrLwhHvAtKAXglZTKfe2LU=; b=ZVBLn8bg/s2bQ95eGoNCK7O8GpK2dPRMPRaPQVFA4zBn3JjvnaDfcWg2+dMEVtiOD8 ocJMM59uTFWCNql6TVRKVbThWa10KB0SEbFC5zhNYOm48Xeaefpmkh3UGhpbbRzwDLOi RFp7/5Pkh2y4LQCJpOWShE659ywQT9UM33WG+qfYuwYKD/61BiX6ZqFV7CmYTjEqgo4t 6YufZdNVU19TNOQlJNyDFOeZEqq7ZWyTA1apNiStLrrwnkN32ELgd4fYuaBAz27xIqVH AiHs2eowpJAHxu+7ovbCC+iYUk+ab2lUzLRdB6NRMG74kVzSBezfjsmXcKd7y0tI4C2q 1KyA== X-Gm-Message-State: APjAAAUilRnJ/9GL7GMINTV91bsH8VjJTm0ut9THLdW1QnUjZBRIXZPY 9HeN/qT46aHWg79GcbGrVKc9Ecf+ZKzs3ZFJnUgy6RAkH5j/MiKZb5ujnepQX8j+vj1Yl0bFaf1 XeG1VjNHWHAbKOg== X-Received: by 2002:a1c:770e:: with SMTP id t14mr17776147wmi.101.1579511680707; Mon, 20 Jan 2020 01:14:40 -0800 (PST) X-Google-Smtp-Source: APXvYqw1mB1Sjl9P+B8oiQAIGxpJOHXziYmaROgUvZnskJ+XjytIuLlxEoUWUSPGNRtf4La7DDSDSg== X-Received: by 2002:a1c:770e:: with SMTP id t14mr17776109wmi.101.1579511680378; Mon, 20 Jan 2020 01:14:40 -0800 (PST) Return-Path: Received: from [192.168.1.35] (113.red-83-57-172.dynamicip.rima-tde.net. [83.57.172.113]) by smtp.gmail.com with ESMTPSA id e8sm46746705wrt.7.2020.01.20.01.14.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2020 01:14:39 -0800 (PST) Subject: Re: [edk2-devel] [edk2-platforms][PATCH v1 1/1] Platform/ARM/ArmJunoDxe: Fix 'unused variable' error for DynamicTables To: devel@edk2.groups.io, krzysztof.koch@arm.com Cc: Ard Biesheuvel , Leif Lindholm , Michael D Kinney , Sami.Mujawar@arm.com, Matteo.Carlini@arm.com, nd@arm.com References: <20200109093536.76804-1-krzysztof.koch@arm.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <9fbf43f5-4bba-dd41-4590-86b4d9ab71a3@redhat.com> Date: Mon, 20 Jan 2020 10:14:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200109093536.76804-1-krzysztof.koch@arm.com> X-MC-Unique: B2Z0hcpeO8GcOgZEtwrJ9w-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 1/9/20 10:35 AM, Krzysztof Koch wrote: > Fix 'mAcpiRegistration defined but not used' compiler error for > Dynamic Tables Framework builds. > > Do not declare the mAcpiRegistration variable in the Dynamic Tables > Framework context. > > An earlier patch made mAcpiRegistration variable STATIC. Reducing the Can we change "An earlier patch" -> "Commit 484a683ab9f"? > scope made scope resolution simpler, thus, the 'defined but not used' > error got raised. > > Signed-off-by: Krzysztof Koch Reviewed-by: Philippe Mathieu-Daude > --- > > Changes can be seen at: https://github.com/KrzysztofKoch1/edk2-platforms/tree/723_fix_unused_variable_juno_dxe_v1 > > Notes: > v1: > - Fix 'defined but not used' Dynamic Tables build error [Krzysztof] > > Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c > index e3b64992e02c003f7e3a6636340a6afa573f477a..cd7a205f90f131560419cfd744dd5c22df726c99 100644 > --- a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c > +++ b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c > @@ -1,6 +1,6 @@ > /** @file > * > -* Copyright (c) 2013-2019, ARM Limited. All rights reserved. > +* Copyright (c) 2013-2020, ARM Limited. All rights reserved. > * > * SPDX-License-Identifier: BSD-2-Clause-Patent > * > @@ -30,9 +30,9 @@ > #ifndef DYNAMIC_TABLES_FRAMEWORK > // This GUID must match the FILE_GUID in ArmPlatformPkg/ArmJunoPkg/AcpiTables/AcpiTables.inf > STATIC CONST EFI_GUID mJunoAcpiTableFile = { 0xa1dd808e, 0x1e95, 0x4399, { 0xab, 0xc0, 0x65, 0x3c, 0x82, 0xe8, 0x53, 0x0c } }; > -#endif > - > STATIC VOID *mAcpiRegistration = NULL; > +#endif > + > STATIC VOID *mPciIoNotificationRegistration = NULL; > > /** > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > > > > >